You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bigtop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2016/10/06 07:01:20 UTC

[jira] [Updated] (BIGTOP-2549) "Expected" and "actual" values are mistakenly switched in some JUnit method invocation

     [ https://issues.apache.org/jira/browse/BIGTOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kengo Seki updated BIGTOP-2549:
-------------------------------
    Attachment: BIGTOP-2549.1.patch

Attaching a patch. I grepped bigtop-tests by assertEquals and fixed the same issues I found.

> "Expected" and "actual" values are mistakenly switched in some JUnit method invocation
> --------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-2549
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2549
>             Project: Bigtop
>          Issue Type: Bug
>          Components: tests
>            Reporter: Kengo Seki
>            Priority: Minor
>         Attachments: BIGTOP-2549.1.patch
>
>
> I ran hdfs smoke test, and got the following result:
> {code}
> org.apache.bigtop.itest.hadoop.hdfs.TestTextSnappy > testTextSnappy STANDARD_OUT
>     hadoop fs -text testtextsnappy.1475725399538/part-00001.snappy
>     Failed command: hadoop fs -text testtextsnappy.1475725399538/part-00001.snappy
> (snip)
>     Expected output:
>     1	rafferty	31
>     2	jones	33
>     3	steinberg	33
>     Actual output:
> org.apache.bigtop.itest.hadoop.hdfs.TestTextSnappy > testTextSnappy FAILED
>     org.junit.ComparisonFailure: Incorrect output expected:<[]> but was:<[1	rafferty	31
>     2	jones	33
>     3	steinberg	33]>
>         at org.junit.Assert.assertEquals(Assert.java:115)
> (snip)
> {code}
> "Expected" and "actual" outputs were swapped between the above two messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)