You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/06/02 22:50:59 UTC
Review Request 22159: Fixed memory leaks and cleaned up the mesos
containerizer logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22159/
-----------------------------------------------------------
Review request for mesos and Ian Downes.
Repository: mesos-git
Description
-------
I've also added some TODOs for further cleanup.
I couldn't see why we need to clear all the info's if there is an issue with a single RunState, but I left that as is.
Diffs
-----
src/slave/containerizer/isolators/cgroups/cpushare.hpp 36fa99758f72933f085baaae8c181348989ebc2e
src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
src/slave/containerizer/isolators/cgroups/mem.hpp 6e792565ee3a61f99f244be68b378709577c63da
src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
Diff: https://reviews.apache.org/r/22159/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 22159: Fixed memory leaks and cleaned up the mesos
containerizer logic.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22159/#review44579
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22159]
All tests passed.
- Mesos ReviewBot
On June 2, 2014, 8:50 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22159/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 8:50 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've also added some TODOs for further cleanup.
>
> I couldn't see why we need to clear all the info's if there is an issue with a single RunState, but I left that as is.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 36fa99758f72933f085baaae8c181348989ebc2e
> src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
> src/slave/containerizer/isolators/cgroups/mem.hpp 6e792565ee3a61f99f244be68b378709577c63da
> src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
>
> Diff: https://reviews.apache.org/r/22159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22159: Fixed memory leaks and cleaned up the mesos
containerizer logic.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22159/#review44598
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/cgroups/cpushare.hpp
<https://reviews.apache.org/r/22159/#comment79018>
s/Used/Use/
src/slave/containerizer/isolators/cgroups/mem.hpp
<https://reviews.apache.org/r/22159/#comment79019>
s/Used/Use/
- Ian Downes
On June 2, 2014, 6:28 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22159/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 6:28 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I've also added some TODOs for further cleanup.
>
> I couldn't see why we need to clear all the info's if there is an issue with a single RunState, but I left that as is.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 36fa99758f72933f085baaae8c181348989ebc2e
> src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
> src/slave/containerizer/isolators/cgroups/mem.hpp 6e792565ee3a61f99f244be68b378709577c63da
> src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
>
> Diff: https://reviews.apache.org/r/22159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22159: Fixed memory leaks and cleaned up the mesos
containerizer logic.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22159/
-----------------------------------------------------------
(Updated June 3, 2014, 1:28 a.m.)
Review request for mesos, Ian Downes and Vinod Kone.
Changes
-------
Adding vinod as a reviewer.
Repository: mesos-git
Description
-------
I've also added some TODOs for further cleanup.
I couldn't see why we need to clear all the info's if there is an issue with a single RunState, but I left that as is.
Diffs
-----
src/slave/containerizer/isolators/cgroups/cpushare.hpp 36fa99758f72933f085baaae8c181348989ebc2e
src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
src/slave/containerizer/isolators/cgroups/mem.hpp 6e792565ee3a61f99f244be68b378709577c63da
src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
Diff: https://reviews.apache.org/r/22159/diff/
Testing
-------
make check
Thanks,
Ben Mahler