[camel-k] 25/40: Marking tests as problematic

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

astefanutti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git

commit 07edf02aa000264d1568d7b46d98e1dda7888c42
Author: phantomjinx <p....@phantomjinx.co.uk>
AuthorDate: Thu Dec 9 14:38:02 2021 +0000

    Marking tests as problematic
    
    * Flagged to be fixed on OCP4
---
 e2e/common/cli/dev_mode_test.go  | 12 ++++++++++++
 e2e/common/traits/health_test.go | 23 +++++++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/e2e/common/cli/dev_mode_test.go b/e2e/common/cli/dev_mode_test.go
index 251d838..db7fd73 100644
--- a/e2e/common/cli/dev_mode_test.go
+++ b/e2e/common/cli/dev_mode_test.go
@@ -38,6 +38,18 @@ import (
 )
 
 func TestRunDevMode(t *testing.T) {
+
+	/*
+	 * TODO
+	 * The changing of the yaml file constant from "string" to "magic" is not being
+	 * picked up when deploying on OCP4 and so the test is failing.
+	 *
+	 * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+	 */
+	if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {
+		t.Skip("WARNING: Test marked as problematic ... skipping")
+	}
+
 	WithNewTestNamespace(t, func(ns string) {
 		Expect(Kamel("install", "-n", ns).Execute()).To(Succeed())
 
diff --git a/e2e/common/traits/health_test.go b/e2e/common/traits/health_test.go
index 353a6e5..d17e5a9 100644
--- a/e2e/common/traits/health_test.go
+++ b/e2e/common/traits/health_test.go
@@ -25,6 +25,7 @@ package traits
 import (
 	"encoding/json"
 	"fmt"
+	"os"
 	"testing"
 
 	. "github.com/onsi/gomega"
@@ -35,7 +36,17 @@ import (
 	v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
 )
 
+/*
+ * TODO
+ * Test has issues on OCP4. See TODO comment in-test for details.
+ *
+ * Adding CAMEL_K_TEST_SKIP_PROBLEMATIC env var for the moment.
+ */
 func TestHealthTrait(t *testing.T) {
+	if os.Getenv("CAMEL_K_TEST_SKIP_PROBLEMATIC") == "true" {
+		t.Skip("WARNING: Test marked as problematic ... skipping")
+	}
+
 	WithNewTestNamespace(t, func(ns string) {
 		Expect(Kamel("install", "-n", ns).Execute()).To(Succeed())
 
@@ -74,6 +85,18 @@ func TestHealthTrait(t *testing.T) {
 			// Check the ready condition has turned falsy
 			Eventually(IntegrationConditionStatus(ns, "java", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionFalse))
 			// And it contains details about the runtime state
+
+			//
+			// TODO
+			// Integration has different runtime state reporting on OCP4
+			//
+			// lastProbeTime: null
+			// lastTransitionTime: "2021-12-08T20:12:14Z"
+			// message: 'containers with unready status: [integration]'
+			// reason: ContainersNotReady
+			// status: "False"
+			// type: Ready
+			//
 			Eventually(IntegrationCondition(ns, "java", v1.IntegrationConditionReady), TestTimeoutMedium).Should(And(
 				WithTransform(IntegrationConditionReason, Equal(v1.IntegrationConditionRuntimeNotReadyReason)),
 				WithTransform(IntegrationConditionMessage, HavePrefix(fmt.Sprintf("[Pod %s runtime is not ready: map[consumer:route1:DOWN context:UP", pod.Name))),