[jira] [Commented] (NIFI-4095) ExtractText should not require a capture group in every regular expression

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057831#comment-16057831 ] 

ASF GitHub Bot commented on NIFI-4095:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/1931

    NIFI-4095

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-4095

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1931
    
----
commit 6e3029cd91cbaa94860b0f2018db22a05a8ff019
Author: Andy LoPresto <al...@apache.org>
Date:   2017-06-20T20:23:19Z

    NIFI-4095 Changed minimum capture group count in ExtractText from 1 to 0.
    Added unit test and removed obsolete test.

commit f87a6789dca9f7612ae9faeb927b06e39317fe27
Author: Andy LoPresto <al...@apache.org>
Date:   2017-06-21T16:49:00Z

    NIFI-4095 Added custom validation to enforce capture group if "include capture group 0" is false.
    Added unit test.

----


> ExtractText should not require a capture group in every regular expression
> --------------------------------------------------------------------------
>
>                 Key: NIFI-4095
>                 URL: https://issues.apache.org/jira/browse/NIFI-4095
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>              Labels: extracttext, regular_expression, validation
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The {{ExtractText}} processor currently validates every regular expression and requires that it contain "between 1 and 40 capture groups". This seems to be a design decision, as the values are hardcoded into the [validator|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java#L262-L262], but there are valid regular expressions that do not need an explicit capture group (especially when the expression is small and the full expression is the desired match). This results in unnecessary duplicate matches ("some_attr" and "some_attr.1" being identical). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)