You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2014/06/16 23:32:31 UTC

Review Request 22657: Routing: added an interface to get the MAC address on host public interface

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/
-----------------------------------------------------------

Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.


Repository: mesos


Description
-------

Routing: added an interface to get the MAC address on host public interface


Diffs
-----

  src/linux/routing/utils.hpp 3d7320a 
  src/linux/routing/utils.cpp 8ad5c86 
  src/tests/routing_tests.cpp bdeea28 

Diff: https://reviews.apache.org/r/22657/diff/


Testing
-------

make check


Thanks,

Chi Zhang

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review45942
-----------------------------------------------------------


Bad patch!

Reviews applied: [22593, 22593]

Failed command: git apply --index 22593.patch

Error:
 error: patch failed: src/linux/routing/link/link.hpp:37
error: src/linux/routing/link/link.hpp: patch does not apply
error: patch failed: src/linux/routing/link/link.cpp:32
error: src/linux/routing/link/link.cpp: patch does not apply


- Mesos ReviewBot


On June 16, 2014, 9:32 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 9:32 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Chi Zhang <ch...@gmail.com>.

> On June 23, 2014, 6:15 p.m., Vinod Kone wrote:
> > bad diff?

I haven't gotten around to fixing this. Network Isolator doesn't directly require this so this will come soon.


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review46422
-----------------------------------------------------------


On June 16, 2014, 9:32 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 9:32 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review46422
-----------------------------------------------------------


bad diff?

- Vinod Kone


On June 16, 2014, 9:32 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 9:32 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review45837
-----------------------------------------------------------


I think this is missing some depends?

- Ian Downes


On June 16, 2014, 2:32 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 2:32 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review46817
-----------------------------------------------------------


See my comments in https://reviews.apache.org/r/22598/

- Jie Yu


On June 27, 2014, 12:15 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:15 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review46933
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22598, 22657]

All tests passed.

- Mesos ReviewBot


On June 27, 2014, 12:15 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:15 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/
-----------------------------------------------------------

(Updated June 27, 2014, 12:15 a.m.)


Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.


Repository: mesos


Description
-------

Routing: added an interface to get the MAC address on host public interface


Diffs
-----

  src/linux/routing/utils.hpp 3d7320a 
  src/linux/routing/utils.cpp 8ad5c86 
  src/tests/routing_tests.cpp bdeea28 

Diff: https://reviews.apache.org/r/22657/diff/


Testing
-------

make check


Thanks,

Chi Zhang

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/
-----------------------------------------------------------

(Updated June 27, 2014, 12:15 a.m.)


Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.


Repository: mesos


Description
-------

Routing: added an interface to get the MAC address on host public interface


Diffs
-----

  src/linux/routing/utils.hpp 3d7320a 
  src/linux/routing/utils.cpp 8ad5c86 
  src/tests/routing_tests.cpp bdeea28 

Diff: https://reviews.apache.org/r/22657/diff/


Testing
-------

make check


Thanks,

Chi Zhang

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/#review46609
-----------------------------------------------------------


Bad patch!

Reviews applied: [22593]

Failed command: git apply --index 22593.patch

Error:
 error: patch failed: src/linux/routing/link/link.hpp:37
error: src/linux/routing/link/link.hpp: patch does not apply
error: patch failed: src/linux/routing/link/link.cpp:32
error: src/linux/routing/link/link.cpp: patch does not apply


- Mesos ReviewBot


On June 24, 2014, 7:27 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22657/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 7:27 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Routing: added an interface to get the MAC address on host public interface
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/utils.hpp 3d7320a 
>   src/linux/routing/utils.cpp 8ad5c86 
>   src/tests/routing_tests.cpp bdeea28 
> 
> Diff: https://reviews.apache.org/r/22657/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 22657: Routing: added an interface to get the MAC address on host public interface

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22657/
-----------------------------------------------------------

(Updated June 24, 2014, 7:27 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.


Changes
-------

removed extra dependency.


Repository: mesos


Description
-------

Routing: added an interface to get the MAC address on host public interface


Diffs
-----

  src/linux/routing/utils.hpp 3d7320a 
  src/linux/routing/utils.cpp 8ad5c86 
  src/tests/routing_tests.cpp bdeea28 

Diff: https://reviews.apache.org/r/22657/diff/


Testing
-------

make check


Thanks,

Chi Zhang