[GitHub] [zookeeper] anmolnar commented on issue #1167: Fix haveDelivered wrong implementation.

[GitBox <gi...@apache.org>]

anmolnar commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-569423927
 
 
   @KimRasak Is that a scenario that you mention in your latest comments is something that you've seen happened in a real cluster? I'm asking, because I'd like to get confidence in your change before accepting it. You're about to make changes in leader election, so we have to be very careful about that.
   
   Regarding the failing scenario (I think it would be more realistic with odd number of participants, but doesn't really matter.) can we say that all participants will get the most recent notifications from s1, because they all have a healthy connection to it? In which case having live connection between all nodes might not be a requirement of a successful leader election.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services