You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/10/22 12:40:54 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
milleruntime opened a new pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325
This reverts commit 2e8144ec89e74d37c7ff97d301051fea747e05c7.
The move of this class breaks API compatibility in the class hierarchy. I am not sure how the parent class being in the `clientImpl` is not picked up by the apilyzer plugin. It could be since the super class of AbstractLexicoder in `clientImpl` happens to be in the public API that it doesn't actually expose any internal class. While it is awkward that AbstractLexicoder is in a different non-API package, it seems that it ultimately doesn't matter for the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325#issuecomment-961297031
Closing since I don't think we want to do this revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325#issuecomment-961297031
Closing since I don't think we want to do this revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325#issuecomment-949883388
> Were we able to confirm that this actually breaks compatibility?
The only breakage I was able to reproduce was a "cannot find symbol" error since the class was moved. But this is easily fixed by changing the import. And this is with the import of the class from a "clientImpl" package.
I am not convinced this needs to be reverted. I only opened this PR in reference to the Slack conversation and your findings in https://people.apache.org/~ctubbsii/compliance/2.0-2.1.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325#issuecomment-961297031
Closing since I don't think we want to do this revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #2325: Revert "Move AbstractLexicoder to API (#1400)"
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #2325:
URL: https://github.com/apache/accumulo/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org