You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/04/29 21:27:45 UTC

[PR] Updated projects settings in .asf.yaml (features, merge buttons, Jira autolinking) [thrift]

kpumuk opened a new pull request, #3430:
URL: https://github.com/apache/thrift/pull/3430

   <!-- Explain the changes in the pull request below: -->
   
   This change will:
   
   * Enable Jira autolinking for the THRIFT project (see commits in https://github.com/apache/zookeeper for example)
   * Disable "merge" button, leaving only "Squash and merge" and "Rebase and merge". According to the [contribution guide](https://thrift.apache.org/docs/HowToContribute), merge commits are discouraged
   * Disable [Projects](https://github.com/apache/thrift/projects) feature
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updated projects settings in .asf.yaml (features, merge buttons, Jira autolinking) [thrift]

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3430:
URL: https://github.com/apache/thrift/pull/3430


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updated projects settings in .asf.yaml (features, merge buttons, Jira autolinking) [thrift]

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3430:
URL: https://github.com/apache/thrift/pull/3430#discussion_r3178369002


##########
.asf.yaml:
##########
@@ -1,8 +1,29 @@
+# ASF Configuration for Apache Thrift
+# See https://github.com/apache/infrastructure-asfyaml/blob/main/README.md
 notifications:
-    commits:      commits@thrift.apache.org
-    issues:       dev@thrift.apache.org
-    pullrequests_status: dev@thrift.apache.org
-    pullrequests_comment: notifications@thrift.apache.org
-    jira_options: link label worklog
-    
-    
\ No newline at end of file
+  commits: commits@thrift.apache.org
+  issues: dev@thrift.apache.org
+  pullrequests_status: dev@thrift.apache.org
+  pullrequests_comment: notifications@thrift.apache.org
+  jira_options: link label worklog
+
+github:
+  autolink_jira:
+    - THRIFT
+  enabled_merge_buttons:
+    squash: true
+    rebase: true
+    # Linear history and squashed commits are preferred.
+    # See https://thrift.apache.org/docs/HowToContribute
+    merge: false
+  features:

Review Comment:
   Why do we want to forbid merge entirely?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Updated projects settings in .asf.yaml (features, merge buttons, Jira autolinking) [thrift]

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3430:
URL: https://github.com/apache/thrift/pull/3430#discussion_r3255580629


##########
.asf.yaml:
##########
@@ -1,8 +1,29 @@
+# ASF Configuration for Apache Thrift
+# See https://github.com/apache/infrastructure-asfyaml/blob/main/README.md
 notifications:
-    commits:      commits@thrift.apache.org
-    issues:       dev@thrift.apache.org
-    pullrequests_status: dev@thrift.apache.org
-    pullrequests_comment: notifications@thrift.apache.org
-    jira_options: link label worklog
-    
-    
\ No newline at end of file
+  commits: commits@thrift.apache.org
+  issues: dev@thrift.apache.org
+  pullrequests_status: dev@thrift.apache.org
+  pullrequests_comment: notifications@thrift.apache.org
+  jira_options: link label worklog
+
+github:
+  autolink_jira:
+    - THRIFT
+  enabled_merge_buttons:
+    squash: true
+    rebase: true
+    # Linear history and squashed commits are preferred.
+    # See https://thrift.apache.org/docs/HowToContribute
+    merge: false
+  features:

Review Comment:
   > According to the [contribution guide](https://thrift.apache.org/docs/HowToContribute), merge commits are discouraged
   
   That document needs probably some maintenance. It derives from the practical implementation in certain aspects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org