You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2020/04/10 19:30:13 UTC
Review Request 72349: Added logging of peer address in OpenSSLSocket
accept failures.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72349/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-10112
https://issues.apache.org/jira/browse/MESOS-10112
Repository: mesos
Description
-------
The caller of OpenSSLSocket::accept() cannot see who tried to
connect when accept fails, since the accepted socket is not returned.
This adds logging of the peer address when the SSL handshake fails,
in order to improve debugging.
Diffs
-----
3rdparty/libprocess/src/ssl/openssl_socket.cpp a2ec0a3c0178409980ccfad46019340ba8085e3d
Diff: https://reviews.apache.org/r/72349/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 72349: Added logging of peer address in
OpenSSLSocket accept failures.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72349/#review220313
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 10, 2020, 7:30 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72349/
> -----------------------------------------------------------
>
> (Updated April 10, 2020, 7:30 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-10112
> https://issues.apache.org/jira/browse/MESOS-10112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The caller of OpenSSLSocket::accept() cannot see who tried to
> connect when accept fails, since the accepted socket is not returned.
> This adds logging of the peer address when the SSL handshake fails,
> in order to improve debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/openssl_socket.cpp a2ec0a3c0178409980ccfad46019340ba8085e3d
>
>
> Diff: https://reviews.apache.org/r/72349/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 72349: Added logging of peer address in
OpenSSLSocket accept failures.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72349/#review220286
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72348, 72349]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On April 10, 2020, 7:30 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72349/
> -----------------------------------------------------------
>
> (Updated April 10, 2020, 7:30 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-10112
> https://issues.apache.org/jira/browse/MESOS-10112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The caller of OpenSSLSocket::accept() cannot see who tried to
> connect when accept fails, since the accepted socket is not returned.
> This adds logging of the peer address when the SSL handshake fails,
> in order to improve debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/openssl_socket.cpp a2ec0a3c0178409980ccfad46019340ba8085e3d
>
>
> Diff: https://reviews.apache.org/r/72349/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>