You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2012/08/06 20:12:02 UTC
[jira] [Created] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Eugene Koontz created GIRAPH-281:
------------------------------------
Summary: add options to control Netty's per-channel receive and send buffer sizes
Key: GIRAPH-281
URL: https://issues.apache.org/jira/browse/GIRAPH-281
Project: Giraph
Issue Type: Improvement
Reporter: Eugene Koontz
Assignee: Eugene Koontz
Priority: Minor
Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429441#comment-13429441 ]
Avery Ching commented on GIRAPH-281:
------------------------------------
Thanks for the initial part Eugene. I'm modifying it. Will be done soon.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430464#comment-13430464 ]
Eugene Koontz commented on GIRAPH-281:
--------------------------------------
Hi Avery,
Thanks, you are right:
http://docs.oracle.com/javase/7/docs/api/java/net/StandardSocketOptions.html?is-external=true#SO_RCVBUF
"The value of the socket option is a hint to the implementation to size the buffer and the actual size may differ."
I wasn't aware of that.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated GIRAPH-281:
---------------------------------
Attachment: GIRAPH-281.patch
-Add client-side netty-config test to ConnectionTest
-Add Avery's config fix for RequestTest
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429622#comment-13429622 ]
Avery Ching commented on GIRAPH-281:
------------------------------------
Eugene, I'm going to pull the testClientChannelConfiguration() since these are just hints and not guaranteed, based on the underlying system. This causes the unittest failure.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated GIRAPH-281:
---------------------------------
Attachment: GIRAPH-281.patch
Adds parts of ConnectionTest that I missed in the first patch.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429615#comment-13429615 ]
Hudson commented on GIRAPH-281:
-------------------------------
Integrated in Giraph-trunk-Commit #158 (See [https://builds.apache.org/job/Giraph-trunk-Commit/158/])
GIRAPH-281: Add options to control Netty's per-channel receive and
send buffer sizes (ekoontz via aching). (Revision 1370071)
Result = FAILURE
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370071
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/NettyServer.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
* /giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
* /giraph/trunk/src/test/java/org/apache/giraph/comm/RequestTest.java
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated GIRAPH-281:
---------------------------------
Attachment: GIRAPH-281.patch
Fix checkstyle violations in earlier patches.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated GIRAPH-281:
---------------------------------
Attachment: GIRAPH-281.patch
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429576#comment-13429576 ]
Eugene Koontz commented on GIRAPH-281:
--------------------------------------
(meaning I should have indicated that it passed "mvn clean verify") :)
Thanks,
Eugene
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429542#comment-13429542 ]
Avery Ching commented on GIRAPH-281:
------------------------------------
Eugene, does this pass 'mvn clean verify'?
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429631#comment-13429631 ]
Hudson commented on GIRAPH-281:
-------------------------------
Integrated in Giraph-trunk-Commit #160 (See [https://builds.apache.org/job/Giraph-trunk-Commit/160/])
Reverting testClientChannelConfiguration only from GIRAPH-281. (Revision 1370086)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370086
Files :
* /giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-281:
-------------------------------
Attachment: GIRAPH-281.2.patch
I think you missed the RequestTest.java changes. This should include. Please take a look so I can rebase GIRAPH-262 again. Thanks!
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429584#comment-13429584 ]
Jakob Homan commented on GIRAPH-281:
------------------------------------
+1. Verified against verify.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-281) add options to control Netty's
per-channel receive and send buffer sizes
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429573#comment-13429573 ]
Eugene Koontz commented on GIRAPH-281:
--------------------------------------
Hi Avery,
Yes, it does - should have indicated that in last comment.
> add options to control Netty's per-channel receive and send buffer sizes
> ------------------------------------------------------------------------
>
> Key: GIRAPH-281
> URL: https://issues.apache.org/jira/browse/GIRAPH-281
> Project: Giraph
> Issue Type: Improvement
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Priority: Minor
> Attachments: GIRAPH-281.2.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch, GIRAPH-281.patch
>
>
> Avery added these as part of GIRAPH-262, but I think they merit their own JIRA with a patch extracted from his GIRAPH-262 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira