You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by knaufk <gi...@git.apache.org> on 2016/04/07 12:31:40 UTC

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

GitHub user knaufk opened a pull request:

    https://github.com/apache/flink/pull/1861

    [FLINK-3688] WindowOperator.trigger() does not emit Watermark anymore

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Conflicts:
    	flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knaufk/flink FLINK-3688

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1861
    
----
commit 0afb53afa19d6ce791367fe15729bec27d114a8b
Author: Konstantin Knauf <ko...@tngtech.com>
Date:   2016-04-03T11:57:35Z

    [FLINK-3688] WindowOperator.trigger() does not emit Watermark anymore
    
    Conflicts:
    	flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1861#issuecomment-207287141
  
    Thanks for your work! I'll merge it today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1861#issuecomment-207440713
  
    Could you please close if github does not do so automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

Posted by knaufk <gi...@git.apache.org>.
Github user knaufk closed the pull request at:

    https://github.com/apache/flink/pull/1861


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---