You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ygerzhedovich (via GitHub)" <gi...@apache.org> on 2023/06/16 10:16:43 UTC
[GitHub] [ignite-3] ygerzhedovich opened a new pull request, #2205: IGNITE-19755: move common test classes to testFixtures for runner module
ygerzhedovich opened a new pull request, #2205:
URL: https://github.com/apache/ignite-3/pull/2205
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #2205:
URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1238270424
##########
modules/runner/build.gradle:
##########
@@ -158,8 +158,21 @@ dependencies {
integrationTestImplementation libs.typesafe.config
integrationTestImplementation libs.auto.service.annotations
+ testFixturesImplementation project(':ignite-core')
testFixturesImplementation project(':ignite-api')
+ testFixturesImplementation project(':ignite-raft-api')
+ testFixturesImplementation project(':ignite-raft')
testFixturesImplementation project(':ignite-sql-engine')
+ testFixturesImplementation project(':ignite-table')
+ testFixturesImplementation project(':ignite-schema')
+ testFixturesImplementation testFixtures(project(':ignite-api'))
+ testFixturesImplementation testFixtures(project(':ignite-core'))
+ testFixturesImplementation testFixtures(project(':ignite-network'))
+ testFixturesImplementation libs.jetbrains.annotations
+ testFixturesImplementation libs.junit5.api
+ testFixturesImplementation libs.junit5.impl
+ testFixturesImplementation libs.junit5.params
Review Comment:
Yes, you are right. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2205:
URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779
##########
modules/runner/build.gradle:
##########
@@ -158,8 +158,21 @@ dependencies {
integrationTestImplementation libs.typesafe.config
integrationTestImplementation libs.auto.service.annotations
+ testFixturesImplementation project(':ignite-core')
testFixturesImplementation project(':ignite-api')
+ testFixturesImplementation project(':ignite-raft-api')
+ testFixturesImplementation project(':ignite-raft')
testFixturesImplementation project(':ignite-sql-engine')
+ testFixturesImplementation project(':ignite-table')
+ testFixturesImplementation project(':ignite-schema')
+ testFixturesImplementation testFixtures(project(':ignite-api'))
+ testFixturesImplementation testFixtures(project(':ignite-core'))
+ testFixturesImplementation testFixtures(project(':ignite-network'))
+ testFixturesImplementation libs.jetbrains.annotations
+ testFixturesImplementation libs.junit5.api
+ testFixturesImplementation libs.junit5.impl
+ testFixturesImplementation libs.junit5.params
Review Comment:
Do we really need all of this?
Look like these dependencies was already added above
`apply from: "$rootDir/buildscripts/java-test-fixtures.gradle"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #2205:
URL: https://github.com/apache/ignite-3/pull/2205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2205: IGNITE-19755: move common test classes to testFixtures for runner module
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2205:
URL: https://github.com/apache/ignite-3/pull/2205#discussion_r1236861779
##########
modules/runner/build.gradle:
##########
@@ -158,8 +158,21 @@ dependencies {
integrationTestImplementation libs.typesafe.config
integrationTestImplementation libs.auto.service.annotations
+ testFixturesImplementation project(':ignite-core')
testFixturesImplementation project(':ignite-api')
+ testFixturesImplementation project(':ignite-raft-api')
+ testFixturesImplementation project(':ignite-raft')
testFixturesImplementation project(':ignite-sql-engine')
+ testFixturesImplementation project(':ignite-table')
+ testFixturesImplementation project(':ignite-schema')
+ testFixturesImplementation testFixtures(project(':ignite-api'))
+ testFixturesImplementation testFixtures(project(':ignite-core'))
+ testFixturesImplementation testFixtures(project(':ignite-network'))
+ testFixturesImplementation libs.jetbrains.annotations
+ testFixturesImplementation libs.junit5.api
+ testFixturesImplementation libs.junit5.impl
+ testFixturesImplementation libs.junit5.params
Review Comment:
Do we really need all of this?
Look like these dependencies already added here
`apply from: "$rootDir/buildscripts/java-test-fixtures.gradle"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org