You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/06/18 22:23:12 UTC
[1/3] incubator-reef git commit: [REEF-388]: Fix violations of
RedundantModifier checkstyle
Repository: incubator-reef
Updated Branches:
refs/heads/master 9964d5db3 -> 660ee805d
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
index 11348b9..3f1977f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
@@ -35,18 +35,18 @@ public interface Tang {
*
* @throws BindException If the confs conflict, a BindException will be thrown.
*/
- public Injector newInjector(final Configuration... confs)
+ Injector newInjector(final Configuration... confs)
throws BindException;
/**
* Returns an Injector for the given Configuration.
*/
- public Injector newInjector(final Configuration confs);
+ Injector newInjector(final Configuration confs);
/**
* Returns an Injector based on an empty Configuration.
*/
- public Injector newInjector();
+ Injector newInjector();
/**
* Return a new ConfigurationBuilder that is backed by the provided
@@ -55,7 +55,7 @@ public interface Tang {
* @param ch Any valid Tang ClassHierarchy, including ones derived from non-Java application binaries.
* @return an instance of ConfigurationBuilder. In Tang's default implementation this returns an instance or JavaConfigurationBuilder if ch is backed by a Java classloader.
*/
- public ConfigurationBuilder newConfigurationBuilder(ClassHierarchy ch);
+ ConfigurationBuilder newConfigurationBuilder(ClassHierarchy ch);
/**
* Create a new ConfigurationBuilder that is backed by the default
@@ -66,7 +66,7 @@ public interface Tang {
*
* @return a new JavaConfigurationBuilder
*/
- public JavaConfigurationBuilder newConfigurationBuilder(URL... jars);
+ JavaConfigurationBuilder newConfigurationBuilder(URL... jars);
/**
* Merge a set of configurations into a new JavaConfiurationBuilder. If
@@ -82,7 +82,7 @@ public interface Tang {
* conflicting bindings, or if the backing ClassHierarchy objects conflict
* in some way.
*/
- public JavaConfigurationBuilder newConfigurationBuilder(Configuration... confs)
+ JavaConfigurationBuilder newConfigurationBuilder(Configuration... confs)
throws BindException;
/**
@@ -92,7 +92,7 @@ public interface Tang {
*
* @return a new ConfigurationBuilder
*/
- public JavaConfigurationBuilder newConfigurationBuilder(@SuppressWarnings("unchecked") Class<? extends ExternalConstructor<?>>... parameterParsers)
+ JavaConfigurationBuilder newConfigurationBuilder(@SuppressWarnings("unchecked") Class<? extends ExternalConstructor<?>>... parameterParsers)
throws BindException;
/**
@@ -104,21 +104,21 @@ public interface Tang {
* this class for detailed information about each of the parameters to
* this method.
*/
- public JavaConfigurationBuilder newConfigurationBuilder(URL[] jars,
- Configuration[] confs, Class<? extends ExternalConstructor<?>>[] parameterParsers) throws BindException;
+ JavaConfigurationBuilder newConfigurationBuilder(URL[] jars,
+ Configuration[] confs, Class<? extends ExternalConstructor<?>>[] parameterParsers) throws BindException;
/**
* Create a new empty ConfigurationBuilder that is backed by the default
* classloader.
*/
- public JavaConfigurationBuilder newConfigurationBuilder();
+ JavaConfigurationBuilder newConfigurationBuilder();
/**
* @return an instance of JavaClassHierarchy that is backed by the default
* Java classloader. ClassHierarchy objects are immutable, so multiple
* invocations of this method may return the same instance.
*/
- public JavaClassHierarchy getDefaultClassHierarchy();
+ JavaClassHierarchy getDefaultClassHierarchy();
/**
* @return a custom instance of JavaClassHierarchy. ClassHierarchy objects
@@ -129,7 +129,7 @@ public interface Tang {
* getDefaultClassHierarchy(). If so, we should add a new method like
* getNonDefaultClassHiearchy() that takes the same options as this one.
*/
- public JavaClassHierarchy getDefaultClassHierarchy(URL[] jars, Class<? extends ExternalConstructor<?>>[] parsers);
+ JavaClassHierarchy getDefaultClassHierarchy(URL[] jars, Class<? extends ExternalConstructor<?>>[] parsers);
/**
* A factory that returns the default implementation of the Tang interface.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java
index 6b1a985..53d5f81 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java
@@ -24,7 +24,7 @@ import org.apache.reef.tang.annotations.NamedParameter;
@DefaultImplementation(TimerImpl.class)
public interface Timer {
- public void sleep() throws Exception;
+ void sleep() throws Exception;
@NamedParameter(default_value = "10",
doc = "Number of seconds to sleep", short_name = "sec")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
index a20719d..7fec4f6 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
@@ -120,6 +120,7 @@ public final class CommandLine {
* @throws ParseException
*/
@SafeVarargs
+ @SuppressWarnings("checkstyle:redundantmodifier")
final public <T> CommandLine processCommandLine(
final String[] args, Class<? extends Name<?>>... argClasses)
throws IOException, BindException {
@@ -212,6 +213,6 @@ public final class CommandLine {
}
public interface CommandLineCallback {
- public void process(final Option option);
+ void process(final Option option);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
index 43d9d11..ae7ebba 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
@@ -72,7 +72,7 @@ public class ConfigurationModule {
return cm;
}
- private final <T> void processSet(Object impl) {
+ private <T> void processSet(Object impl) {
Field f = builder.map.get(impl);
if (f == null) { /* throw */
throw new ClassHierarchyException("Unknown Impl/Param when setting " + ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
index da5eb09..6d58f0a 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
@@ -309,7 +309,7 @@ public abstract class ConfigurationModuleBuilder {
return c;
}
- private final <T> void processUse(Object impl) {
+ private <T> void processUse(Object impl) {
Field f = map.get(impl);
if (f == null) { /* throw */
throw new ClassHierarchyException("Unknown Impl/Param when binding " + ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
index f286f53..f4b811e 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
@@ -40,7 +40,7 @@ public interface ConfigurationSerializer {
* @param file the file to store the Configuration in
* @throws java.io.IOException if there is an IO error in the process.
*/
- public void toFile(final Configuration conf, final File file) throws IOException;
+ void toFile(final Configuration conf, final File file) throws IOException;
/**
* Stores the given Configuration in the given Text File.
@@ -49,7 +49,7 @@ public interface ConfigurationSerializer {
* @param file the file to store the Configuration in
* @throws java.io.IOException if there is an IO error in the process.
*/
- public void toTextFile(final Configuration conf, final File file) throws IOException;
+ void toTextFile(final Configuration conf, final File file) throws IOException;
/**
* Writes the Configuration to a byte[].
@@ -58,7 +58,7 @@ public interface ConfigurationSerializer {
* @return
* @throws IOException
*/
- public byte[] toByteArray(final Configuration conf) throws IOException;
+ byte[] toByteArray(final Configuration conf) throws IOException;
/**
* Writes the Configuration as a String.
@@ -66,7 +66,7 @@ public interface ConfigurationSerializer {
* @param configuration
* @return a String representation of the Configuration
*/
- public String toString(final Configuration configuration);
+ String toString(final Configuration configuration);
/**
@@ -77,7 +77,7 @@ public interface ConfigurationSerializer {
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- public Configuration fromFile(final File file) throws IOException, BindException;
+ Configuration fromFile(final File file) throws IOException, BindException;
/**
* Loads a Configuration from a File created with toFile().
@@ -87,7 +87,7 @@ public interface ConfigurationSerializer {
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- public Configuration fromTextFile(final File file) throws IOException, BindException;
+ Configuration fromTextFile(final File file) throws IOException, BindException;
/**
* Loads a Configuration from a File created with toFile() with ClassHierarchy.
@@ -97,7 +97,7 @@ public interface ConfigurationSerializer {
* @return
* @throws IOException
*/
- public Configuration fromTextFile(final File file, final ClassHierarchy classHierarchy) throws IOException;
+ Configuration fromTextFile(final File file, final ClassHierarchy classHierarchy) throws IOException;
/**
* Loads a Configuration from a File created with toFile().
@@ -108,7 +108,7 @@ public interface ConfigurationSerializer {
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- public Configuration fromFile(final File file, final ClassHierarchy classHierarchy) throws IOException, BindException;
+ Configuration fromFile(final File file, final ClassHierarchy classHierarchy) throws IOException, BindException;
/**
* Loads a Configuration from a byte[] created with toByteArray().
@@ -118,7 +118,7 @@ public interface ConfigurationSerializer {
* @throws IOException if the byte[] can't be deserialized
* @throws BindException if the byte[] contains an illegal Configuration.
*/
- public Configuration fromByteArray(final byte[] theBytes) throws IOException, BindException;
+ Configuration fromByteArray(final byte[] theBytes) throws IOException, BindException;
/**
* Loads a Configuration from a byte[] created with toByteArray().
@@ -129,7 +129,7 @@ public interface ConfigurationSerializer {
* @throws IOException if the byte[] can't be deserialized
* @throws BindException if the byte[] contains an illegal Configuration.
*/
- public Configuration fromByteArray(final byte[] theBytes, final ClassHierarchy classHierarchy) throws IOException, BindException;
+ Configuration fromByteArray(final byte[] theBytes, final ClassHierarchy classHierarchy) throws IOException, BindException;
/**
* Decodes a String generated via toString().
@@ -139,7 +139,7 @@ public interface ConfigurationSerializer {
* @throws IOException if theString can't be parsed.
* @throws BindException if theString contains an illegal Configuration.
*/
- public Configuration fromString(final String theString) throws IOException, BindException;
+ Configuration fromString(final String theString) throws IOException, BindException;
/**
* Decodes a String generated via toString().
@@ -150,5 +150,5 @@ public interface ConfigurationSerializer {
* @throws IOException if theString can't be parsed.
* @throws BindException if theString contains an illegal Configuration.
*/
- public Configuration fromString(final String theString, final ClassHierarchy classHierarchy) throws IOException, BindException;
+ Configuration fromString(final String theString, final ClassHierarchy classHierarchy) throws IOException, BindException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java
index 1cca8f9..042e499 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java
@@ -24,24 +24,24 @@ import java.util.Set;
public interface ClassNode<T> extends Node {
- public ConstructorDef<T>[] getInjectableConstructors();
+ ConstructorDef<T>[] getInjectableConstructors();
- public ConstructorDef<T> getConstructorDef(ClassNode<?>... args)
+ ConstructorDef<T> getConstructorDef(ClassNode<?>... args)
throws BindException;
- public ConstructorDef<T>[] getAllConstructors();
+ ConstructorDef<T>[] getAllConstructors();
- public void putImpl(ClassNode<T> impl);
+ void putImpl(ClassNode<T> impl);
- public Set<ClassNode<T>> getKnownImplementations();
+ Set<ClassNode<T>> getKnownImplementations();
- public String getDefaultImplementation();
+ String getDefaultImplementation();
- public boolean isUnit();
+ boolean isUnit();
- public boolean isInjectionCandidate();
+ boolean isInjectionCandidate();
- public boolean isExternalConstructor();
+ boolean isExternalConstructor();
- public boolean isImplementationOf(ClassNode<?> inter);
+ boolean isImplementationOf(ClassNode<?> inter);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java
index d2bd091..994afb6 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java
@@ -20,11 +20,11 @@ package org.apache.reef.tang.types;
public interface ConstructorArg {
- public String getName();
+ String getName();
- public String getType();
+ String getType();
- public boolean isInjectionFuture();
+ boolean isInjectionFuture();
- public String getNamedParameterName();
+ String getNamedParameterName();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java
index ac3dcc6..0a03ab7 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java
@@ -19,11 +19,11 @@
package org.apache.reef.tang.types;
public interface ConstructorDef<T> extends Comparable<ConstructorDef<?>> {
- public String getClassName();
+ String getClassName();
- public ConstructorArg[] getArgs();
+ ConstructorArg[] getArgs();
- public boolean isMoreSpecificThan(ConstructorDef<?> def);
+ boolean isMoreSpecificThan(ConstructorDef<?> def);
- public boolean takesParameters(ClassNode<?>[] paramTypes);
+ boolean takesParameters(ClassNode<?>[] paramTypes);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java
index fa4d14c..085d355 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java
@@ -20,17 +20,17 @@ package org.apache.reef.tang.types;
public interface NamedParameterNode<T> extends Node {
- public String getDocumentation();
+ String getDocumentation();
- public String getShortName();
+ String getShortName();
- public String[] getDefaultInstanceAsStrings();
+ String[] getDefaultInstanceAsStrings();
- public String getSimpleArgName();
+ String getSimpleArgName();
- public String getFullArgName();
+ String getFullArgName();
- public boolean isSet();
+ boolean isSet();
- public boolean isList();
+ boolean isList();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
index 130e93f..c559761 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
@@ -426,7 +426,7 @@ public class Tint {
}
}
- private final boolean classFilter(boolean checkTang, String s) {
+ private boolean classFilter(boolean checkTang, String s) {
return (checkTang || /*s.startsWith("org.apache.reef.tang.examples.timer") ||*/ !s.startsWith("org.apache.reef.tang"));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java
index 9e5bd53..8621bcc 100644
--- a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java
+++ b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java
@@ -49,7 +49,7 @@ public final class DFSHandler extends Handler {
this.streamHandler = new StreamHandler(logOutputStream, logFormatter);
}
- private static final <T> T getInstance(final String className, final T defaultValue) {
+ private static <T> T getInstance(final String className, final T defaultValue) {
try {
final Class aClass = ClassLoader.getSystemClassLoader().loadClass(className);
return (T) aClass.newInstance();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java
index c6a8a79..c6ceebb 100644
--- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java
+++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java
@@ -36,13 +36,13 @@ public interface Cache<K, V> {
* @return a value
* @throws ExecutionException
*/
- public V get(K key, Callable<V> valueFetcher) throws ExecutionException;
+ V get(K key, Callable<V> valueFetcher) throws ExecutionException;
/**
* Invalidates a key from the cache.
*
* @param key a key
*/
- public void invalidate(K key);
+ void invalidate(K key);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java
index 318cd77..14e1332 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java
@@ -30,5 +30,5 @@ public interface EventHandler<T> {
*
* @param value an event
*/
- public void onNext(T value);
+ void onNext(T value);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java
index d94f05b..8387c2e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java
@@ -25,6 +25,6 @@ public interface Identifiable {
*
* @return an identifier of this object
*/
- public Identifier getId();
+ Identifier getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java
index 9884197..f73b53f 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java
@@ -33,7 +33,7 @@ public interface Identifier {
*
* @return a hash code value for this object
*/
- public int hashCode();
+ int hashCode();
/**
* Checks that another object is equal to this object.
@@ -42,13 +42,13 @@ public interface Identifier {
* @return true if the object is the same as the object argument; false,
* otherwise
*/
- public boolean equals(Object o);
+ boolean equals(Object o);
/**
* Return a string representation of this object. This method should return a
* URL-style string, that begins with "type://", where "type" is chosen to
* uniquely identify this type of identifier.
*/
- public String toString();
+ String toString();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java
index 583d131..82516fa 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java
@@ -26,6 +26,6 @@ public interface IdentifierFactory {
* @param str a string
* @return an identifier
*/
- public Identifier getNewInstance(String str);
+ Identifier getNewInstance(String str);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java
index 952f960..2b6f5cd 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java
@@ -29,5 +29,5 @@ public interface EventSource<T> {
/**
* @return a event or null if no more messages are available.
*/
- public T getNext();
+ T getNext();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java
index dd3d7ee..1f1fd34 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java
@@ -56,7 +56,7 @@ public final class Pull2Push<T> implements Runnable, AutoCloseable {
* @param source The source that will be added to the queue of this
* Pull2Push
*/
- public final void register(final EventSource<T> source) {
+ public void register(final EventSource<T> source) {
this.sources.add(source);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
index 2c84274..d27b719 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
@@ -51,7 +51,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
}
@Override
- public final void onNext(final T event) {
+ public void onNext(final T event) {
this.events.add(event);
int newCursor = this.cursor.incrementAndGet();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
index bdb66e2..7b582bb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
@@ -46,7 +46,7 @@ public final class BlockingSignalEventHandler<T> implements EventHandler<T> {
}
@Override
- public final void onNext(final T event) {
+ public void onNext(final T event) {
int newSize = this.cursor.incrementAndGet();
if (newSize % expectedSize == 0) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java
index c348c67..5870447 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java
@@ -28,14 +28,14 @@ public interface Histogram {
*
* @param value the new value
*/
- public void update(long value);
+ void update(long value);
/**
* Returns the number of recorded values.
*
* @return the number of recorded values
*/
- public long getCount();
+ long getCount();
/**
* Returns the value of the index.
@@ -44,12 +44,12 @@ public interface Histogram {
* @return the value of the index
* @throws IndexOutOfBoundsException
*/
- public long getValue(int index);
+ long getValue(int index);
/**
* Returns the number of bins.
*
* @return the number of bins
*/
- public int getNumBins();
+ int getNumBins();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java
index bdb88dd..6383ab4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java
@@ -32,5 +32,5 @@ public interface Decoder<T> {
* @param buf
* @return the decoded object
*/
- public T decode(byte[] data);
+ T decode(byte[] data);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java
index ef1b11f..9670ada 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java
@@ -37,5 +37,5 @@ public interface RemoteIdentifierFactory extends IdentifierFactory {
* @return a remote identifier
*/
@Override
- public RemoteIdentifier getNewInstance(String str);
+ RemoteIdentifier getNewInstance(String str);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
index 12c4a0c..e954ec3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
@@ -42,7 +42,7 @@ public interface RemoteManager extends Stage {
* @param messageType a message class type
* @return an event handler
*/
- public <T> EventHandler<T> getHandler(final RemoteIdentifier destinationIdentifier, final Class<? extends T> messageType);
+ <T> EventHandler<T> getHandler(final RemoteIdentifier destinationIdentifier, final Class<? extends T> messageType);
/**
* Registers the given EventHandler to be invoked when messages of Type T
@@ -56,7 +56,7 @@ public interface RemoteManager extends Stage {
* @param theHandler the event handler
* @return the subscription that can be used to unsubscribe later
*/
- public <T, U extends T> AutoCloseable registerHandler(final RemoteIdentifier sourceIdentifier, final Class<U> messageType, final EventHandler<T> theHandler);
+ <T, U extends T> AutoCloseable registerHandler(final RemoteIdentifier sourceIdentifier, final Class<U> messageType, final EventHandler<T> theHandler);
/**
* Registers the given EventHandler to be called for the given message type
@@ -69,7 +69,7 @@ public interface RemoteManager extends Stage {
* @param theHandler the event handler
* @return the subscription that can be used to unsubscribe later
*/
- public <T, U extends T> AutoCloseable registerHandler(final Class<U> messageType, final EventHandler<RemoteMessage<T>> theHandler);
+ <T, U extends T> AutoCloseable registerHandler(final Class<U> messageType, final EventHandler<RemoteMessage<T>> theHandler);
/**
* Register an EventHandler that gets called by Wake in the presence of
@@ -80,12 +80,12 @@ public interface RemoteManager extends Stage {
* @return the subscription that can be used to unsubscribe later
*/
@Deprecated
- public AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler);
+ AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler);
/**
* Access the Identifier of this.
*
* @return the Identifier of this.
*/
- public RemoteIdentifier getMyIdentifier();
+ RemoteIdentifier getMyIdentifier();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java
index f43fbb8..7dcba73 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java
@@ -30,13 +30,13 @@ public interface RemoteMessage<T> {
*
* @return a remote identifier
*/
- public RemoteIdentifier getIdentifier();
+ RemoteIdentifier getIdentifier();
/**
* Returns an actual message.
*
* @return a message
*/
- public T getMessage();
+ T getMessage();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java
index e54f030..478b9ec 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java
@@ -32,7 +32,7 @@ public interface LinkListener<T> {
*
* @param message the sent message
*/
- public void onSuccess(T message);
+ void onSuccess(T message);
/**
* Called when the sent message to remoteAddress is failed to be transferred.
@@ -41,5 +41,5 @@ public interface LinkListener<T> {
* @param remoteAddress the exception occurred remote address
* @param message the send message
*/
- public void onException(Throwable cause, SocketAddress remoteAddress, T message);
+ void onException(Throwable cause, SocketAddress remoteAddress, T message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java
index 424453c..9979588 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java
@@ -44,7 +44,7 @@ public interface Transport extends Stage {
* @return a link associated with the address
* @throws IOException
*/
- public <T> Link<T> open(SocketAddress remoteAddr, Encoder<? super T> encoder, LinkListener<? super T> listener) throws IOException;
+ <T> Link<T> open(SocketAddress remoteAddr, Encoder<? super T> encoder, LinkListener<? super T> listener) throws IOException;
/**
* Returns a link for the remote address if already cached; otherwise, returns null.
@@ -52,26 +52,26 @@ public interface Transport extends Stage {
* @param remoteAddr the remote address
* @return a link if already cached; otherwise, null
*/
- public <T> Link<T> get(SocketAddress remoteAddr);
+ <T> Link<T> get(SocketAddress remoteAddr);
/**
* Gets a server listening port of this transport.
*
* @return a listening port number
*/
- public int getListeningPort();
+ int getListeningPort();
/**
* Gets a server local socket address of this transport.
*
* @return a server local socket address
*/
- public SocketAddress getLocalAddress();
+ SocketAddress getLocalAddress();
/**
* Registers the exception handler.
*
* @param handler the exception handler
*/
- public void registerErrorHandler(EventHandler<Exception> handler);
+ void registerErrorHandler(EventHandler<Exception> handler);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
index e126013..a58da0e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
@@ -40,10 +40,10 @@ public interface TransportFactory {
* @param exHandler an exception handler
* @return transport
*/
- public Transport newInstance(int port,
- EventHandler<TransportEvent> clientHandler,
- EventHandler<TransportEvent> serverHandler,
- EventHandler<Exception> exHandler);
+ Transport newInstance(int port,
+ EventHandler<TransportEvent> clientHandler,
+ EventHandler<TransportEvent> serverHandler,
+ EventHandler<Exception> exHandler);
/**
* Creates a transport.
@@ -56,11 +56,11 @@ public interface TransportFactory {
* @param retryTimeout retry timeout
* @return transport
*/
- public Transport newInstance(final String hostAddress, int port,
- final EStage<TransportEvent> clientStage,
- final EStage<TransportEvent> serverStage,
- final int numberOfTries,
- final int retryTimeout);
+ Transport newInstance(final String hostAddress, int port,
+ final EStage<TransportEvent> clientStage,
+ final EStage<TransportEvent> serverStage,
+ final int numberOfTries,
+ final int retryTimeout);
/**
* Creates a transport.
@@ -74,13 +74,13 @@ public interface TransportFactory {
* @param tcpPortProvider tcpPortProvider
* @return transport
*/
- public Transport newInstance(final String hostAddress,
- int port,
- final EStage<TransportEvent> clientStage,
- final EStage<TransportEvent> serverStage,
- final int numberOfTries,
- final int retryTimeout,
- final TcpPortProvider tcpPortProvider);
+ Transport newInstance(final String hostAddress,
+ int port,
+ final EStage<TransportEvent> clientStage,
+ final EStage<TransportEvent> serverStage,
+ final int numberOfTries,
+ final int retryTimeout,
+ final TcpPortProvider tcpPortProvider);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
index 7004191..10de932 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
@@ -32,7 +32,7 @@ public interface Observer<T> {
*
* @param value
*/
- public void onNext(final T value);
+ void onNext(final T value);
/**
* Notifies the observer that the provider has experienced an error
@@ -40,11 +40,11 @@ public interface Observer<T> {
*
* @param error
*/
- public void onError(final Exception error);
+ void onError(final Exception error);
/**
* Notifies the observer that the provider has finished sending push-based
* notifications.
*/
- public void onCompleted();
+ void onCompleted();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
index 0172df2..639ce02 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
@@ -48,27 +48,27 @@ public interface Clock extends Runnable, AutoCloseable {
* @param offset into the future
* @throws IllegalStateException when the clock has been already closed
*/
- public void scheduleAlarm(final int offset, final EventHandler<Alarm> handler);
+ void scheduleAlarm(final int offset, final EventHandler<Alarm> handler);
/**
* This will stop the clock after all client alarms
* finish executing.
*/
@Override
- public void close();
+ void close();
/**
* This stops the clock immediately, without waiting for
* client alarms to finish.
*/
- public void stop();
+ void stop();
/**
* Clock is idle if it has no future Alarms set.
*
* @return true if idle, otherwise false
*/
- public boolean isIdle();
+ boolean isIdle();
/**
* Bind this to an event handler to statically subscribe to the StartTime Event.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
index 6149db4..e52d759 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
@@ -74,7 +74,7 @@ public final class RuntimeClock implements Clock {
}
@Override
- public final void scheduleAlarm(final int offset, final EventHandler<Alarm> handler) {
+ public void scheduleAlarm(final int offset, final EventHandler<Alarm> handler) {
synchronized (this.schedule) {
if (this.closed) {
throw new IllegalStateException("Scheduling alarm on a closed clock");
@@ -85,11 +85,11 @@ public final class RuntimeClock implements Clock {
}
}
- public final void registerEventHandler(final Class<? extends Time> clazz, final EventHandler<Time> handler) {
+ public void registerEventHandler(final Class<? extends Time> clazz, final EventHandler<Time> handler) {
this.handlers.subscribe(clazz, handler);
}
- public final void scheduleRuntimeAlarm(final int offset, final EventHandler<Alarm> handler) {
+ public void scheduleRuntimeAlarm(final int offset, final EventHandler<Alarm> handler) {
synchronized (this.schedule) {
this.schedule.add(new RuntimeAlarm(this.timer.getCurrent() + offset, handler));
this.schedule.notifyAll();
@@ -97,7 +97,7 @@ public final class RuntimeClock implements Clock {
}
@Override
- public final void stop() {
+ public void stop() {
LOG.entering(RuntimeClock.class.getCanonicalName(), "stop");
synchronized (this.schedule) {
this.schedule.clear();
@@ -109,7 +109,7 @@ public final class RuntimeClock implements Clock {
}
@Override
- public final void close() {
+ public void close() {
LOG.entering(RuntimeClock.class.getCanonicalName(), "close");
synchronized (this.schedule) {
if (this.closed) {
@@ -132,7 +132,7 @@ public final class RuntimeClock implements Clock {
*
* @return an acceptable stop time
*/
- private final long findAcceptableStopTime() {
+ private long findAcceptableStopTime() {
long time = timer.getCurrent();
for (Time t : this.schedule) {
if (t instanceof ClientAlarm) {
@@ -145,7 +145,7 @@ public final class RuntimeClock implements Clock {
@Override
- public final boolean isIdle() {
+ public boolean isIdle() {
synchronized (this.schedule) {
for (Time t : this.schedule) {
if (t instanceof ClientAlarm) {
@@ -156,7 +156,7 @@ public final class RuntimeClock implements Clock {
}
}
- private final <T extends Time> void subscribe(final Class<T> eventClass, final Set<EventHandler<T>> handlers) {
+ private <T extends Time> void subscribe(final Class<T> eventClass, final Set<EventHandler<T>> handlers) {
for (final EventHandler<T> handler : handlers) {
this.handlers.subscribe(eventClass, handler);
}
@@ -178,7 +178,7 @@ public final class RuntimeClock implements Clock {
}
@Override
- public final void run() {
+ public void run() {
LOG.entering(RuntimeClock.class.getCanonicalName(), "run");
try {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
index a58f76e..6104c26 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
@@ -34,7 +34,7 @@ public interface DriverInfoSerializer {
* @param startTime
* @return AvroDriverInfo object
*/
- public AvroDriverInfo toAvro(final String id, final String startTime, final List<AvroReefServiceInfo> services);
+ AvroDriverInfo toAvro(final String id, final String startTime, final List<AvroReefServiceInfo> services);
/**
* Convert AvroDriverInfo object to JSon string.
@@ -42,5 +42,5 @@ public interface DriverInfoSerializer {
* @param avroDriverInfo
* @return
*/
- public String toString(final AvroDriverInfo avroDriverInfo);
+ String toString(final AvroDriverInfo avroDriverInfo);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
index d9575d7..3acfd92 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
@@ -36,7 +36,7 @@ public interface EvaluatorListSerializer {
* @param startTime
* @return
*/
- public AvroEvaluatorList toAvro(final Map<String, EvaluatorDescriptor> evaluatorMap, final int totalEvaluators, final String startTime);
+ AvroEvaluatorList toAvro(final Map<String, EvaluatorDescriptor> evaluatorMap, final int totalEvaluators, final String startTime);
/**
* Convert AvroEvaluatorList to JSon string.
@@ -44,5 +44,5 @@ public interface EvaluatorListSerializer {
* @param avroEvaluatorList
* @return
*/
- public String toString(final AvroEvaluatorList avroEvaluatorList);
+ String toString(final AvroEvaluatorList avroEvaluatorList);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
index 4315924..128e187 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
@@ -31,14 +31,14 @@ public interface HttpHandler {
*
* @return
*/
- public String getUriSpecification();
+ String getUriSpecification();
/**
* return specification of the handler. e.g Reef
*
* @return
*/
- public void setUriSpecification(final String s);
+ void setUriSpecification(final String s);
/**
* Will be called when request comes.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
index 73e1705..d49d774 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
@@ -28,26 +28,26 @@ public interface HttpServer {
*
* @throws Exception
*/
- public void start() throws Exception;
+ void start() throws Exception;
/**
* stop the server.
*
* @throws Exception
*/
- public void stop() throws Exception;
+ void stop() throws Exception;
/**
* get port number of the server.
*
* @return
*/
- public int getPort();
+ int getPort();
/**
* Add a httpHandler to the server.
*
* @param httpHandler
*/
- public void addHttpHandler(final HttpHandler httpHandler);
+ void addHttpHandler(final HttpHandler httpHandler);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java
index 5992e5f..2835421 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java
@@ -56,7 +56,7 @@ public final class HttpTrackingURLProvider implements TrackingURLProvider {
* @return
*/
@Override
- public final String getTrackingUrl() {
+ public String getTrackingUrl() {
try {
return InetAddress.getLocalHost().getHostAddress() + ":" + httpServer.getPort();
} catch (final UnknownHostException e) {
[2/3] incubator-reef git commit: [REEF-388]: Fix violations of
RedundantModifier checkstyle
Posted by we...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
index f1e1a66..ffbc3d0 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
@@ -33,18 +33,18 @@ public interface ExceptionCodec {
* @param bytes
* @return the Throable or Optional.empty() if the deserialization fails.
*/
- public Optional<Throwable> fromBytes(final byte[] bytes);
+ Optional<Throwable> fromBytes(final byte[] bytes);
/**
* @param bytes
* @return fromBytes(bytes.get()) or Optional.empty()
*/
- public Optional<Throwable> fromBytes(final Optional<byte[]> bytes);
+ Optional<Throwable> fromBytes(final Optional<byte[]> bytes);
/**
* @param throwable
* @return the serialized form of the given Throwable.
*/
- public byte[] toBytes(final Throwable throwable);
+ byte[] toBytes(final Throwable throwable);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
index fd0bc58..e41f6a8 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
@@ -42,5 +42,5 @@ public interface Task {
* @throws Exception whenever the Task encounters an unsolved issue.
* This Exception will be thrown at the Driver's event handler.
*/
- public byte[] call(final byte[] memento) throws Exception;
+ byte[] call(final byte[] memento) throws Exception;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
index 1424c03..2c4525e 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
@@ -35,5 +35,5 @@ public interface TaskMessageSource {
/**
* @return a message to be sent back to the Driver, or Optional.empty() if no message shall be sent at this time.
*/
- public Optional<TaskMessage> getMessage();
+ Optional<TaskMessage> getMessage();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
index b22b523..fc0aada 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
@@ -34,5 +34,5 @@ public interface CloseEvent {
/**
* @return the message sent with the close call, if any.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
index 56fcdce..dbcff98 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
@@ -34,5 +34,5 @@ public interface DriverMessage {
/**
* @return the message sent by the driver.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
index 7e8d880..8b1f929 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
@@ -34,5 +34,5 @@ public interface SuspendEvent {
/**
* @return the message sent with the suspend call, if any.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
index ca8542e..ecbe475 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
@@ -32,5 +32,5 @@ public interface TaskStop extends Identifiable {
/**
* @return the task identifier
*/
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
index 0a70677..29a55ab 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
@@ -31,5 +31,5 @@ public interface Builder<T> {
*
* @return a fresh instance of the object.
*/
- public T build();
+ T build();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
index 54db4f8..55d7eed 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
@@ -33,7 +33,7 @@ final public class CommandUtils {
*/
private static final Logger LOG = Logger.getLogger(CommandUtils.class.getName());
- public final static String runCommand(final String command) {
+ public static String runCommand(final String command) {
final StringBuilder sb = new StringBuilder();
try {
final String cmd = OSUtils.isWindows() ? "cmd.exe /c " + command : command;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
index 2f2a7f3..820d12f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
@@ -25,5 +25,5 @@ package org.apache.reef.util.logging;
public interface LoggingScope extends AutoCloseable {
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
index 33f60a3..18f4623 100644
--- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
+++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
@@ -77,7 +77,7 @@ public final class HelloDriver {
* @return task configuration for the CLR Task.
* @throws BindException
*/
- private static final Configuration getCLRTaskConfiguration(final String taskId) throws BindException {
+ private static Configuration getCLRTaskConfiguration(final String taskId) throws BindException {
final ConfigurationBuilder taskConfigurationBuilder = Tang.Factory.getTang()
.newConfigurationBuilder(loadClassHierarchy());
taskConfigurationBuilder.bind("Org.Apache.Reef.Tasks.TaskConfigurationOptions+Identifier,Org.Apache.Reef.Tasks.ITask, Version=1.0.0.0, Culture=neutral, PublicKeyToken=69c3241e6f0468ca", taskId);
@@ -108,7 +108,7 @@ public final class HelloDriver {
*
* @param allocatedEvaluator
*/
- final void onNextCLR(final AllocatedEvaluator allocatedEvaluator) {
+ void onNextCLR(final AllocatedEvaluator allocatedEvaluator) {
try {
allocatedEvaluator.setProcess(clrProcessFactory.newEvaluatorProcess());
final Configuration contextConfiguration = ContextConfiguration.CONF
@@ -130,7 +130,7 @@ public final class HelloDriver {
*
* @param allocatedEvaluator
*/
- final void onNextJVM(final AllocatedEvaluator allocatedEvaluator) {
+ void onNextJVM(final AllocatedEvaluator allocatedEvaluator) {
try {
final Configuration contextConfiguration = ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "HelloREEFContext")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
index d43d27f..bf75239 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
@@ -88,7 +88,7 @@ public class BGDClient {
return DriverLauncher.getLauncher(runtimeConfiguration).run(driverConfiguration, timeout);
}
- private final Configuration getDriverConfiguration(final String jobName) {
+ private Configuration getDriverConfiguration(final String jobName) {
return Configurations.merge(
getDataLoadConfiguration(jobName),
GroupCommService.getConfiguration(fanOut),
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
index 2987fde..c0f92c1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
@@ -27,6 +27,6 @@ import org.apache.reef.examples.group.bgd.data.Example;
*/
public interface Parser<T> {
- public Example parse(final T input);
+ Example parse(final T input);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
index f91e693..b5e86ba 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
@@ -31,14 +31,14 @@ public interface Vector extends ImmutableVector, Serializable {
* @param i the index
* @param v value
*/
- public void set(final int i, final double v);
+ void set(final int i, final double v);
/**
* Adds the Vector that to this one in place: this += that.
*
* @param that
*/
- public void add(final Vector that);
+ void add(final Vector that);
/**
* this += factor * that.
@@ -46,20 +46,20 @@ public interface Vector extends ImmutableVector, Serializable {
* @param factor
* @param that
*/
- public void multAdd(final double factor, final ImmutableVector that);
+ void multAdd(final double factor, final ImmutableVector that);
/**
* Scales this Vector: this *= factor.
*
* @param factor the scaling factor.
*/
- public void scale(final double factor);
+ void scale(final double factor);
/**
* Normalizes the Vector according to the L2 norm.
*/
- public void normalize();
+ void normalize();
/**
* Create a new instance of the current type.
@@ -67,6 +67,6 @@ public interface Vector extends ImmutableVector, Serializable {
*
* @return zero vector of current dimensionality
*/
- public Vector newInstance();
+ Vector newInstance();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
index 17bce48..5c0b8ec 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
@@ -32,7 +32,7 @@ public final class HelloTask implements Task {
}
@Override
- public final byte[] call(final byte[] memento) {
+ public byte[] call(final byte[] memento) {
System.out.println("Hello, REEF!");
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
index 1733ad8..9d40c63 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
@@ -55,7 +55,7 @@ public final class SchedulerREEF {
/**
* @return The http configuration to use reef-webserver
*/
- private final static Configuration getHttpConf() {
+ private static Configuration getHttpConf() {
final Configuration httpHandlerConf = HttpHandlerConfiguration.CONF
.set(HttpHandlerConfiguration.HTTP_HANDLERS, SchedulerHttpHandler.class)
.build();
@@ -65,7 +65,7 @@ public final class SchedulerREEF {
/**
* @return The Driver configuration.
*/
- private final static Configuration getDriverConf() {
+ private static Configuration getDriverConf() {
final Configuration driverConf = DriverConfiguration.CONF
.set(DriverConfiguration.GLOBAL_LIBRARIES, EnvironmentUtils.getClassLocation(SchedulerDriver.class))
.set(DriverConfiguration.DRIVER_IDENTIFIER, "TaskScheduler")
@@ -104,7 +104,7 @@ public final class SchedulerREEF {
* @param args
* @throws InjectionException
*/
- public final static void main(String[] args) throws InjectionException, IOException, ParseException {
+ public static void main(String[] args) throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration = LocalRuntimeConfiguration.CONF
.set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, MAX_NUMBER_OF_EVALUATORS)
.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
index 3bdacfc..1a462e1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
@@ -37,7 +37,7 @@ public final class SchedulerREEFYarn {
* @throws InjectionException
* @throws java.io.IOException
*/
- public final static void main(String[] args)
+ public static void main(String[] args)
throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration =
YarnClientConfiguration.CONF.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
index 5ae5009..a016529 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
@@ -145,7 +145,7 @@ public class SuspendDriver {
*/
final class RunningTaskHandler implements EventHandler<RunningTask> {
@Override
- public final void onNext(final RunningTask task) {
+ public void onNext(final RunningTask task) {
LOG.log(Level.INFO, "Running task: {0}", task.getId());
runningTasks.put(task.getId(), task);
jobMessageObserver.sendMessageToClient(CODEC_STR.encode("start task: " + task.getId()));
@@ -157,7 +157,7 @@ public class SuspendDriver {
*/
final class CompletedTaskHandler implements EventHandler<CompletedTask> {
@Override
- public final void onNext(final CompletedTask task) {
+ public void onNext(final CompletedTask task) {
final EvaluatorDescriptor e = task.getActiveContext().getEvaluatorDescriptor();
final String msg = "Task completed " + task.getId() + " on node " + e;
@@ -186,7 +186,7 @@ public class SuspendDriver {
*/
final class SuspendedTaskHandler implements EventHandler<SuspendedTask> {
@Override
- public final void onNext(final SuspendedTask task) {
+ public void onNext(final SuspendedTask task) {
final String msg = "Task suspended: " + task.getId();
LOG.info(msg);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
index 59967d8..07fb635 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
@@ -42,7 +42,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
}
@Override
- public final void onNext(final T event) {
+ public void onNext(final T event) {
if (this.isComplete()) {
throw new IllegalStateException("Received more Events than expected");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
index 8590aee..3f5b1b8 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
@@ -33,5 +33,5 @@ public interface ConnectionFactory<T> {
* @param destId a destination identifier
* @return a connection
*/
- public Connection<T> newConnection(Identifier destId);
+ Connection<T> newConnection(Identifier destId);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
index 3b9194c..3c5bfa2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
@@ -42,7 +42,7 @@ public interface CommunicationGroupDriver {
* @param spec
* @return
*/
- public CommunicationGroupDriver addBroadcast(Class<? extends Name<String>> operatorName, BroadcastOperatorSpec spec);
+ CommunicationGroupDriver addBroadcast(Class<? extends Name<String>> operatorName, BroadcastOperatorSpec spec);
/**
* Add the reduce operator specified by the.
@@ -53,7 +53,7 @@ public interface CommunicationGroupDriver {
* @param spec
* @return
*/
- public CommunicationGroupDriver addReduce(Class<? extends Name<String>> operatorName, ReduceOperatorSpec spec);
+ CommunicationGroupDriver addReduce(Class<? extends Name<String>> operatorName, ReduceOperatorSpec spec);
/**
* This signals to the service that no more.
@@ -61,7 +61,7 @@ public interface CommunicationGroupDriver {
* group and an attempt to do that will throw an
* IllegalStateException
*/
- public void finalise();
+ void finalise();
/**
* Returns a configuration that includes the partial task
@@ -73,7 +73,7 @@ public interface CommunicationGroupDriver {
* @param taskConf
* @return
*/
- public Configuration getTaskConfiguration(Configuration taskConf);
+ Configuration getTaskConfiguration(Configuration taskConf);
/**
* Add the task represented by this configuration to this
@@ -82,5 +82,5 @@ public interface CommunicationGroupDriver {
*
* @param partialTaskConf
*/
- public void addTask(Configuration partialTaskConf);
+ void addTask(Configuration partialTaskConf);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
index 41a2e07..ef72d3f 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
@@ -55,7 +55,7 @@ public interface TaskNodeStatus {
* As this is called from the TaskNodeImpl use srcId of msg
* In TaskNodeImpl while processMsg use dstId of msg
*/
- public void expectAckFor(final Type msgType, final String srcId);
+ void expectAckFor(final Type msgType, final String srcId);
/**
* Used when the task has failed to clear all.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
index 0b133cb..6054c23 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
@@ -36,7 +36,7 @@ public interface Broadcast {
* Sender or Root.
*/
@DefaultImplementation(BroadcastSender.class)
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send element to all receivers.
@@ -48,7 +48,7 @@ public interface Broadcast {
* Receivers or Non-roots.
*/
@DefaultImplementation(BroadcastReceiver.class)
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receiver the element broadcasted by sender.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
index a31336d..dc356d7 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
@@ -34,7 +34,7 @@ public interface Gather {
/**
* Senders or non-roots.
*/
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send the element to the root/receiver.
@@ -45,7 +45,7 @@ public interface Gather {
/**
* Receiver or Root.
*/
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive the elements sent by the senders in default order.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
index 98fc2b6..76688eb 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
@@ -39,7 +39,7 @@ public interface Reduce {
* Receiver or Root.
*/
@DefaultImplementation(ReduceReceiver.class)
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive values sent by senders and pass them through the reduce
@@ -69,7 +69,7 @@ public interface Reduce {
* Senders or non roots.
*/
@DefaultImplementation(ReduceSender.class)
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send the element to the root.
@@ -88,7 +88,7 @@ public interface Reduce {
* Interface for a Reduce Function takes in an {@link Iterable} returns an.
* aggregate value computed from the {@link Iterable}
*/
- static interface ReduceFunction<T> {
+ interface ReduceFunction<T> {
/**
* Apply the function on elements.
*
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
index 20b65c9..5dba002 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
@@ -35,7 +35,7 @@ public interface Scatter {
/**
* Sender or Root.
*/
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Distributes evenly across task ids sorted lexicographically.
@@ -63,7 +63,7 @@ public interface Scatter {
/**
* Receiver or non-roots.
*/
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive the sub-list of elements targeted for the current receiver.
*
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
index 21bd1e2..0625b4c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
@@ -35,7 +35,7 @@ public interface NameServer extends Stage {
* get port number.
* @return
*/
- public int getPort();
+ int getPort();
/**
* Registers an (identifier, address) mapping locally.
@@ -43,14 +43,14 @@ public interface NameServer extends Stage {
* @param id an identifier
* @param addr an Internet socket address
*/
- public void register(final Identifier id, final InetSocketAddress addr);
+ void register(final Identifier id, final InetSocketAddress addr);
/**
* Unregisters an identifier locally.
*
* @param id an identifier
*/
- public void unregister(final Identifier id);
+ void unregister(final Identifier id);
/**
* Finds an address for an identifier locally.
@@ -58,7 +58,7 @@ public interface NameServer extends Stage {
* @param id an identifier
* @return an Internet socket address
*/
- public InetSocketAddress lookup(final Identifier id);
+ InetSocketAddress lookup(final Identifier id);
/**
* Finds addresses for identifiers locally.
@@ -66,5 +66,5 @@ public interface NameServer extends Stage {
* @param identifiers an Iterable of identifiers
* @return a list of name assignments
*/
- public List<NameAssignment> lookup(final Iterable<Identifier> identifiers);
+ List<NameAssignment> lookup(final Iterable<Identifier> identifiers);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
index 81f9b14..ce9bcc5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
@@ -41,7 +41,7 @@ final class AvroUtils {
* @param <T>
* @return
*/
- static final <T> byte[] toBytes(T avroObject, Class<T> theClass) {
+ static <T> byte[] toBytes(T avroObject, Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
index 2c928f4..8991fa1 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
@@ -63,7 +63,7 @@ public final class HDICLI {
/**
* Helper method to setup apache commons logging.
*/
- private static final void setupLogging() {
+ private static void setupLogging() {
System.setProperty("org.apache.commons.logging.Log", "org.apache.commons.logging.impl.Jdk14Logger");
System.setProperty(".level", "INFO");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
index d1f2928..311ef94 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
@@ -75,7 +75,7 @@ final class LogFileEntry {
* @param outputWriter
* @throws IOException
*/
- private final void writeFiles(final DataInputStream valueStream, final Writer outputWriter) throws IOException {
+ private void writeFiles(final DataInputStream valueStream, final Writer outputWriter) throws IOException {
while (valueStream.available() > 0) {
final String strFileName = valueStream.readUTF();
final int entryLength = Integer.parseInt(valueStream.readUTF());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
index 0c7219b..151c9a1 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
@@ -124,7 +124,7 @@ public final class HDInsightJobSubmissionHandler implements JobSubmissionHandler
/**
* Extracts the resource demands from the jobSubmissionEvent.
*/
- private final Resource getResource(
+ private Resource getResource(
final JobSubmissionEvent jobSubmissionEvent) {
return new Resource()
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
index 5894c8c..e4b0bce 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
@@ -168,7 +168,7 @@ public final class HDInsightInstance {
return "ws/v1/cluster/apps/" + applicationId;
}
- private final String getHost() throws URISyntaxException {
+ private String getHost() throws URISyntaxException {
final URI uri = new URI(this.instanceUrl);
return uri.getHost();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
index a00c4a5..f80fb04 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
@@ -46,7 +46,7 @@ final class FileSet {
*
* @param file the file to be added.
*/
- final void add(final File file) {
+ void add(final File file) {
if (file.isFile()) {
if (this.fileNames.contains(file.getName())) {
LOG.log(Level.FINEST, "A file with this name has already been added: {0}", file.getName());
@@ -59,14 +59,14 @@ final class FileSet {
}
}
- final boolean containsFileWithName(final String name) {
+ boolean containsFileWithName(final String name) {
return this.fileNames.contains(name);
}
/**
* @return an iterable over the filenames, sans the folder. e.g. "/tmp/foo.txt" is returned as "foo.txt"
*/
- final Set<String> fileNames() {
+ Set<String> fileNames() {
return this.fileNames;
}
@@ -76,7 +76,7 @@ final class FileSet {
* @param destinationFolder the folder where the files shall be copied to.
* @throws IOException
*/
- final void copyTo(final File destinationFolder) throws IOException {
+ void copyTo(final File destinationFolder) throws IOException {
for (final File f : this.theFiles) {
final File destinationFile = new File(destinationFolder, f.getName());
Files.copy(f.toPath(), destinationFile.toPath(), java.nio.file.StandardCopyOption.REPLACE_EXISTING);
@@ -89,7 +89,7 @@ final class FileSet {
* @param destinationFolder the folder where the symbolic links will be created.
* @throws IOException
*/
- final void createSymbolicLinkTo(final File destinationFolder) throws IOException {
+ void createSymbolicLinkTo(final File destinationFolder) throws IOException {
for (final File f : this.theFiles) {
final File destinationFile = new File(destinationFolder, f.getName());
Files.createSymbolicLink(destinationFile.toPath(), f.toPath());
@@ -103,7 +103,7 @@ final class FileSet {
* @param field the field to add the files in this set to.
* @return the filled out ConfigurationModule
*/
- final ConfigurationModule addNamesTo(final ConfigurationModule input, final OptionalParameter<String> field) {
+ ConfigurationModule addNamesTo(final ConfigurationModule input, final OptionalParameter<String> field) {
ConfigurationModule result = input;
for (final String fileName : this.fileNames()) {
result = result.set(field, fileName);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
index 7e20d32..03ad267 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
@@ -77,12 +77,12 @@ final class LocalJobSubmissionHandler implements JobSubmissionHandler {
}
@Override
- public final void close() {
+ public void close() {
this.executor.shutdown();
}
@Override
- public final void onNext(final JobSubmissionEvent t) {
+ public void onNext(final JobSubmissionEvent t) {
try (final LoggingScope lf = loggingScopeFactory.localJobSubmission()) {
try {
LOG.log(Level.FINEST, "Starting local job {0}", t.getIdentifier());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
index ff1f9b8..5b77b26 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
@@ -36,50 +36,50 @@ interface Container extends AutoCloseable {
*
* @param commandLine the command line to execute. It will typically be joined by spaces to form the command line.
*/
- public void run(final List<String> commandLine);
+ void run(final List<String> commandLine);
/**
* Copies the files to the working directory of the container.
*
* @param files the files to be added to the container.
*/
- public void addLocalFiles(final Iterable<File> files);
+ void addLocalFiles(final Iterable<File> files);
- public void addGlobalFiles(final File globalFolder);
+ void addGlobalFiles(final File globalFolder);
/**
* @return true if the Container is currently executing, false otherwise.
*/
- public boolean isRunning();
+ boolean isRunning();
/**
* @return the ID of the node this Container is executing on.
*/
- public String getNodeID();
+ String getNodeID();
/**
* @return the ID of this Container.
*/
- public String getContainerID();
+ String getContainerID();
/**
* @return the main memory available to the Container.
*/
- public int getMemory();
+ int getMemory();
/**
* @return the core available to the Container.
*/
- public int getNumberOfCores();
+ int getNumberOfCores();
/**
* @return the working directory of the Container.
*/
- public File getFolder();
+ File getFolder();
/**
* Kills the Container.
*/
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
index 918e1d1..8a98087 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
@@ -141,11 +141,11 @@ final class ContainerManager implements AutoCloseable {
}
}
- final boolean hasContainerAvailable() {
+ boolean hasContainerAvailable() {
return this.freeNodeList.size() > 0;
}
- final Container allocateOne(final int megaBytes, final int numberOfCores) {
+ Container allocateOne(final int megaBytes, final int numberOfCores) {
synchronized (this.containers) {
final String nodeId = this.freeNodeList.remove(0);
final String processID = nodeId + "-" + String.valueOf(System.currentTimeMillis());
@@ -159,7 +159,7 @@ final class ContainerManager implements AutoCloseable {
}
}
- final void release(final String containerID) {
+ void release(final String containerID) {
synchronized (this.containers) {
final Container ctr = this.containers.get(containerID);
if (null != ctr) {
@@ -175,7 +175,7 @@ final class ContainerManager implements AutoCloseable {
}
}
- final Container get(final String containedID) {
+ Container get(final String containedID) {
synchronized (this.containers) {
return this.containers.get(containedID);
}
@@ -184,7 +184,7 @@ final class ContainerManager implements AutoCloseable {
/**
* @return a List of the IDs of currently allocated Containers.
*/
- final Iterable<String> getAllocatedContainerIDs() {
+ Iterable<String> getAllocatedContainerIDs() {
return this.containers.keySet();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
index cf415c4..bfaeeef 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
@@ -40,7 +40,7 @@ public final class IDMaker {
/**
* @return the next ID
*/
- public final String getNextID() {
+ public String getNextID() {
this.counter += 1;
return this.prefix + this.counter;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
index 8a428c3..da5d157 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
@@ -129,17 +129,17 @@ final class ProcessContainer implements Container {
}
@Override
- public final boolean isRunning() {
+ public boolean isRunning() {
return null != this.theThread && this.theThread.isAlive();
}
@Override
- public final int getMemory() {
+ public int getMemory() {
return this.megaBytes;
}
@Override
- public final int getNumberOfCores() {
+ public int getNumberOfCores() {
return this.numberOfCores;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
index b3979f7..8d9656b 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
@@ -124,7 +124,7 @@ public final class ResourceManager {
*
* @param resourceRequest the resource request to be handled.
*/
- final void onResourceRequest(final ResourceRequestEvent resourceRequest) {
+ void onResourceRequest(final ResourceRequestEvent resourceRequest) {
synchronized (this.theContainers) {
this.requestQueue.add(new ResourceRequest(resourceRequest));
this.checkRequestQueue();
@@ -136,7 +136,7 @@ public final class ResourceManager {
*
* @param releaseRequest the release request to be processed
*/
- final void onResourceReleaseRequest(final ResourceReleaseEvent releaseRequest) {
+ void onResourceReleaseRequest(final ResourceReleaseEvent releaseRequest) {
synchronized (this.theContainers) {
LOG.log(Level.FINEST, "Release container: {0}", releaseRequest.getIdentifier());
this.theContainers.release(releaseRequest.getIdentifier());
@@ -149,7 +149,7 @@ public final class ResourceManager {
*
* @param evaluatorId the ID of the Evaluator that exited.
*/
- public final void onEvaluatorExit(final String evaluatorId) {
+ public void onEvaluatorExit(final String evaluatorId) {
synchronized (this.theContainers) {
this.theContainers.release(evaluatorId);
this.checkRequestQueue();
@@ -161,7 +161,7 @@ public final class ResourceManager {
*
* @param launchRequest the launch request to be processed.
*/
- final void onResourceLaunchRequest(
+ void onResourceLaunchRequest(
final ResourceLaunchEvent launchRequest) {
synchronized (this.theContainers) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
index 6fd8f39..a55e2f3 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
@@ -42,7 +42,7 @@ final class ResourceRequest {
/**
* Records that one resource has been allocated to this Request.
*/
- final void satisfyOne() {
+ void satisfyOne() {
this.satisfied += 1;
if (this.satisfied > req.getResourceCount()) {
throw new IllegalStateException("This request has been oversatisfied.");
@@ -53,11 +53,11 @@ final class ResourceRequest {
* @return true if the request is satisfied with this additional unit of
* resource, false otherwise.
*/
- final boolean isSatisfied() {
+ boolean isSatisfied() {
return this.satisfied == req.getResourceCount();
}
- final ResourceRequestEvent getRequestProto() {
+ ResourceRequestEvent getRequestProto() {
return this.req;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
index 7ab7e09..898f3c7 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
@@ -39,14 +39,14 @@ final class ResourceRequestQueue {
*
* @param req the request to be added.
*/
- final void add(final ResourceRequest req) {
+ void add(final ResourceRequest req) {
this.requestQueue.add(req);
}
/**
* @return true if there are outstanding resource requests. false otherwise.
*/
- final boolean hasOutStandingRequests() {
+ boolean hasOutStandingRequests() {
return !this.requestQueue.isEmpty();
}
@@ -54,7 +54,7 @@ final class ResourceRequestQueue {
* Satisfies one resource for the front-most request. If that satisfies the
* request, it is removed from the queue.
*/
- final synchronized ResourceRequestEvent satisfyOne() {
+ synchronized ResourceRequestEvent satisfyOne() {
final ResourceRequest req = this.requestQueue.element();
req.satisfyOne();
if (req.isSatisfied()) {
@@ -63,7 +63,7 @@ final class ResourceRequestQueue {
return req.getRequestProto();
}
- final synchronized int getNumberOfOutstandingRequests() {
+ synchronized int getNumberOfOutstandingRequests() {
return this.requestQueue.size();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
index 4db6500..b8a366a 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
@@ -27,7 +27,7 @@ public interface RunnableProcessObserver {
*
* @param processId the id of the process that started.
*/
- public void onProcessStarted(final String processId);
+ void onProcessStarted(final String processId);
/**
* This will be called right after the process exited.
@@ -35,5 +35,5 @@ public interface RunnableProcessObserver {
* @param exitCode the return code of the process.
* @param processId the id of the process that exited.
*/
- public void onProcessExit(final String processId, final int exitCode);
+ void onProcessExit(final String processId, final int exitCode);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
index eb5f340..81d52fe 100644
--- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
+++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
@@ -82,7 +82,7 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void registered(final ExecutorDriver driver,
+ public void registered(final ExecutorDriver driver,
final ExecutorInfo executorInfo,
final FrameworkInfo frameworkInfo,
final SlaveInfo slaveInfo) {
@@ -91,12 +91,12 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void reregistered(final ExecutorDriver driver, final SlaveInfo slaveInfo) {
+ public void reregistered(final ExecutorDriver driver, final SlaveInfo slaveInfo) {
LOG.log(Level.FINEST, "Executor reregistered. driver: {0}", driver);
}
@Override
- public final void disconnected(final ExecutorDriver driver) {
+ public void disconnected(final ExecutorDriver driver) {
this.onRuntimeError();
}
@@ -104,7 +104,7 @@ public final class REEFExecutor implements Executor {
* We assume a long-running Mesos Task that manages a REEF Evaluator process, leveraging Mesos Executor's interface.
*/
@Override
- public final void launchTask(final ExecutorDriver driver, final TaskInfo task) {
+ public void launchTask(final ExecutorDriver driver, final TaskInfo task) {
driver.sendStatusUpdate(TaskStatus.newBuilder()
.setTaskId(TaskID.newBuilder().setValue(this.mesosExecutorId).build())
.setState(TaskState.TASK_STARTING)
@@ -114,23 +114,23 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void killTask(final ExecutorDriver driver, final TaskID taskId) {
+ public void killTask(final ExecutorDriver driver, final TaskID taskId) {
this.onStop();
}
@Override
- public final void frameworkMessage(final ExecutorDriver driver, final byte[] data) {
+ public void frameworkMessage(final ExecutorDriver driver, final byte[] data) {
LOG.log(Level.FINEST, "Framework Messge. ExecutorDriver: {0}, data: {1}.",
new Object[]{driver, data});
}
@Override
- public final void shutdown(final ExecutorDriver driver) {
+ public void shutdown(final ExecutorDriver driver) {
this.onStop();
}
@Override
- public final void error(final ExecutorDriver driver, final String message) {
+ public void error(final ExecutorDriver driver, final String message) {
this.onRuntimeError();
}
@@ -190,13 +190,13 @@ public final class REEFExecutor implements Executor {
this.mesosExecutorDriver.stop();
}
- public final void onEvaluatorRelease(final EvaluatorRelease evaluatorRelease) {
+ public void onEvaluatorRelease(final EvaluatorRelease evaluatorRelease) {
LOG.log(Level.INFO, "Release!!!! {0}", evaluatorRelease.toString());
assert(evaluatorRelease.getIdentifier().toString().equals(this.mesosExecutorId));
this.onStop();
}
- public final void onEvaluatorLaunch(final EvaluatorLaunch evaluatorLaunch) {
+ public void onEvaluatorLaunch(final EvaluatorLaunch evaluatorLaunch) {
LOG.log(Level.INFO, "Launch!!!! {0}", evaluatorLaunch.toString());
assert(evaluatorLaunch.getIdentifier().toString().equals(this.mesosExecutorId));
final ExecutorService evaluatorLaunchExecutorService = Executors.newSingleThreadExecutor();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
index a5e02ff..d340448 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
@@ -143,8 +143,8 @@ final class YarnJobSubmissionHandler implements JobSubmissionHandler {
* <p/>
* TODO: Revisit this. We also have a named parameter for the queue in YarnClientConfiguration.
*/
- private final String getQueue(final JobSubmissionEvent jobSubmissionEvent,
- final String defaultQueue) {
+ private String getQueue(final JobSubmissionEvent jobSubmissionEvent,
+ final String defaultQueue) {
return jobSubmissionEvent.getQueue().orElse(defaultQueue);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
index ba8f369..068abd6 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
@@ -25,5 +25,5 @@ import org.apache.reef.tang.annotations.DefaultImplementation;
*/
@DefaultImplementation(DefaultTrackingURLProvider.class)
public interface TrackingURLProvider {
- public String getTrackingUrl();
+ String getTrackingUrl();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
index 1efbbf6..5aeddea 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
@@ -114,14 +114,14 @@ final class YarnContainerManager
}
@Override
- public final void onContainersCompleted(final List<ContainerStatus> containerStatuses) {
+ public void onContainersCompleted(final List<ContainerStatus> containerStatuses) {
for (final ContainerStatus containerStatus : containerStatuses) {
onContainerStatus(containerStatus);
}
}
@Override
- public final void onContainersAllocated(final List<Container> containers) {
+ public void onContainersAllocated(final List<Container> containers) {
// ID is used for logging only
final String id = String.format("%s:%d",
@@ -153,17 +153,17 @@ final class YarnContainerManager
}
@Override
- public final float getProgress() {
+ public float getProgress() {
return 0; // TODO: return actual values for progress
}
@Override
- public final void onError(final Throwable throwable) {
+ public void onError(final Throwable throwable) {
onRuntimeError(throwable);
}
@Override
- public final void onContainerStarted(
+ public void onContainerStarted(
final ContainerId containerId, final Map<String, ByteBuffer> stringByteBufferMap) {
final Optional<Container> container = this.containers.getOptional(containerId.toString());
if (container.isPresent()) {
@@ -172,13 +172,13 @@ final class YarnContainerManager
}
@Override
- public final void onContainerStatusReceived(
+ public void onContainerStatusReceived(
final ContainerId containerId, final ContainerStatus containerStatus) {
onContainerStatus(containerStatus);
}
@Override
- public final void onContainerStopped(final ContainerId containerId) {
+ public void onContainerStopped(final ContainerId containerId) {
final boolean hasContainer = this.containers.hasContainer(containerId.toString());
if (hasContainer) {
final ResourceStatusEventImpl.Builder resourceStatusBuilder =
@@ -189,19 +189,19 @@ final class YarnContainerManager
}
@Override
- public final void onStartContainerError(
+ public void onStartContainerError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
@Override
- public final void onGetContainerStatusError(
+ public void onGetContainerStatusError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
@Override
- public final void onStopContainerError(
+ public void onStopContainerError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
index 8c96ece..536d7b5 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
@@ -39,7 +39,7 @@ public final class YarnTypes {
/**
* @return a ContainerLaunchContext with the given commands and LocalResources.
*/
- public static final ContainerLaunchContext getContainerLaunchContext(
+ public static ContainerLaunchContext getContainerLaunchContext(
final List<String> commands, final Map<String, LocalResource> localResources) {
final ContainerLaunchContext context = Records.newRecord(ContainerLaunchContext.class);
context.setLocalResources(localResources);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
index 1e65982..3ae638b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
@@ -34,5 +34,5 @@ public interface BindLocation {
* trace, configuration file location, or other source of some
* configuration data.
*/
- public abstract String toString();
+ String toString();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
index 8a95e1e..4833717 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
@@ -44,12 +44,12 @@ public interface ClassHierarchy {
* @throws NameResolutionException If the class is not found.
* @throws ClassHierarchyException If the class does not pass Tang's static analysis.
*/
- public Node getNode(String fullName) throws NameResolutionException;
+ Node getNode(String fullName) throws NameResolutionException;
/**
* @return true if impl is a subclass of inter.
*/
- public boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl);
+ boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl);
/**
* Merge the contents of this ClassHierarchy and the provided one into a new
@@ -64,7 +64,7 @@ public interface ClassHierarchy {
* ClassHierarchies derived from applications written in different languages
* cannot be merged.
*/
- public ClassHierarchy merge(ClassHierarchy ch);
+ ClassHierarchy merge(ClassHierarchy ch);
/**
* Return a reference to the root of the ClassHierarchy. This is needed by
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
index 69229e9..ded80fa 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
@@ -69,7 +69,7 @@ public interface Configuration {
* This API is unstable and should be considered private. Use the methods
* in org.apache.reef.Tang instead.
*/
- public ConfigurationBuilder newBuilder();
+ ConfigurationBuilder newBuilder();
/**
* Return the value of the given named parameter as an unparsed string.
@@ -81,7 +81,7 @@ public interface Configuration {
* @return The validated string that this parameter is bound to, or null.
* @see getClassHierarchy()
*/
- public String getNamedParameter(NamedParameterNode<?> np);
+ String getNamedParameter(NamedParameterNode<?> np);
/**
* Obtain the set of class hierarchy nodes or strings that were bound to a given NamedParameterNode.
@@ -91,7 +91,7 @@ public interface Configuration {
* @return A set of ClassHierarchy Node objects or a set of strings, depending on whether the NamedParameterNode refers to an interface or configuration options, respectively.
* @see getClassHierarchy()
*/
- public Set<Object> getBoundSet(NamedParameterNode<Set<?>> np);
+ Set<Object> getBoundSet(NamedParameterNode<Set<?>> np);
/**
* Get the list bound to a given NamedParameterNode. The list will be empty if nothing was bound.
@@ -99,17 +99,17 @@ public interface Configuration {
* @param np Target NamedParameter
* @return A list bound to np
*/
- public List<Object> getBoundList(NamedParameterNode<List<?>> np);
+ List<Object> getBoundList(NamedParameterNode<List<?>> np);
/**
* @return the external constructor that cn has been explicitly bound to, or null. Defaults are not returned.
*/
- public <T> ClassNode<ExternalConstructor<T>> getBoundConstructor(ClassNode<T> cn);
+ <T> ClassNode<ExternalConstructor<T>> getBoundConstructor(ClassNode<T> cn);
/**
* @return the implementation that cn has been explicitly bound to, or null. Defaults are not returned.
*/
- public <T> ClassNode<T> getBoundImplementation(ClassNode<T> cn);
+ <T> ClassNode<T> getBoundImplementation(ClassNode<T> cn);
/**
* Return the LegacyConstructor that has been bound to this Class. Such constructors are defined in the class, but missing their @Inject annotation.
@@ -118,7 +118,7 @@ public interface Configuration {
* <p/>
* TODO: Should this return Set<ConstructorDef<T>> instead?
*/
- public <T> ConstructorDef<T> getLegacyConstructor(ClassNode<T> cn);
+ <T> ConstructorDef<T> getLegacyConstructor(ClassNode<T> cn);
/**
* @return the set of all interfaces (or super-classes) that have been explicitly
@@ -146,7 +146,7 @@ public interface Configuration {
*
* @return the ClassHierarchy that backs this Configuration.
*/
- public ClassHierarchy getClassHierarchy();
+ ClassHierarchy getClassHierarchy();
/**
* Get the set bindings from set-valued NamedParameters to the values they were bound to.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
index 3c43fb0..f56ee0e 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
@@ -73,7 +73,7 @@ public interface ConfigurationBuilder {
*
* @param c
*/
- public void addConfiguration(final Configuration c) throws BindException;
+ void addConfiguration(final Configuration c) throws BindException;
/**
* Each ConfigurationBuilder instance is associated with a ClassHierarchy.
@@ -84,7 +84,7 @@ public interface ConfigurationBuilder {
* ConfigurationBuilder. No copy is made, since ClassHierarchy objects
* are effectively immutable.
*/
- public ClassHierarchy getClassHierarchy();
+ ClassHierarchy getClassHierarchy();
/**
* Force Tang to treat the specified constructor as though it had an @Inject
@@ -142,7 +142,7 @@ public interface ConfigurationBuilder {
* and values) if iface is not a NamedParameter, or if impl
* fails to parse as the type the iface expects.
*/
- public <T> void bind(String iface, String impl)
+ <T> void bind(String iface, String impl)
throws BindException;
/**
@@ -189,21 +189,21 @@ public interface ConfigurationBuilder {
* @param impl The ExternalConstructor class that will be used to instantiate iface.
* @throws BindException If impl does not instantiate a subclass of iface.
*/
- public <T> void bindConstructor(ClassNode<T> iface,
- ClassNode<? extends ExternalConstructor<? extends T>> impl)
+ <T> void bindConstructor(ClassNode<T> iface,
+ ClassNode<? extends ExternalConstructor<? extends T>> impl)
throws BindException;
/**
* Pretty print the default implementation / value of the provided class / NamedParamter.
* This is used by Tang to produce human readable error messages.
*/
- public String classPrettyDefaultString(String longName) throws BindException;
+ String classPrettyDefaultString(String longName) throws BindException;
/**
* Pretty print the human readable documentation of the provided class / NamedParamter.
* This is used by Tang to produce human readable error messages.
*/
- public String classPrettyDescriptionString(String longName)
+ String classPrettyDescriptionString(String longName)
throws BindException;
/**
@@ -218,17 +218,17 @@ public interface ConfigurationBuilder {
*
* @return
*/
- public Configuration build();
+ Configuration build();
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, Node impl)
+ <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, Node impl)
throws BindException;
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, String impl)
+ <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, String impl)
throws BindException;
- public void bindSetEntry(String iface, String impl) throws BindException;
+ void bindSetEntry(String iface, String impl) throws BindException;
- public void bindSetEntry(String iface, Node impl) throws BindException;
+ void bindSetEntry(String iface, Node impl) throws BindException;
/**
* Bind an list of implementations(Class or String) to an given NamedParameter.
@@ -244,8 +244,8 @@ public interface ConfigurationBuilder {
* @param implList The list of class or value will be used to instantiated the named parameter
* @throws BindException
*/
- public <T> void bindList(NamedParameterNode<List<T>> iface, List implList) throws BindException;
+ <T> void bindList(NamedParameterNode<List<T>> iface, List implList) throws BindException;
- public void bindList(String iface, List implList) throws BindException;
+ void bindList(String iface, List implList) throws BindException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
index 08afd63..92c5220 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
@@ -36,5 +36,5 @@ public interface ExternalConstructor<T> {
*
* @return a new, distinct instance of T.
*/
- public T newInstance();
+ T newInstance();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
index c6ddde7..f576791 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
@@ -91,17 +91,17 @@ public final class InjectionFuture<T> implements Future<T> {
}
@Override
- public final boolean cancel(boolean mayInterruptIfRunning) {
+ public boolean cancel(boolean mayInterruptIfRunning) {
return false;
}
@Override
- public final boolean isCancelled() {
+ public boolean isCancelled() {
return false;
}
@Override
- public final boolean isDone() {
+ public boolean isDone() {
return true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
index cb708fd..fb472a4 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
@@ -37,9 +37,9 @@ public interface Injector {
* @throws NameResolutionException
* @throws ReflectiveOperationException
*/
- public <U> U getInstance(Class<U> iface) throws InjectionException;
+ <U> U getInstance(Class<U> iface) throws InjectionException;
- public <U> U getInstance(String iface) throws InjectionException,
+ <U> U getInstance(String iface) throws InjectionException,
NameResolutionException;
/**
@@ -51,7 +51,7 @@ public interface Injector {
* given interface class.
* @throws InjectionException
*/
- public <U> U getNamedInstance(Class<? extends Name<U>> iface)
+ <U> U getNamedInstance(Class<? extends Name<U>> iface)
throws InjectionException;
/**
@@ -65,10 +65,10 @@ public interface Injector {
* @return A copy of this injector that reflects the new binding.
* @throws BindException
*/
- public <T> void bindVolatileInstance(Class<T> iface, T inst)
+ <T> void bindVolatileInstance(Class<T> iface, T inst)
throws BindException;
- public <T> void bindVolatileParameter(Class<? extends Name<T>> iface, T inst)
+ <T> void bindVolatileParameter(Class<? extends Name<T>> iface, T inst)
throws BindException;
/**
@@ -81,7 +81,7 @@ public interface Injector {
* @param a
* @throws BindException
*/
- public <T> void bindAspect(Aspect a) throws BindException;
+ <T> void bindAspect(Aspect a) throws BindException;
/**
* Allows InjectionFuture to tell the aspect when get() is invoked. Package private.
@@ -107,7 +107,7 @@ public interface Injector {
* @throws BindException If any of the configurations conflict with each other, or the
* existing Injector's Configuration.
*/
- public Injector forkInjector(Configuration... configurations) throws BindException;
+ Injector forkInjector(Configuration... configurations) throws BindException;
/**
* Returns true if this Injector is able to instantiate the object named by
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
index 2456046..7523127 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
@@ -38,9 +38,9 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* @param c The class to be looked up in the class hierarchy.
* @return The associated NamedParameterNode or ClassNode.
*/
- public Node getNode(Class<?> c);
+ Node getNode(Class<?> c);
- public Class<?> classForName(String name) throws ClassNotFoundException;
+ Class<?> classForName(String name) throws ClassNotFoundException;
/**
* Parse a string value that has been passed into a named parameter.
@@ -52,7 +52,7 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* wrong type (such as when it specifies a class that does not implement
* or extend T).
*/
- public <T> T parse(NamedParameterNode<T> name, String value) throws ParseException;
+ <T> T parse(NamedParameterNode<T> name, String value) throws ParseException;
/**
* Obtain a parsed instance of the default value of a named parameter.
@@ -62,6 +62,6 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* then this method returns a (potentially empty) set of default instances.
* @throws ClassHierarchyException if an instance failed to parse.
*/
- public <T> T parseDefaultValue(NamedParameterNode<T> name) throws ClassHierarchyException;
+ <T> T parseDefaultValue(NamedParameterNode<T> name) throws ClassHierarchyException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
index 75b10b1..cf9d8a4 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
@@ -47,7 +47,7 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @param iface
* @param impl
*/
- public <T> JavaConfigurationBuilder bind(Class<T> iface, Class<?> impl) throws BindException;
+ <T> JavaConfigurationBuilder bind(Class<T> iface, Class<?> impl) throws BindException;
/**
* Binds the Class impl as the implementation of the interface iface.
@@ -56,7 +56,7 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @param iface
* @param impl
*/
- public <T> JavaConfigurationBuilder bindImplementation(Class<T> iface, Class<? extends T> impl)
+ <T> JavaConfigurationBuilder bindImplementation(Class<T> iface, Class<? extends T> impl)
throws BindException;
@@ -68,18 +68,18 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* how to parse the parameter's type.
* @throws org.apache.reef.tang.exceptions.NameResolutionException
*/
- public JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<?>> name, String value)
+ JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<?>> name, String value)
throws BindException;
- public <T> JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<T>> iface,
- Class<? extends T> impl) throws BindException;
+ <T> JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<T>> iface,
+ Class<? extends T> impl) throws BindException;
- public <T> JavaConfigurationBuilder bindConstructor(Class<T> c,
- Class<? extends ExternalConstructor<? extends T>> v) throws BindException;
+ <T> JavaConfigurationBuilder bindConstructor(Class<T> c,
+ Class<? extends ExternalConstructor<? extends T>> v) throws BindException;
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String value) throws BindException;
+ <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String value) throws BindException;
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, Class<? extends T> impl) throws BindException;
+ <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, Class<? extends T> impl) throws BindException;
/**
* Binds a specfic list to a named parameter. List's elements can be string values or class implementations.
@@ -92,6 +92,6 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @return
* @throws BindException
*/
- public <T> JavaConfigurationBuilder bindList(Class<? extends Name<List<T>>> iface, List impl)
+ <T> JavaConfigurationBuilder bindList(Class<? extends Name<List<T>>> iface, List impl)
throws BindException;
}
[3/3] incubator-reef git commit: [REEF-388]: Fix violations of
RedundantModifier checkstyle
Posted by we...@apache.org.
[REEF-388]: Fix violations of RedundantModifier checkstyle
This addressed the issue by
* removing redundant modifiers as detected by the check
JIRA:
[REEF-388](https://issues.apache.org/jira/browse/REEF-388)
Pull Request:
This closes #229
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/660ee805
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/660ee805
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/660ee805
Branch: refs/heads/master
Commit: 660ee805dae12dcc88fac82851243e2c8d81da52
Parents: 9964d5d
Author: Mariia Mykhailova <mi...@gmail.com>
Authored: Wed Jun 17 17:20:39 2015 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Thu Jun 18 13:21:53 2015 -0700
----------------------------------------------------------------------
.../reef/javabridge/HttpServerEventBridge.java | 20 ++++++------
.../reef/javabridge/RunningTaskBridge.java | 4 +--
.../reef/javabridge/generic/JobDriver.java | 2 +-
.../io/checkpoint/CheckpointNamingService.java | 2 +-
.../org/apache/reef/client/CompletedJob.java | 2 +-
.../java/org/apache/reef/client/JobMessage.java | 4 +--
.../org/apache/reef/client/LauncherStatus.java | 10 +++---
.../main/java/org/apache/reef/client/REEF.java | 4 +--
.../java/org/apache/reef/client/RunningJob.java | 8 ++---
.../reef/driver/ContextAndTaskSubmittable.java | 10 +++---
.../apache/reef/driver/ContextSubmittable.java | 4 +--
.../reef/driver/FlexiblePreemptionEvent.java | 2 +-
.../org/apache/reef/driver/TaskSubmittable.java | 2 +-
.../reef/driver/catalog/NodeDescriptor.java | 4 +--
.../reef/driver/catalog/RackDescriptor.java | 2 +-
.../reef/driver/catalog/ResourceCatalog.java | 8 ++---
.../reef/driver/client/JobMessageObserver.java | 2 +-
.../reef/driver/context/ActiveContext.java | 10 +++---
.../reef/driver/context/ClosedContext.java | 2 +-
.../reef/driver/context/ContextMessage.java | 6 ++--
.../reef/driver/evaluator/EvaluatorRequest.java | 2 +-
.../driver/evaluator/EvaluatorRequestor.java | 2 +-
.../reef/driver/evaluator/FailedEvaluator.java | 6 ++--
.../apache/reef/driver/task/CompletedTask.java | 4 +--
.../apache/reef/driver/task/RunningTask.java | 12 ++++----
.../apache/reef/driver/task/SuspendedTask.java | 2 +-
.../context/ContextMessageHandler.java | 2 +-
.../evaluator/context/ContextMessageSource.java | 2 +-
.../evaluator/context/events/ContextStart.java | 2 +-
.../evaluator/context/events/ContextStop.java | 2 +-
.../java/org/apache/reef/io/Accumulable.java | 2 +-
.../java/org/apache/reef/io/ExternalMap.java | 12 ++++----
.../main/java/org/apache/reef/io/Message.java | 2 +-
.../src/main/java/org/apache/reef/io/Spool.java | 4 +--
.../org/apache/reef/io/TempFileCreator.java | 6 ++--
.../org/apache/reef/io/naming/Identifiable.java | 2 +-
.../apache/reef/io/naming/NameAssignment.java | 4 +--
.../org/apache/reef/io/naming/NamingLookup.java | 2 +-
.../apache/reef/io/naming/NamingRegistry.java | 4 +--
.../org/apache/reef/io/serialization/Codec.java | 4 +--
.../reef/io/serialization/Deserializer.java | 2 +-
.../reef/io/serialization/Serializer.java | 2 +-
.../common/client/JobSubmissionHelper.java | 2 +-
.../common/client/REEFImplementation.java | 2 +-
.../reef/runtime/common/client/RunningJobs.java | 6 ++--
.../common/client/api/JobSubmissionHandler.java | 2 +-
.../driver/catalog/RackDescriptorImpl.java | 6 ++--
.../driver/catalog/ResourceCatalogImpl.java | 4 +--
.../common/driver/context/ContextFactory.java | 2 +-
.../driver/context/ContextMessageImpl.java | 2 +-
.../common/driver/context/EvaluatorContext.java | 2 +-
.../evaluator/AllocatedEvaluatorImpl.java | 6 ++--
.../EvaluatorHeartBeatSanityChecker.java | 2 +-
.../evaluator/EvaluatorManagerFactory.java | 6 ++--
.../common/driver/task/TaskMessageImpl.java | 2 +-
.../common/evaluator/EvaluatorRuntime.java | 8 ++---
.../common/evaluator/HeartBeatManager.java | 2 +-
.../evaluator/context/ContextLifeCycle.java | 10 +++---
.../evaluator/context/ContextRuntime.java | 4 +--
.../evaluator/context/RootContextLauncher.java | 4 +--
.../common/evaluator/task/TaskRuntime.java | 2 +-
.../common/evaluator/task/TaskStatus.java | 4 +--
.../common/launch/LaunchCommandBuilder.java | 14 ++++-----
.../launch/REEFUncaughtExceptionHandler.java | 2 +-
.../runtime/common/utils/ExceptionCodec.java | 6 ++--
.../main/java/org/apache/reef/task/Task.java | 2 +-
.../org/apache/reef/task/TaskMessageSource.java | 2 +-
.../org/apache/reef/task/events/CloseEvent.java | 2 +-
.../apache/reef/task/events/DriverMessage.java | 2 +-
.../apache/reef/task/events/SuspendEvent.java | 2 +-
.../org/apache/reef/task/events/TaskStop.java | 2 +-
.../main/java/org/apache/reef/util/Builder.java | 2 +-
.../java/org/apache/reef/util/CommandUtils.java | 2 +-
.../apache/reef/util/logging/LoggingScope.java | 2 +-
.../reef/examples/helloCLR/HelloDriver.java | 6 ++--
.../reef/examples/group/bgd/BGDClient.java | 2 +-
.../examples/group/bgd/data/parser/Parser.java | 2 +-
.../reef/examples/group/utils/math/Vector.java | 12 ++++----
.../apache/reef/examples/hello/HelloTask.java | 2 +-
.../reef/examples/scheduler/SchedulerREEF.java | 6 ++--
.../examples/scheduler/SchedulerREEFYarn.java | 2 +-
.../reef/examples/suspend/SuspendDriver.java | 6 ++--
.../utils/wake/BlockingEventHandler.java | 2 +-
.../reef/io/network/ConnectionFactory.java | 2 +-
.../api/driver/CommunicationGroupDriver.java | 10 +++---
.../group/api/driver/TaskNodeStatus.java | 2 +-
.../network/group/api/operators/Broadcast.java | 4 +--
.../io/network/group/api/operators/Gather.java | 4 +--
.../io/network/group/api/operators/Reduce.java | 6 ++--
.../io/network/group/api/operators/Scatter.java | 4 +--
.../reef/io/network/naming/NameServer.java | 10 +++---
.../network/naming/serialization/AvroUtils.java | 2 +-
.../reef/runtime/hdinsight/cli/HDICLI.java | 2 +-
.../runtime/hdinsight/cli/LogFileEntry.java | 2 +-
.../client/HDInsightJobSubmissionHandler.java | 2 +-
.../client/yarnrest/HDInsightInstance.java | 2 +-
.../reef/runtime/local/client/FileSet.java | 12 ++++----
.../local/client/LocalJobSubmissionHandler.java | 4 +--
.../reef/runtime/local/driver/Container.java | 20 ++++++------
.../runtime/local/driver/ContainerManager.java | 10 +++---
.../reef/runtime/local/driver/IDMaker.java | 2 +-
.../runtime/local/driver/ProcessContainer.java | 6 ++--
.../runtime/local/driver/ResourceManager.java | 8 ++---
.../runtime/local/driver/ResourceRequest.java | 6 ++--
.../local/driver/ResourceRequestQueue.java | 8 ++---
.../local/process/RunnableProcessObserver.java | 4 +--
.../runtime/mesos/evaluator/REEFExecutor.java | 20 ++++++------
.../yarn/client/YarnJobSubmissionHandler.java | 4 +--
.../yarn/driver/TrackingURLProvider.java | 2 +-
.../yarn/driver/YarnContainerManager.java | 20 ++++++------
.../reef/runtime/yarn/util/YarnTypes.java | 2 +-
.../java/org/apache/reef/tang/BindLocation.java | 2 +-
.../org/apache/reef/tang/ClassHierarchy.java | 6 ++--
.../org/apache/reef/tang/Configuration.java | 16 +++++-----
.../apache/reef/tang/ConfigurationBuilder.java | 28 ++++++++---------
.../apache/reef/tang/ExternalConstructor.java | 2 +-
.../org/apache/reef/tang/InjectionFuture.java | 6 ++--
.../java/org/apache/reef/tang/Injector.java | 14 ++++-----
.../apache/reef/tang/JavaClassHierarchy.java | 8 ++---
.../reef/tang/JavaConfigurationBuilder.java | 20 ++++++------
.../main/java/org/apache/reef/tang/Tang.java | 24 +++++++--------
.../apache/reef/tang/examples/timer/Timer.java | 2 +-
.../apache/reef/tang/formats/CommandLine.java | 3 +-
.../reef/tang/formats/ConfigurationModule.java | 2 +-
.../formats/ConfigurationModuleBuilder.java | 2 +-
.../tang/formats/ConfigurationSerializer.java | 24 +++++++--------
.../org/apache/reef/tang/types/ClassNode.java | 20 ++++++------
.../apache/reef/tang/types/ConstructorArg.java | 8 ++---
.../apache/reef/tang/types/ConstructorDef.java | 8 ++---
.../reef/tang/types/NamedParameterNode.java | 14 ++++-----
.../java/org/apache/reef/tang/util/Tint.java | 2 +-
.../apache/reef/util/logging/DFSHandler.java | 2 +-
.../java/org/apache/reef/util/cache/Cache.java | 4 +--
.../java/org/apache/reef/wake/EventHandler.java | 2 +-
.../java/org/apache/reef/wake/Identifiable.java | 2 +-
.../java/org/apache/reef/wake/Identifier.java | 6 ++--
.../org/apache/reef/wake/IdentifierFactory.java | 2 +-
.../reef/wake/examples/p2p/EventSource.java | 2 +-
.../reef/wake/examples/p2p/Pull2Push.java | 2 +-
.../reef/wake/impl/BlockingEventHandler.java | 2 +-
.../wake/impl/BlockingSignalEventHandler.java | 2 +-
.../org/apache/reef/wake/metrics/Histogram.java | 8 ++---
.../org/apache/reef/wake/remote/Decoder.java | 2 +-
.../wake/remote/RemoteIdentifierFactory.java | 2 +-
.../apache/reef/wake/remote/RemoteManager.java | 10 +++---
.../apache/reef/wake/remote/RemoteMessage.java | 4 +--
.../wake/remote/transport/LinkListener.java | 4 +--
.../reef/wake/remote/transport/Transport.java | 10 +++---
.../wake/remote/transport/TransportFactory.java | 32 ++++++++++----------
.../java/org/apache/reef/wake/rx/Observer.java | 6 ++--
.../java/org/apache/reef/wake/time/Clock.java | 8 ++---
.../reef/wake/time/runtime/RuntimeClock.java | 18 +++++------
.../reef/webserver/DriverInfoSerializer.java | 4 +--
.../reef/webserver/EvaluatorListSerializer.java | 4 +--
.../org/apache/reef/webserver/HttpHandler.java | 4 +--
.../org/apache/reef/webserver/HttpServer.java | 8 ++---
.../reef/webserver/HttpTrackingURLProvider.java | 2 +-
157 files changed, 446 insertions(+), 445 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java
index 045984b..707ebe5 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java
@@ -33,43 +33,43 @@ public final class HttpServerEventBridge extends NativeBridge {
this.queryRequestData = queryRequestData;
}
- public final String getQueryString() {
+ public String getQueryString() {
return queryString;
}
- public final void setQueryString(final String queryStr) {
+ public void setQueryString(final String queryStr) {
this.queryString = queryStr;
}
- public final String getQueryResult() {
+ public String getQueryResult() {
return queryResult;
}
- public final void setQueryResult(final String queryResult) {
+ public void setQueryResult(final String queryResult) {
this.queryResult = queryResult;
}
- public final String getUriSpecification() {
+ public String getUriSpecification() {
return uriSpecification;
}
- public final void setUriSpecification(final String uriSpecification) {
+ public void setUriSpecification(final String uriSpecification) {
this.uriSpecification = uriSpecification;
}
- public final byte[] getQueryRequestData() {
+ public byte[] getQueryRequestData() {
return queryRequestData;
}
- public final void setQueryRequestData(final byte[] queryRequestData) {
+ public void setQueryRequestData(final byte[] queryRequestData) {
this.queryRequestData = queryRequestData;
}
- public final byte[] getQueryResponseData() {
+ public byte[] getQueryResponseData() {
return queryResponseData;
}
- public final void setQueryResponseData(final byte[] responseData) {
+ public void setQueryResponseData(final byte[] responseData) {
queryResponseData = responseData;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java
index 25b2a78..bff9b08 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java
@@ -33,11 +33,11 @@ public final class RunningTaskBridge extends NativeBridge {
this.jactiveContext = factory.getActiveContextBridge(runningTask.getActiveContext());
}
- public final String getId() {
+ public String getId() {
return jrunningTask.getId();
}
- public final void send(final byte[] message) {
+ public void send(final byte[] message) {
jrunningTask.send(message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
index 4bcc629..315c195 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
@@ -628,7 +628,7 @@ public final class JobDriver {
*/
public final class SuspendedTaskHandler implements EventHandler<SuspendedTask> {
@Override
- public final void onNext(final SuspendedTask task) {
+ public void onNext(final SuspendedTask task) {
final String message = "Received notification that task [" + task.getId() + "] has been suspended.";
LOG.log(Level.INFO, message);
try (final LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java
index 4ce5819..369a8dc 100644
--- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java
+++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java
@@ -28,6 +28,6 @@ public interface CheckpointNamingService {
*
* @return the checkpoint name
*/
- public String getNewName();
+ String getNewName();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java
index 46af11d..ae13f9b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java
@@ -35,5 +35,5 @@ public interface CompletedJob extends Identifiable {
* @return the ID of the completed job.
*/
@Override
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java
index 04f69f6..d31f7d0 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java
@@ -50,7 +50,7 @@ public final class JobMessage implements Message, Identifiable {
* @return the message sent by the Job.
*/
@Override
- public final byte[] get() {
+ public byte[] get() {
return this.value;
}
@@ -60,7 +60,7 @@ public final class JobMessage implements Message, Identifiable {
* @return the Identifier of the sending Job.
*/
@Override
- public final String getId() {
+ public String getId() {
return this.id;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java
index 378055b..d983579 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java
@@ -43,11 +43,11 @@ public final class LauncherStatus {
this.error = Optional.ofNullable(ex);
}
- public static final LauncherStatus FAILED(final Throwable ex) {
+ public static LauncherStatus FAILED(final Throwable ex) {
return new LauncherStatus(State.FAILED, ex);
}
- public static final LauncherStatus FAILED(final Optional<Throwable> ex) {
+ public static LauncherStatus FAILED(final Optional<Throwable> ex) {
return new LauncherStatus(State.FAILED, ex.orElse(null));
}
@@ -72,7 +72,7 @@ public final class LauncherStatus {
*
* @return True if the job has been completed, false otherwise.
*/
- public final boolean isDone() {
+ public boolean isDone() {
switch (this.state) {
case FAILED:
case COMPLETED:
@@ -88,7 +88,7 @@ public final class LauncherStatus {
*
* @return True if the job has been completed successfully, false otherwise.
*/
- public final boolean isSuccess() {
+ public boolean isSuccess() {
return this.state == State.COMPLETED;
}
@@ -97,7 +97,7 @@ public final class LauncherStatus {
*
* @return True if the job is still running, false otherwise.
*/
- public final boolean isRunning() {
+ public boolean isRunning() {
return this.state == State.RUNNING;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
index 9e5b03e..c1e891c 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
@@ -41,7 +41,7 @@ public interface REEF extends AutoCloseable {
* Close the resourcemanager connection.
*/
@Override
- public void close();
+ void close();
/**
* Submits the Driver set up in the given Configuration for execution.
@@ -51,5 +51,5 @@ public interface REEF extends AutoCloseable {
*
* @param driverConf The driver configuration: including everything it needs to execute. @see DriverConfiguration
*/
- public void submit(final Configuration driverConf);
+ void submit(final Configuration driverConf);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
index 8de6423..a3fe5ba 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
@@ -38,25 +38,25 @@ public interface RunningJob extends Identifiable, AutoCloseable {
* Cancels the running Job.
*/
@Override
- public void close();
+ void close();
/**
* Cancels the running Job.
*
* @param message delivered along with cancel request.
*/
- public void close(final byte[] message);
+ void close(final byte[] message);
/**
* @return the ID of the running job.
*/
@Override
- public String getId();
+ String getId();
/**
* Send a message to the Driver.
*
* @param message to send to the running driver
*/
- public void send(final byte[] message);
+ void send(final byte[] message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
index 92f0420..d5d816a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
@@ -42,10 +42,10 @@ public interface ContextAndTaskSubmittable {
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
* @param taskConfiguration the Configuration of the Task. See TaskConfiguration for details.
*/
- public void submitContextAndTask(final Configuration contextConfiguration, final Configuration taskConfiguration);
+ void submitContextAndTask(final Configuration contextConfiguration, final Configuration taskConfiguration);
/**
- * Subkit a Context with Services and a Task.
+ * Submit a Context with Services and a Task.
* <p/>
* The semantics of this call are the same as first submitting the context and services and then, on the fired
* ActiveContext event to submit the Task. The performance of this will be better, though as it potentially saves
@@ -57,8 +57,8 @@ public interface ContextAndTaskSubmittable {
* @param serviceConfiguration
* @param taskConfiguration
*/
- public void submitContextAndServiceAndTask(final Configuration contextConfiguration,
- final Configuration serviceConfiguration,
- final Configuration taskConfiguration);
+ void submitContextAndServiceAndTask(final Configuration contextConfiguration,
+ final Configuration serviceConfiguration,
+ final Configuration taskConfiguration);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
index 80aa82d..dd730e4 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
@@ -36,7 +36,7 @@ public interface ContextSubmittable {
*
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
*/
- public void submitContext(final Configuration contextConfiguration);
+ void submitContext(final Configuration contextConfiguration);
/**
* Submit a Context and a Service Configuration.
@@ -44,6 +44,6 @@ public interface ContextSubmittable {
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
* @param serviceConfiguration the Configuration for the Services. See ServiceConfiguration for details.
*/
- public void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
+ void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java
index 3ba4f61..b94c852 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java
@@ -43,5 +43,5 @@ public interface FlexiblePreemptionEvent extends PreemptionEvent {
/**
* @return the set of EvaluatorRequests that the underlying resource manager seeks to satisfy.
*/
- public Set<EvaluatorRequest> getEvaluatorRequest();
+ Set<EvaluatorRequest> getEvaluatorRequest();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
index 0f91de6..0f826df 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
@@ -36,5 +36,5 @@ public interface TaskSubmittable {
*
* @param taskConf the Configuration. See TaskConfiguration for details
*/
- public void submitTask(final Configuration taskConf);
+ void submitTask(final Configuration taskConf);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java
index 7eac713..6edc72a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java
@@ -33,10 +33,10 @@ public interface NodeDescriptor extends ResourceCatalog.Descriptor, Identifiable
*
* @return the inet address of the Evaluator.
*/
- public InetSocketAddress getInetSocketAddress();
+ InetSocketAddress getInetSocketAddress();
/**
* @return the rack descriptor that contains this node
*/
- public RackDescriptor getRackDescriptor();
+ RackDescriptor getRackDescriptor();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java
index 03c5558..54ea455 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java
@@ -31,5 +31,5 @@ public interface RackDescriptor extends ResourceCatalog.Descriptor {
/**
* @return the list of nodes in this rack.
*/
- public List<NodeDescriptor> getNodes();
+ List<NodeDescriptor> getNodes();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java
index d02c457..1f0efd7 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java
@@ -39,14 +39,14 @@ public interface ResourceCatalog {
* @return a list of all the static resources available. This is an upper
* bound.
*/
- public Collection<NodeDescriptor> getNodes();
+ Collection<NodeDescriptor> getNodes();
/**
* The global list of racks.
*
* @return list of all rack descriptors
*/
- public Collection<RackDescriptor> getRacks();
+ Collection<RackDescriptor> getRacks();
/**
* Get the node descriptor with the given identifier.
@@ -54,11 +54,11 @@ public interface ResourceCatalog {
* @param id of the node.
* @return the node descriptor assigned to the identifier.
*/
- public NodeDescriptor getNode(String nodeId);
+ NodeDescriptor getNode(String nodeId);
public interface Descriptor {
- public String getName();
+ String getName();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
index 8ff75a8..66712a3 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
@@ -39,6 +39,6 @@ public interface JobMessageObserver {
*
* @param message a message to be sent to the client
*/
- public void sendMessageToClient(final byte[] message);
+ void sendMessageToClient(final byte[] message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
index feaf6e4..1279c23 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
@@ -49,16 +49,16 @@ import org.apache.reef.tang.Configuration;
public interface ActiveContext extends Identifiable, AutoCloseable, ContextBase, TaskSubmittable, ContextSubmittable {
@Override
- public void close();
+ void close();
@Override
- public void submitTask(final Configuration taskConf);
+ void submitTask(final Configuration taskConf);
@Override
- public void submitContext(final Configuration contextConfiguration);
+ void submitContext(final Configuration contextConfiguration);
@Override
- public void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
+ void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
/**
* Send the active context the message, which will be delivered to all registered
@@ -66,6 +66,6 @@ public interface ActiveContext extends Identifiable, AutoCloseable, ContextBase,
*
* @param message
*/
- public void sendMessage(final byte[] message);
+ void sendMessage(final byte[] message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java
index ef3e8cf..ee8be9f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java
@@ -33,5 +33,5 @@ public interface ClosedContext extends ContextBase {
/**
* @return the new top of the stack of context.
*/
- public ActiveContext getParentContext();
+ ActiveContext getParentContext();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java
index 64e8116..b3be7c3 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java
@@ -36,17 +36,17 @@ public interface ContextMessage extends Message, Identifiable {
* @return the message sent by the Context.
*/
@Override
- public byte[] get();
+ byte[] get();
/**
* @return the ID of the sending Context.
*/
@Override
- public String getId();
+ String getId();
/**
* @return the ID of the ContextMessageSource that sent the message on the Context.
*/
- public String getMessageSourceID();
+ String getMessageSourceID();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java
index 72b6e64..5f1db52 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java
@@ -86,7 +86,7 @@ public final class EvaluatorRequest {
* @return the {@link org.apache.reef.driver.catalog.NodeDescriptor} used as the template for this
* {@link EvaluatorRequest}.
*/
- public final ResourceCatalog.Descriptor getDescriptor() {
+ public ResourceCatalog.Descriptor getDescriptor() {
return this.descriptor;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
index 0b7cb30..36aec03 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
@@ -34,5 +34,5 @@ public interface EvaluatorRequestor {
* Submit the request for new evaluator.
* The response will surface in the AllocatedEvaluator message handler.
*/
- public void submit(final EvaluatorRequest req);
+ void submit(final EvaluatorRequest req);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java
index e7ed791..4d7d29b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java
@@ -40,16 +40,16 @@ public interface FailedEvaluator extends Identifiable {
/**
* @return the reason for the failure.
*/
- public EvaluatorException getEvaluatorException();
+ EvaluatorException getEvaluatorException();
/**
* @return the list of all context that failed due to the evaluator failure.
*/
- public List<FailedContext> getFailedContextList();
+ List<FailedContext> getFailedContextList();
/**
* @return the failed task, if there was one running at the time of the evaluator failure.
*/
- public Optional<FailedTask> getFailedTask();
+ Optional<FailedTask> getFailedTask();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java
index 9ed9b68..3ee3949 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java
@@ -36,11 +36,11 @@ public interface CompletedTask extends Message, Identifiable {
/**
* @return the context the Task ran on.
*/
- public ActiveContext getActiveContext();
+ ActiveContext getActiveContext();
/**
* @return the id of the completed task.
*/
@Override
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
index 593f5e4..d406d80 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
@@ -36,7 +36,7 @@ public interface RunningTask extends Identifiable, AutoCloseable {
/**
* @return the context the task is running on.
*/
- public ActiveContext getActiveContext();
+ ActiveContext getActiveContext();
/**
@@ -44,30 +44,30 @@ public interface RunningTask extends Identifiable, AutoCloseable {
*
* @param message to be sent to the running task
*/
- public void send(final byte[] message);
+ void send(final byte[] message);
/**
* Signal the task to suspend.
*
* @param message a message that is sent to the Task.
*/
- public void suspend(final byte[] message);
+ void suspend(final byte[] message);
/**
* Signal the task to suspend.
*/
- public void suspend();
+ void suspend();
/**
* Signal the task to shut down.
*
* @param message a message that is sent to the Task.
*/
- public void close(final byte[] message);
+ void close(final byte[] message);
/**
* Signal the task to shut down.
*/
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java
index 361aab9..e07931f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java
@@ -36,6 +36,6 @@ public interface SuspendedTask extends Message, Identifiable {
* @return the context the task ran on. This context is now available to run another task or to spwan new
* child context
*/
- public ActiveContext getActiveContext();
+ ActiveContext getActiveContext();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
index e216fba..8d4b460 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
@@ -35,5 +35,5 @@ public interface ContextMessageHandler extends EventHandler<byte[]> {
* @param message sent by the driver to this context
*/
@Override
- public void onNext(final byte[] message);
+ void onNext(final byte[] message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java
index 0bc8261..f792748 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java
@@ -33,7 +33,7 @@ public interface ContextMessageSource {
/**
* @return a message to be sent back to the Driver.
*/
- public Optional<ContextMessage> getMessage();
+ Optional<ContextMessage> getMessage();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java
index 99c36ce..c1a4b42 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java
@@ -34,6 +34,6 @@ public interface ContextStart extends Identifiable {
/**
* @return the ID of the EvaluatorContext that was just launched.
*/
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java
index 1b4f803..507b920 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java
@@ -34,6 +34,6 @@ public interface ContextStop extends Identifiable {
/**
* @return the ID of the EvaluatorContext.
*/
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java
index 9a83caf..05126ee 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java
@@ -35,5 +35,5 @@ public interface Accumulable<T> {
* @return the new {@link Accumulator}
* @throws ServiceException
*/
- public Accumulator<T> accumulator() throws ServiceException;
+ Accumulator<T> accumulator() throws ServiceException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
index df74aed..6c55780 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
@@ -36,7 +36,7 @@ public interface ExternalMap<T> {
* @param key
* @return true, if an entry with the given key exists
*/
- public boolean containsKey(final CharSequence key);
+ boolean containsKey(final CharSequence key);
/**
* Element access.
@@ -44,7 +44,7 @@ public interface ExternalMap<T> {
* @param key
* @return the object stored under key nor null if no such object exists
*/
- public T get(final CharSequence key);
+ T get(final CharSequence key);
/**
* Put a record into the map.
@@ -55,7 +55,7 @@ public interface ExternalMap<T> {
* mapping for key. (A null return can also indicate that the map previously
* associated null with key, if the implementation supports null values.)
*/
- public T put(final CharSequence key, final T value);
+ T put(final CharSequence key, final T value);
/**
* Removes the mapping for a key from this map if it is present (optional
@@ -76,7 +76,7 @@ public interface ExternalMap<T> {
* @return the previous value associated with key, or null if there was no
* mapping for key.
*/
- public T remove(final CharSequence key);
+ T remove(final CharSequence key);
/**
* Copies all of the mappings from the specified map to this map (optional
@@ -87,7 +87,7 @@ public interface ExternalMap<T> {
*
* @param m
*/
- public void putAll(final Map<? extends CharSequence, ? extends T> m);
+ void putAll(final Map<? extends CharSequence, ? extends T> m);
- public Iterable<Map.Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys);
+ Iterable<Map.Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java
index 846c996..16ae5e2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java
@@ -31,6 +31,6 @@ public interface Message {
*
* @return message payload
*/
- public byte[] get();
+ byte[] get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java
index 18d2b4b..3dd3f11 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java
@@ -43,7 +43,7 @@ public interface Spool<T> extends Iterable<T>, Accumulable<T> {
* @throws Exception
*/
@Override
- public Iterator<T> iterator();
+ Iterator<T> iterator();
/**
* Returns an Accumulator for the spool file.
@@ -56,5 +56,5 @@ public interface Spool<T> extends Iterable<T>, Accumulable<T> {
* @throws ServiceException
*/
@Override
- public Accumulator<T> accumulator() throws ServiceException;
+ Accumulator<T> accumulator() throws ServiceException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
index 25dcb59..6027518 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
@@ -39,7 +39,7 @@ public interface TempFileCreator {
* @return
* @throws IOException
*/
- public File createTempFile(final String prefix, final String suffix) throws IOException;
+ File createTempFile(final String prefix, final String suffix) throws IOException;
/**
* Creates a temporary folder.
@@ -49,7 +49,7 @@ public interface TempFileCreator {
* @return
* @throws IOException
*/
- public File createTempDirectory(final String prefix, final FileAttribute<?> attrs) throws IOException;
+ File createTempDirectory(final String prefix, final FileAttribute<?> attrs) throws IOException;
/**
@@ -59,7 +59,7 @@ public interface TempFileCreator {
* @return
* @throws IOException
*/
- public File createTempDirectory(final String prefix) throws IOException;
+ File createTempDirectory(final String prefix) throws IOException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java
index 89bfc60..236796a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java
@@ -29,5 +29,5 @@ public interface Identifiable {
*
* @return an identifier of this object
*/
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java
index 2499ecb..95584ff 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java
@@ -32,13 +32,13 @@ public interface NameAssignment {
*
* @return an identifier
*/
- public Identifier getIdentifier();
+ Identifier getIdentifier();
/**
* Returns an address of this object.
*
* @return a socket address
*/
- public InetSocketAddress getAddress();
+ InetSocketAddress getAddress();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
index d6a05a8..13c912c 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
@@ -37,6 +37,6 @@ public interface NamingLookup {
* @return
* @throws java.io.IOException
*/
- public InetSocketAddress lookup(final Identifier id) throws Exception;
+ InetSocketAddress lookup(final Identifier id) throws Exception;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
index 035a348..5600b21 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
@@ -34,7 +34,7 @@ public interface NamingRegistry {
* @param addr
* @throws Exception
*/
- public void register(final Identifier id, final InetSocketAddress addr) throws Exception;
+ void register(final Identifier id, final InetSocketAddress addr) throws Exception;
/**
* Unregister the given Identifier from the registry.
@@ -42,5 +42,5 @@ public interface NamingRegistry {
* @param id
* @throws Exception
*/
- public void unregister(final Identifier id) throws Exception;
+ void unregister(final Identifier id) throws Exception;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java
index 7f00919..1f3c540 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java
@@ -33,7 +33,7 @@ public interface Codec<T> {
* @param obj
* @return a byte[] representation of the object
*/
- public byte[] encode(T obj);
+ byte[] encode(T obj);
/**
* Decodes the given byte array into an object.
@@ -41,5 +41,5 @@ public interface Codec<T> {
* @param buf
* @return the decoded object
*/
- public T decode(byte[] buf);
+ T decode(byte[] buf);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java
index 1e98b81..16b59be 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java
@@ -33,5 +33,5 @@ public interface Deserializer<ObjectType, InType> {
* @param arg
* @return
*/
- public Iterable<ObjectType> create(InType arg);
+ Iterable<ObjectType> create(InType arg);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java
index f373031..a2df4d0 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java
@@ -34,5 +34,5 @@ public interface Serializer<ObjectType, OutType> {
* @param arg
* @return
*/
- public Accumulable<ObjectType> create(OutType arg);
+ Accumulable<ObjectType> create(OutType arg);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
index dd4436a..67c96eb 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
@@ -73,7 +73,7 @@ final class JobSubmissionHelper {
* @throws InjectionException
* @throws IOException
*/
- final JobSubmissionEventImpl.Builder getJobSubmissionBuilder(final Configuration driverConfiguration) throws InjectionException, IOException {
+ JobSubmissionEventImpl.Builder getJobSubmissionBuilder(final Configuration driverConfiguration) throws InjectionException, IOException {
final Injector injector = Tang.Factory.getTang().newInjector(driverConfiguration);
final JobSubmissionEventImpl.Builder jbuilder = JobSubmissionEventImpl.newBuilder()
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java
index baaa7ef..c20d46f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java
@@ -84,7 +84,7 @@ public final class REEFImplementation implements REEF {
}
@Override
- public final void close() {
+ public void close() {
this.runningJobs.closeAllJobs();
this.clientWireUp.close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
index 03c81f8..e640528 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
@@ -35,7 +35,7 @@ interface RunningJobs {
/**
* Closes all registered jobs forcefully.
*/
- public void closeAllJobs();
+ void closeAllJobs();
/**
* Processes a status message from a Job. If the Job is already known, the message will be passed on. If it is a
@@ -43,13 +43,13 @@ interface RunningJobs {
*
* @param message
*/
- public void onJobStatusMessage(final RemoteMessage<ReefServiceProtos.JobStatusProto> message);
+ void onJobStatusMessage(final RemoteMessage<ReefServiceProtos.JobStatusProto> message);
/**
* Processes a error message from the resource manager.
*
* @param runtimeFailure
*/
- public void onRuntimeErrorMessage(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure);
+ void onRuntimeErrorMessage(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java
index d150f8a..3cdae31 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java
@@ -25,5 +25,5 @@ import org.apache.reef.wake.EventHandler;
public interface JobSubmissionHandler extends EventHandler<JobSubmissionEvent>, AutoCloseable {
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java
index 6724ca7..f195986 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java
@@ -37,7 +37,7 @@ public final class RackDescriptorImpl implements RackDescriptor {
this.nodes = new ArrayList<>();
}
- public final String toString() {
+ public String toString() {
final StringBuilder sb = new StringBuilder();
sb.append("Rack " + this.name);
for (final NodeDescriptorImpl node : nodes) {
@@ -46,11 +46,11 @@ public final class RackDescriptorImpl implements RackDescriptor {
return sb.toString();
}
- public final int hashCode() {
+ public int hashCode() {
return this.name.hashCode();
}
- public final boolean equals(final Object obj) {
+ public boolean equals(final Object obj) {
if (obj instanceof RackDescriptorImpl) {
return obj.toString().equals(this.name);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java
index b03ef1d..59f9c7b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java
@@ -64,11 +64,11 @@ public final class ResourceCatalogImpl implements ResourceCatalog {
return Collections.unmodifiableCollection(new ArrayList<RackDescriptor>(this.racks.values()));
}
- public synchronized final NodeDescriptor getNode(final String id) {
+ public synchronized NodeDescriptor getNode(final String id) {
return this.nodes.get(id);
}
- public synchronized final void handle(final NodeDescriptorEvent node) {
+ public synchronized void handle(final NodeDescriptorEvent node) {
final String rack_name = node.getRackName().orElse(DEFAULT_RACK);
LOG.log(Level.FINEST, "Catalog new node: id[{0}], rack[{1}], host[{2}], port[{3}], memory[{4}]",
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java
index cda8d4f..f5a41e2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java
@@ -76,7 +76,7 @@ final class ContextFactory {
* @param parentID
* @return a new Context representer with the given id and parent id.
*/
- public final EvaluatorContext newContext(final String contextId, final Optional<String> parentID) {
+ public EvaluatorContext newContext(final String contextId, final Optional<String> parentID) {
synchronized (this.priorIds) {
if (this.priorIds.contains(contextId)) {
throw new IllegalStateException("Creating second EvaluatorContext instance for id " + contextId);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java
index 26d2263..4c79972 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java
@@ -49,7 +49,7 @@ public final class ContextMessageImpl implements ContextMessage {
}
@Override
- public final String getMessageSourceID() {
+ public String getMessageSourceID() {
return this.theMessageSourceId;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java
index d5c6d5a..3cefc12 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java
@@ -218,7 +218,7 @@ public final class EvaluatorContext implements ActiveContext {
", parentID=" + this.parentID + '}';
}
- public synchronized final ClosedContext getClosedContext(final ActiveContext parentContext) {
+ public synchronized ClosedContext getClosedContext(final ActiveContext parentContext) {
return new ClosedContextImpl(
parentContext, this.getId(), this.getEvaluatorId(), this.getEvaluatorDescriptor());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
index e59b11c..0bdf420 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
@@ -169,9 +169,9 @@ final class AllocatedEvaluatorImpl implements AllocatedEvaluator {
this.libraries.add(file);
}
- private final void launch(final Configuration contextConfiguration,
- final Optional<Configuration> serviceConfiguration,
- final Optional<Configuration> taskConfiguration) {
+ private void launch(final Configuration contextConfiguration,
+ final Optional<Configuration> serviceConfiguration,
+ final Optional<Configuration> taskConfiguration) {
try (final LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) {
final Configuration evaluatorConfiguration =
makeEvaluatorConfiguration(contextConfiguration, serviceConfiguration, taskConfiguration);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java
index 20aa620..655d4e4 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java
@@ -40,7 +40,7 @@ final class EvaluatorHeartBeatSanityChecker {
EvaluatorHeartBeatSanityChecker() {
}
- final synchronized void check(final String id, final long timeStamp) {
+ synchronized void check(final String id, final long timeStamp) {
if (knownTimeStamps.containsKey(id)) {
final long oldTimeStamp = this.knownTimeStamps.get(id);
LOG.log(Level.FINEST, "TIMESTAMP CHECKER: id [ " + id + " ], old timestamp [ " + oldTimeStamp + " ], new timestamp [ " + timeStamp + " ]");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java
index f0680af..050a44a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java
@@ -59,7 +59,7 @@ public final class EvaluatorManagerFactory {
* @param desc NodeDescriptor on which the Evaluator executes.
* @return a new EvaluatorManager instance.
*/
- private final EvaluatorManager getNewEvaluatorManagerInstance(final String id, final EvaluatorDescriptorImpl desc) {
+ private EvaluatorManager getNewEvaluatorManagerInstance(final String id, final EvaluatorDescriptorImpl desc) {
LOG.log(Level.FINEST, "Creating Evaluator Manager for Evaluator ID {0}", id);
final Injector child = this.injector.forkInjector();
@@ -85,7 +85,7 @@ public final class EvaluatorManagerFactory {
* @param resourceAllocationEvent
* @return
*/
- public final EvaluatorManager getNewEvaluatorManager(final ResourceAllocationEvent resourceAllocationEvent) {
+ public EvaluatorManager getNewEvaluatorManager(final ResourceAllocationEvent resourceAllocationEvent) {
final NodeDescriptor nodeDescriptor = this.resourceCatalog.getNode(resourceAllocationEvent.getNodeId());
if (nodeDescriptor == null) {
@@ -98,7 +98,7 @@ public final class EvaluatorManagerFactory {
return this.getNewEvaluatorManagerInstance(resourceAllocationEvent.getIdentifier(), evaluatorDescriptor);
}
- public final EvaluatorManager createForEvaluatorFailedDuringDriverRestart(final ResourceStatusEvent resourceStatusEvent) {
+ public EvaluatorManager createForEvaluatorFailedDuringDriverRestart(final ResourceStatusEvent resourceStatusEvent) {
if (!resourceStatusEvent.getIsFromPreviousDriver().get()) {
throw new RuntimeException("Invalid resourceStatusEvent, must be status for resource from previous Driver.");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java
index 17824e2..d9485ff 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java
@@ -55,7 +55,7 @@ public final class TaskMessageImpl implements TaskMessage {
}
@Override
- public final String getMessageSourceID() {
+ public String getMessageSourceID() {
return this.theMessageSourceId;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
index 8b8d5d3..baea749 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
@@ -125,7 +125,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> {
}
}
- private final void onException(final Throwable exception) {
+ private void onException(final Throwable exception) {
synchronized (this.heartBeatManager) {
this.state = ReefServiceProtos.State.FAILED;
@@ -150,7 +150,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> {
}
}
- final ReefServiceProtos.State getState() {
+ ReefServiceProtos.State getState() {
return this.state;
}
@@ -166,7 +166,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> {
final class RuntimeStartHandler implements EventHandler<RuntimeStart> {
@Override
- public final void onNext(final RuntimeStart runtimeStart) {
+ public void onNext(final RuntimeStart runtimeStart) {
synchronized (EvaluatorRuntime.this.heartBeatManager) {
try {
LOG.log(Level.FINEST, "runtime start");
@@ -184,7 +184,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> {
final class RuntimeStopHandler implements EventHandler<RuntimeStop> {
@Override
- public final void onNext(final RuntimeStop runtimeStop) {
+ public void onNext(final RuntimeStop runtimeStop) {
synchronized (EvaluatorRuntime.this.heartBeatManager) {
LOG.log(Level.FINEST, "EvaluatorRuntime shutdown invoked for Evaluator {0} in state {1}",
new Object[]{evaluatorIdentifier, state});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java
index afb5480..d85e8aa 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java
@@ -134,7 +134,7 @@ public class HeartBeatManager {
this.contextManager.get().getTaskStatus());
}
- private final EvaluatorRuntimeProtocol.EvaluatorHeartbeatProto getEvaluatorHeartbeatProto(
+ private EvaluatorRuntimeProtocol.EvaluatorHeartbeatProto getEvaluatorHeartbeatProto(
final ReefServiceProtos.EvaluatorStatusProto evaluatorStatusProto,
final Iterable<ReefServiceProtos.ContextStatusProto> contextStatusProtos,
final Optional<ReefServiceProtos.TaskStatusProto> taskStatusProto) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java
index 934549c..dbb090b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java
@@ -58,7 +58,7 @@ final class ContextLifeCycle {
/**
* Fires ContextStart to all registered event handlers.
*/
- final void start() {
+ void start() {
final ContextStart contextStart = new ContextStartImpl(this.identifier);
for (final EventHandler<ContextStart> startHandler : this.contextStartHandlers) {
startHandler.onNext(contextStart);
@@ -68,7 +68,7 @@ final class ContextLifeCycle {
/**
* Fires ContextStop to all registered event handlers.
*/
- final void close() {
+ void close() {
final ContextStop contextStop = new ContextStopImpl(this.identifier);
for (final EventHandler<ContextStop> stopHandler : this.contextStopHandlers) {
stopHandler.onNext(contextStop);
@@ -80,18 +80,18 @@ final class ContextLifeCycle {
*
* @param message sent by the driver
*/
- final void handleContextMessage(final byte[] message) {
+ void handleContextMessage(final byte[] message) {
this.contextMessageHandler.onNext(message);
}
/**
* @return (a shallow copy of) the set of ContextMessageSources configured.
*/
- final Set<ContextMessageSource> getContextMessageSources() {
+ Set<ContextMessageSource> getContextMessageSources() {
return Collections.unmodifiableSet(new LinkedHashSet<>(this.contextMessageSources));
}
- final String getIdentifier() {
+ String getIdentifier() {
return this.identifier;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java
index 756aed2..3aca309 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java
@@ -272,7 +272,7 @@ public final class ContextRuntime {
* Close this context. If there is a child context, this recursively closes it before closing this context. If
* there is a Task currently running, that will be closed.
*/
- final void close() {
+ void close() {
synchronized (this.contextLifeCycle) {
@@ -369,7 +369,7 @@ public final class ContextRuntime {
*
* @param message sent by the driver
*/
- final void handleContextMessage(final byte[] message) {
+ void handleContextMessage(final byte[] message) {
this.contextLifeCycle.handleContextMessage(message);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java
index 49310dc..0802507 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java
@@ -121,14 +121,14 @@ final class RootContextLauncher {
/**
* @return the root context for this evaluator.
*/
- final ContextRuntime getRootContext() throws ContextClientCodeException {
+ ContextRuntime getRootContext() throws ContextClientCodeException {
if (null == this.rootContext) {
this.rootContext = getRootContext(this.injector, this.rootContextConfiguration, this.rootServiceConfiguration);
}
return this.rootContext;
}
- final Optional<Configuration> getInitialTaskConfiguration() {
+ Optional<Configuration> getInitialTaskConfiguration() {
return this.initialTaskConfiguration;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java
index dad7f45..6be5875 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java
@@ -181,7 +181,7 @@ public final class TaskRuntime implements Runnable {
*
* @param message the optional message for the close handler or null if there none.
*/
- public final void close(final byte[] message) {
+ public void close(final byte[] message) {
LOG.log(Level.FINEST, "Triggering Task close.");
synchronized (this.heartBeatManager) {
if (this.currentStatus.isNotRunning()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java
index ba1d475..b2c3781 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java
@@ -132,7 +132,7 @@ public final class TaskStatus {
}
}
- public final String getTaskId() {
+ public String getTaskId() {
return this.taskId;
}
@@ -285,7 +285,7 @@ public final class TaskStatus {
/**
* @return the messages to be sent on the Task's behalf in the next heartbeat.
*/
- private final Collection<TaskMessage> getMessages() {
+ private Collection<TaskMessage> getMessages() {
final List<TaskMessage> result = new ArrayList<>(this.evaluatorMessageSources.size());
for (final TaskMessageSource messageSource : this.evaluatorMessageSources) {
final Optional<TaskMessage> taskMessageOptional = messageSource.getMessage();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
index a2069be..2cfbfe6 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
@@ -29,13 +29,13 @@ public interface LaunchCommandBuilder {
/**
* @return the launch command line
*/
- public List<String> build();
+ List<String> build();
- public LaunchCommandBuilder setErrorHandlerRID(final String errorHandlerRID);
+ LaunchCommandBuilder setErrorHandlerRID(final String errorHandlerRID);
- public LaunchCommandBuilder setLaunchID(final String launchID);
+ LaunchCommandBuilder setLaunchID(final String launchID);
- public LaunchCommandBuilder setMemory(final int megaBytes);
+ LaunchCommandBuilder setMemory(final int megaBytes);
/**
* Set the name of the configuration file for the Launcher. This file is assumed to exist in the working directory of
@@ -44,7 +44,7 @@ public interface LaunchCommandBuilder {
* @param configurationFileName
* @return this
*/
- public LaunchCommandBuilder setConfigurationFileName(final String configurationFileName);
+ LaunchCommandBuilder setConfigurationFileName(final String configurationFileName);
/**
* Names a file to which stdout will be redirected.
@@ -52,7 +52,7 @@ public interface LaunchCommandBuilder {
* @param standardOut
* @return this
*/
- public LaunchCommandBuilder setStandardOut(final String standardOut);
+ LaunchCommandBuilder setStandardOut(final String standardOut);
/**
* Names a file to which stderr will be redirected.
@@ -60,7 +60,7 @@ public interface LaunchCommandBuilder {
* @param standardErr
* @return this
*/
- public LaunchCommandBuilder setStandardErr(final String standardErr);
+ LaunchCommandBuilder setStandardErr(final String standardErr);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java
index 5159a4d..ef25689 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java
@@ -44,7 +44,7 @@ final class REEFUncaughtExceptionHandler implements Thread.UncaughtExceptionHand
}
@Override
- public final synchronized void uncaughtException(final Thread thread, final Throwable throwable) {
+ public synchronized void uncaughtException(final Thread thread, final Throwable throwable) {
final String msg = "Thread " + thread.getName() + " threw an uncaught exception.";
LOG.log(Level.SEVERE, msg, throwable);
this.errorHandler.onNext(new Exception(msg, throwable));