You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/08/06 08:11:50 UTC
[incubator-echarts] branch fix/timeline-icon-style created (now
5b8839b)
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a change to branch fix/timeline-icon-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.
at 5b8839b fix(timeline): fix icon style not work bug brought in #13015
This branch includes the following new commits:
new 5b8839b fix(timeline): fix icon style not work bug brought in #13015
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[incubator-echarts] 01/01: fix(timeline): fix icon style not work
bug brought in #13015
Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch fix/timeline-icon-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 5b8839bb6fe54abb9e95b9beed100566b2c5fc6e
Author: pissang <bm...@gmail.com>
AuthorDate: Thu Aug 6 16:11:20 2020 +0800
fix(timeline): fix icon style not work bug brought in #13015
---
src/component/timeline/SliderTimelineView.js | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/component/timeline/SliderTimelineView.js b/src/component/timeline/SliderTimelineView.js
index 71594d0..216d376 100644
--- a/src/component/timeline/SliderTimelineView.js
+++ b/src/component/timeline/SliderTimelineView.js
@@ -618,11 +618,17 @@ function getViewRect(model, api) {
}
function makeIcon(timelineModel, objPath, rect, opts) {
- return graphic.createIcon(
+ const style = opts.style;
+ const icon = graphic.createIcon(
timelineModel.get(objPath),
opts || {},
new BoundingRect(rect[0], rect[1], rect[2], rect[3])
);
+ // TODO createIcon won't use style in opt.
+ if (style) {
+ icon.setStyle(style);
+ }
+ return icon;
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org