You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/01 06:10:49 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #22556: Split pipeline scenario module and package
sandynz opened a new pull request, #22556:
URL: https://github.com/apache/shardingsphere/pull/22556
Part of #22186.
Changes proposed in this pull request:
- Split `scenario` module to `scenario-consistencycheck` and `scenario-migration` modules
- Resolve module dependencies and compile error
- Split scenario sub-modules package
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy merged pull request #22556: Split pipeline scenario module and package
Posted by GitBox <gi...@apache.org>.
azexcy merged PR #22556:
URL: https://github.com/apache/shardingsphere/pull/22556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22556: Split pipeline scenario module and package
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22556:
URL: https://github.com/apache/shardingsphere/pull/22556#issuecomment-1333283453
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22556](https://codecov.io/gh/apache/shardingsphere/pull/22556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (027fd88) into [master](https://codecov.io/gh/apache/shardingsphere/commit/74cb6a67bd975c18b3331e28e3bdcb1de6aaa7bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74cb6a6) will **decrease** coverage by `0.30%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22556 +/- ##
============================================
- Coverage 50.94% 50.64% -0.31%
+ Complexity 2520 2470 -50
============================================
Files 4189 4113 -76
Lines 58311 57520 -791
Branches 9920 9809 -111
============================================
- Hits 29708 29132 -576
+ Misses 26076 25890 -186
+ Partials 2527 2498 -29
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...i/impl/AbstractInventoryIncrementalJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0Fic3RyYWN0SW52ZW50b3J5SW5jcmVtZW50YWxKb2JBUElJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...stency/ConsistencyCheckJobItemProgressContext.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L0NvbnNpc3RlbmN5Q2hlY2tKb2JJdGVtUHJvZ3Jlc3NDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cy/SingleTableInventoryDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L1NpbmdsZVRhYmxlSW52ZW50b3J5RGF0YUNvbnNpc3RlbmN5Q2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/job/progress/PipelineJobProgressDetector.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2pvYi9wcm9ncmVzcy9QaXBlbGluZUpvYlByb2dyZXNzRGV0ZWN0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...scenario/consistencycheck/ConsistencyCheckJob.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL0NvbnNpc3RlbmN5Q2hlY2tKb2IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...enario/consistencycheck/ConsistencyCheckJobId.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL0NvbnNpc3RlbmN5Q2hlY2tKb2JJZC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...stencycheck/api/ConsistencyCheckJobAPIFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL2FwaS9Db25zaXN0ZW5jeUNoZWNrSm9iQVBJRmFjdG9yeS5qYXZh) | `0.00% <ø> (ø)` | |
| [...encycheck/api/impl/ConsistencyCheckJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL2FwaS9pbXBsL0NvbnNpc3RlbmN5Q2hlY2tKb2JBUElJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ycheck/context/ConsistencyCheckJobItemContext.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL2NvbnRleHQvQ29uc2lzdGVuY3lDaGVja0pvYkl0ZW1Db250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...sistencyCheckChangedJobConfigurationProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vY29uc2lzdGVuY3ljaGVjay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9zY2VuYXJpby9jb25zaXN0ZW5jeWNoZWNrL21ldGFkYXRhL3Byb2Nlc3Nvci9Db25zaXN0ZW5jeUNoZWNrQ2hhbmdlZEpvYkNvbmZpZ3VyYXRpb25Qcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [109 more](https://codecov.io/gh/apache/shardingsphere/pull/22556/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org