[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21030: [fix] [broker] Ensure policy cache is updated before updateTopicPoliciesAsync returns.

["codelipenghui (via GitHub)" <gi...@apache.org>]

codelipenghui commented on code in PR #21030:
URL: https://github.com/apache/pulsar/pull/21030#discussion_r1300284284


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -84,6 +86,8 @@ public class SystemTopicBasedTopicPoliciesService implements TopicPoliciesServic
     @VisibleForTesting
     final Map<TopicName, List<TopicPolicyListener<TopicPolicies>>> listeners = new ConcurrentHashMap<>();
 
+    final Map<TopicName, BlockingDeque<CompletableFuture>> results = new ConcurrentHashMap<>();

Review Comment:
   I don't think it will resolve the issue completely because the next request might happened on different brokers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org