[GitHub] [airflow] mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #7296: [AIRFLOW-6683] Make REST API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r374004911
 
 

 ##########
 File path: tests/www/api/experimental/test_dag_runs_endpoint.py
 ##########
 @@ -65,6 +68,13 @@ def test_get_dag_runs_success(self):
         self.assertEqual(data[0]['dag_id'], dag_id)
         self.assertEqual(data[0]['id'], dag_run.id)
 
+    @conf_vars({("core", "store_serialized_dags"): "True"})
+    def test_get_dag_runs_success_serialized_dags(self):
+        dagbag = DagBag(include_examples=True)
+        dag = dagbag.get_dag('example_bash_operator')
+        SerializedDagModel.write_dag(dag)
+        self.test_get_dag_runs_success()
 
 Review comment:
   Can you extract the common part to the new method and call from two test methods?  This will make it easier to understand because tests should not depend on other tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services