[jira] [Commented] (MRESOLVER-12) Addition of unit tests for the various DependencySelector implementations to test things are working as documented.

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766059#comment-15766059 ] 

Hudson commented on MRESOLVER-12:
---------------------------------

SUCCESS: Integrated in Jenkins build maven-resolver #29 (See [https://builds.apache.org/job/maven-resolver/29/])
[MRESOLVER-12] Addition of unit tests for the various DependencySelector (schulte: rev 65e1e5f46e9e47953aead20a9636d1378f1d6400)
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/management-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/pom-management-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-2_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-1_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_root_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_root_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-3_managed-by-transitive-1.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-transitive-of-direct_ver.ini
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/all-nodes.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_root_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-direct-scope-exclusion-tree.txt
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-1-exclusion-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_5_managed-by-3.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-direct-dependency.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-transitive-of-transitive-of-direct-scope-exclusion-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_0_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/gid_transitive-of-direct_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-of-direct-scope-exclusion-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes-of-pom.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-direct_ver.ini
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/all-nodes.txt
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-1_managed-by-root.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-of-transitive-of-transitive-of-direct_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_3_managed-by-1.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-4_managed-by-transitive-2.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/without-optional-transitive-nodes-of-pom.txt
* (edit) maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/transitive-2-exclusion-tree.txt
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_1_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/optional/optional-transitive-exclusion-tree.txt
* (edit) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_direct_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-2_ver.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_4_managed-by-2.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/selection/scope/gid_transitive-1_ver.ini
* (add) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_transitive-2_managed-by-direct.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_1_managed-by-request.ini
* (delete) maven-resolver-impl/src/test/resources/artifact-descriptions/managed/gid_2_managed-by-0.ini


> Addition of unit tests for the various DependencySelector implementations to test things are working as documented.
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: MRESOLVER-12
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-12
>             Project: Maven Resolver
>          Issue Type: Task
>            Reporter: Christian Schulte
>            Assignee: Christian Schulte
>            Priority: Minor
>             Fix For: Maven Artifact Resolver 1.2.0
>
>
> The {{DefaultDependencyCollector}} heavily relies on various components provided by an application. There should be unit tests for testing that at least the {{ScopeDependencySelector}} and {{OptionalDependencySelector}} selector are working as stated in the Javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)