You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:51:51 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor

danny0405 commented on a change in pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1734#discussion_r364054446
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -115,8 +115,11 @@
  * {@link org.apache.calcite.rel.core.TableScan},
  * {@link org.apache.calcite.rel.core.Filter},
  * {@link org.apache.calcite.rel.core.Project},
+ * {@link org.apache.calcite.rel.core.Calc},
  * {@link org.apache.calcite.rel.core.Join},
  * {@link org.apache.calcite.rel.core.Union},
+ * {@link org.apache.calcite.rel.core.Intersect},
+ * {@link org.apache.calcite.rel.core.Sort},
 
 Review comment:
   Doc like enumerating the classes are hard to maintain, people should always remember to update the references, let's avoid to make such kind of doc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services