You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/09 15:25:14 UTC

[GitHub] [superset] reesercollins commented on pull request #20995: feat: Allow mutli-select values to be edited

reesercollins commented on PR #20995:
URL: https://github.com/apache/superset/pull/20995#issuecomment-1209528661

   Thank you for your feedback @michael-s-molina and @geido.
   
   Our team does have a common use case where deleting retyping filter values can be quite tedious (i.e. long domain names) where you may have just made a single typo. 
   
   Regarding preventing new values from being entered when they shouldn't be, I have made editing only functional when `allowNewValue` is true.
   
   We are open to revamping the design. This was just my first attempt at a working version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org