[GitHub] [couchdb] garrensmith opened a new pull request #3676: Run the validate doc update function through couch_eval

[GitBox <gi...@apache.org>]

garrensmith opened a new pull request #3676:
URL: https://github.com/apache/couchdb/pull/3676


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   With Couchdb on fdb, we want all javascript and language specific functionality to run through `couch_eval`. 
   This moves the `validate_doc_update` check to run through `couch_eval` instead of going directly through `couch_query_servers`. 
   
   
   ## Testing recommendations
   
   All existing tests should pass. 
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak commented on a change in pull request #3676: Run the validate doc update function through couch_eval

[GitBox <gi...@apache.org>]

iilyak commented on a change in pull request #3676:
URL: https://github.com/apache/couchdb/pull/3676#discussion_r674739691



##########
File path: src/couch/src/test_util.erl
##########
@@ -336,3 +337,13 @@ sort_apps(Apps) ->
 
 weight_app(couch_log) -> {0.0, couch_log};
 weight_app(Else) -> {1.0, Else}.
+
+maybe_add_js_engine(Apps) ->
+    case lists:member(js_engine, Apps) of
+        false ->
+            Apps;
+        true ->
+            application:start(config),

Review comment:
       This would cause a warning defined [here](https://github.com/apache/couchdb/pull/3676/files#diff-1386116efada5b26bab45d122ba9e6ba799e42d5adfdb6ce0b38f5abdd142fd8R102). Also `config` app will be restarted. To prevent it you could remove `config` from list of Apps. Since you started it already.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] garrensmith merged pull request #3676: Run the validate doc update function through couch_eval

[GitBox <gi...@apache.org>]

garrensmith merged pull request #3676:
URL: https://github.com/apache/couchdb/pull/3676


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak commented on pull request #3676: Run the validate doc update function through couch_eval

[GitBox <gi...@apache.org>]

iilyak commented on pull request #3676:
URL: https://github.com/apache/couchdb/pull/3676#issuecomment-884878042


   Could you add reference to https://github.com/cloudant-labs/ateles/pull/29 in `Related Issues or Pull Requests` section in the PR description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org