You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2020/05/15 02:31:11 UTC

Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72515/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-3785
    https://issues.apache.org/jira/browse/ATLAS-3785


Repository: atlas


Description
-------

Modify the aws s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional


Diffs
-----

  addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json 676a2237c 


Diff: https://reviews.apache.org/r/72515/diff/1/


Testing
-------

Manually added to my cluster


Thanks,

Sidharth Mishra


Re: Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72515/
-----------------------------------------------------------

(Updated May 15, 2020, 6:50 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-3785
    https://issues.apache.org/jira/browse/ATLAS-3785


Repository: atlas


Description
-------

Modify the aws s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional


Diffs (updated)
-----

  addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json 676a2237c 


Diff: https://reviews.apache.org/r/72515/diff/2/

Changes: https://reviews.apache.org/r/72515/diff/1-2/


Testing
-------

Manually added to my cluster


Thanks,

Sidharth Mishra


Re: Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72515/#review220779
-----------------------------------------------------------


Fix it, then Ship it!





addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json
Line 262 (original), 271 (patched)
<https://reviews.apache.org/r/72515/#comment309480>

    revert to version 1.0


- Sarath Subramanian


On May 14, 2020, 7:31 p.m., Sidharth Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72515/
> -----------------------------------------------------------
> 
> (Updated May 14, 2020, 7:31 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3785
>     https://issues.apache.org/jira/browse/ATLAS-3785
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Modify the aws s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json 676a2237c 
> 
> 
> Diff: https://reviews.apache.org/r/72515/diff/1/
> 
> 
> Testing
> -------
> 
> Manually added to my cluster
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>