You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 14:17:20 UTC

[GitHub] [flink] zentol opened a new pull request #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

zentol opened a new pull request #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255
 
 
   Removes the `DatadogHttpRequest` class which was a simple wrapper around the `DSeries`. It just adds another layer of indirection of which the datadog code already as more than enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255#issuecomment-592533707
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b77ab155bdeadfd71560d992fc33fc2e3a2a6d56 (Fri Feb 28 14:20:53 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255#issuecomment-592539143
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151036629",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b77ab155bdeadfd71560d992fc33fc2e3a2a6d56 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151036629) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255#issuecomment-592539143
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b77ab155bdeadfd71560d992fc33fc2e3a2a6d56 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255#issuecomment-592539143
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151036629",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b77ab155bdeadfd71560d992fc33fc2e3a2a6d56 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151036629) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255#issuecomment-592539143
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151036629",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742",
       "triggerID" : "b77ab155bdeadfd71560d992fc33fc2e3a2a6d56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b77ab155bdeadfd71560d992fc33fc2e3a2a6d56 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151036629) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11255: [FLINK-16341][metrics][datadog] Unify DatadogHttpRequest and DSeries
URL: https://github.com/apache/flink/pull/11255
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services