[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case

[GitBox <gi...@apache.org>]

arjun4084346 commented on a change in pull request #2685: [GOBBLIN-822] Upgrade log4j to log4j2 for LogRouting use-case
URL: https://github.com/apache/incubator-gobblin/pull/2685#discussion_r308080829
 
 

 ##########
 File path: gobblin-test-harness/src/test/java/org/apache/gobblin/TaskErrorIntegrationTest.java
 ##########
 @@ -114,24 +113,24 @@ public void testErrorDuringSubmission()
 
     GobblinLocalJobLauncherUtils.invokeLocalJobLauncher(jobProperties);
 
-    Assert.assertTrue(testAppender.events.stream().anyMatch(e -> e.getRenderedMessage()
+    Assert.assertTrue(testAppender.events.stream().anyMatch(e -> e.getMessage().getFormattedMessage()
         .startsWith("Could not submit task for workunit")));
 
     logger.removeAppender(testAppender);
   }
 
   @Test
   public void testCustomizedTaskFrameworkFailureInTaskCreation() throws Exception {
-    TestAppender testAppender = new TestAppender();
-    Logger logger = LogManager.getLogger(GobblinMultiTaskAttempt.class.getName() + "-noattempt");
+    TestAppender testAppender = new TestAppender(GobblinMultiTaskAttempt.class.getName() + "-noattempt");
+    Logger logger = (Logger) LogManager.getLogger(GobblinMultiTaskAttempt.class.getName() + "-noattempt");
 
 Review comment:
   Maybe change to 
   Logger logger = (Logger) LogManager.getLogger(testAppender.getName()); ?
   
   also in all the places above 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services