You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li...@apache.org on 2008/03/04 03:40:39 UTC
svn commit: r633353 -
/incubator/shindig/trunk/javascript/container/gadgets.js
Author: lindner
Date: Mon Mar 3 18:40:35 2008
New Revision: 633353
URL: http://svn.apache.org/viewvc?rev=633353&view=rev
Log:
add a debug option to get js without compression, fix class/id problem for SHINDIG-105
Modified:
incubator/shindig/trunk/javascript/container/gadgets.js
Modified: incubator/shindig/trunk/javascript/container/gadgets.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
==============================================================================
--- incubator/shindig/trunk/javascript/container/gadgets.js (original)
+++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3 18:40:35 2008
@@ -362,6 +362,8 @@
* "title": the default title to use for the title bar.
* "height": height of the gadget
* "width": width of the gadget
+ * "debug": send debug=1 to the gadget server, gets us uncompressed
+ * javascript
*/
gadgets.Gadget = function(params) {
this.userPrefs_ = {};
@@ -465,7 +467,7 @@
gadgets.IfrGadget.prototype.getTitleBarContent = function(continuation) {
continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
- 'class="' + this.cssClassTitleBar + '"><span id="' +
+ '" class="' + this.cssClassTitleBar + '"><span id="' +
this.getIframeId() + '_title" class="' +
this.cssClassTitle + '">' + (this.title ? this.title : 'Title') + '</span> | <span class="' +
this.cssClassTitleButtonBar +
@@ -519,7 +521,8 @@
'&country=' + gadgets.container.country_ +
'&lang=' + gadgets.container.language_ +
'&view=' + gadgets.container.view_ +
- this.getUserPrefsParams() +
+ (this.debug ? '&debug=1' : '') +
+ this.getUserPrefsParams() +
'#rpctoken=' + this.rpcToken +
(this.secureToken ? '&st=' + (this.secureToken || "") : '') +
(this.viewParams ?
Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Kevin Brown <et...@google.com>.
Ah -- right, my mistake!
Looks like the problem manifests when you neither set a parent parameter nor
have an absolute value for the relay. I'll drop in a fix.
The option to set parent should probably be there in any case, along with
other url parameters, if this is to be used on real sites.
On Tue, Mar 4, 2008 at 1:34 AM, Paul Lindner <pl...@hi5.com> wrote:
> You removed the parent URL param in r628908:
>
>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?r1=628730&r2=628908&diff_format=h
>
> I'll add an option to supply the parent and set that in the samples...
>
> -----Original Message-----
> From: Kevin Brown [mailto:etnu@google.com]
> Sent: Tue 3/4/2008 1:06 AM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r633353 -
> /incubator/shindig/trunk/javascript/container/gadgets.js
>
> Yes, that would work, but it makes testing and development very difficult
> --
> which is why the parent parameter is used in the first place. The problem
> is
> that you're not passing the parent parameter to the iframe url. Changing
> that back will resolve the problem.
>
> On Mon, Mar 3, 2008 at 9:23 PM, Paul Lindner <pl...@hi5.com> wrote:
>
> >
> > It appears that the problems began with r632712
> >
> >
> >
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?r1=632675&r2=632712&diff_format=h
> >
> > I edited my syndicator.js file and changed parentRelayUrl to be absolute
> > and everything started to work:
> >
> > "parentRelayUrl" : "
> > http://www.inuus.com:8080/gadgets/files/container/rpc_relay.html"
> >
> > I'll see if I can come up with a better general solution...
> >
> >
> > -----Original Message-----
> > From: Kevin Brown [mailto:etnu@google.com]
> > Sent: Mon 3/3/2008 6:45 PM
> > To: shindig-dev@incubator.apache.org
> > Subject: Re: svn commit: r633353 -
> > /incubator/shindig/trunk/javascript/container/gadgets.js
> >
> > Hey Paul,
> >
> > One of these recent changes seems to have broken all the sample files --
> > gadgets.js is no longer providing default values for parent, which is
> > making
> > rpc calls fail. Can you take a look?
> >
> > On Mon, Mar 3, 2008 at 6:40 PM, <li...@apache.org> wrote:
> >
> > > Author: lindner
> > > Date: Mon Mar 3 18:40:35 2008
> > > New Revision: 633353
> > >
> > > URL: http://svn.apache.org/viewvc?rev=633353&view=rev
> > > Log:
> > > add a debug option to get js without compression, fix class/id problem
> > for
> > > SHINDIG-105
> > >
> > > Modified:
> > > incubator/shindig/trunk/javascript/container/gadgets.js
> > >
> > > Modified: incubator/shindig/trunk/javascript/container/gadgets.js
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- incubator/shindig/trunk/javascript/container/gadgets.js (original)
> > > +++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3
> > > 18:40:35 2008
> > > @@ -362,6 +362,8 @@
> > > * "title": the default title to use for the title bar.
> > > * "height": height of the gadget
> > > * "width": width of the gadget
> > > + * "debug": send debug=1 to the gadget server, gets us
> uncompressed
> > > + * javascript
> > > */
> > > gadgets.Gadget = function(params) {
> > > this.userPrefs_ = {};
> > > @@ -465,7 +467,7 @@
> > >
> > > gadgets.IfrGadget.prototype.getTitleBarContent =
> function(continuation)
> > {
> > > continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
> > > - 'class="' + this.cssClassTitleBar + '"><span id="' +
> > > + '" class="' + this.cssClassTitleBar + '"><span id="' +
> > > this.getIframeId() + '_title" class="' +
> > > this.cssClassTitle + '">' + (this.title ? this.title : 'Title')
> +
> > > '</span> | <span class="' +
> > > this.cssClassTitleButtonBar +
> > > @@ -519,7 +521,8 @@
> > > '&country=' + gadgets.container.country_ +
> > > '&lang=' + gadgets.container.language_ +
> > > '&view=' + gadgets.container.view_ +
> > > - this.getUserPrefsParams() +
> > > + (this.debug ? '&debug=1' : '') +
> > > + this.getUserPrefsParams() +
> > > '#rpctoken=' + this.rpcToken +
> > > (this.secureToken ? '&st=' + (this.secureToken || "") : '') +
> > > (this.viewParams ?
> > >
> > >
> > >
> >
> >
> > --
> > ~Kevin
> >
> >
>
>
> --
> ~Kevin
>
>
--
~Kevin
RE: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Paul Lindner <pl...@hi5.com>.
You removed the parent URL param in r628908:
http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?r1=628730&r2=628908&diff_format=h
I'll add an option to supply the parent and set that in the samples...
-----Original Message-----
From: Kevin Brown [mailto:etnu@google.com]
Sent: Tue 3/4/2008 1:06 AM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Yes, that would work, but it makes testing and development very difficult --
which is why the parent parameter is used in the first place. The problem is
that you're not passing the parent parameter to the iframe url. Changing
that back will resolve the problem.
On Mon, Mar 3, 2008 at 9:23 PM, Paul Lindner <pl...@hi5.com> wrote:
>
> It appears that the problems began with r632712
>
>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?r1=632675&r2=632712&diff_format=h
>
> I edited my syndicator.js file and changed parentRelayUrl to be absolute
> and everything started to work:
>
> "parentRelayUrl" : "
> http://www.inuus.com:8080/gadgets/files/container/rpc_relay.html"
>
> I'll see if I can come up with a better general solution...
>
>
> -----Original Message-----
> From: Kevin Brown [mailto:etnu@google.com]
> Sent: Mon 3/3/2008 6:45 PM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r633353 -
> /incubator/shindig/trunk/javascript/container/gadgets.js
>
> Hey Paul,
>
> One of these recent changes seems to have broken all the sample files --
> gadgets.js is no longer providing default values for parent, which is
> making
> rpc calls fail. Can you take a look?
>
> On Mon, Mar 3, 2008 at 6:40 PM, <li...@apache.org> wrote:
>
> > Author: lindner
> > Date: Mon Mar 3 18:40:35 2008
> > New Revision: 633353
> >
> > URL: http://svn.apache.org/viewvc?rev=633353&view=rev
> > Log:
> > add a debug option to get js without compression, fix class/id problem
> for
> > SHINDIG-105
> >
> > Modified:
> > incubator/shindig/trunk/javascript/container/gadgets.js
> >
> > Modified: incubator/shindig/trunk/javascript/container/gadgets.js
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
> >
> >
> ==============================================================================
> > --- incubator/shindig/trunk/javascript/container/gadgets.js (original)
> > +++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3
> > 18:40:35 2008
> > @@ -362,6 +362,8 @@
> > * "title": the default title to use for the title bar.
> > * "height": height of the gadget
> > * "width": width of the gadget
> > + * "debug": send debug=1 to the gadget server, gets us uncompressed
> > + * javascript
> > */
> > gadgets.Gadget = function(params) {
> > this.userPrefs_ = {};
> > @@ -465,7 +467,7 @@
> >
> > gadgets.IfrGadget.prototype.getTitleBarContent = function(continuation)
> {
> > continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
> > - 'class="' + this.cssClassTitleBar + '"><span id="' +
> > + '" class="' + this.cssClassTitleBar + '"><span id="' +
> > this.getIframeId() + '_title" class="' +
> > this.cssClassTitle + '">' + (this.title ? this.title : 'Title') +
> > '</span> | <span class="' +
> > this.cssClassTitleButtonBar +
> > @@ -519,7 +521,8 @@
> > '&country=' + gadgets.container.country_ +
> > '&lang=' + gadgets.container.language_ +
> > '&view=' + gadgets.container.view_ +
> > - this.getUserPrefsParams() +
> > + (this.debug ? '&debug=1' : '') +
> > + this.getUserPrefsParams() +
> > '#rpctoken=' + this.rpcToken +
> > (this.secureToken ? '&st=' + (this.secureToken || "") : '') +
> > (this.viewParams ?
> >
> >
> >
>
>
> --
> ~Kevin
>
>
--
~Kevin
Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Kevin Brown <et...@google.com>.
Yes, that would work, but it makes testing and development very difficult --
which is why the parent parameter is used in the first place. The problem is
that you're not passing the parent parameter to the iframe url. Changing
that back will resolve the problem.
On Mon, Mar 3, 2008 at 9:23 PM, Paul Lindner <pl...@hi5.com> wrote:
>
> It appears that the problems began with r632712
>
>
> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?r1=632675&r2=632712&diff_format=h
>
> I edited my syndicator.js file and changed parentRelayUrl to be absolute
> and everything started to work:
>
> "parentRelayUrl" : "
> http://www.inuus.com:8080/gadgets/files/container/rpc_relay.html"
>
> I'll see if I can come up with a better general solution...
>
>
> -----Original Message-----
> From: Kevin Brown [mailto:etnu@google.com]
> Sent: Mon 3/3/2008 6:45 PM
> To: shindig-dev@incubator.apache.org
> Subject: Re: svn commit: r633353 -
> /incubator/shindig/trunk/javascript/container/gadgets.js
>
> Hey Paul,
>
> One of these recent changes seems to have broken all the sample files --
> gadgets.js is no longer providing default values for parent, which is
> making
> rpc calls fail. Can you take a look?
>
> On Mon, Mar 3, 2008 at 6:40 PM, <li...@apache.org> wrote:
>
> > Author: lindner
> > Date: Mon Mar 3 18:40:35 2008
> > New Revision: 633353
> >
> > URL: http://svn.apache.org/viewvc?rev=633353&view=rev
> > Log:
> > add a debug option to get js without compression, fix class/id problem
> for
> > SHINDIG-105
> >
> > Modified:
> > incubator/shindig/trunk/javascript/container/gadgets.js
> >
> > Modified: incubator/shindig/trunk/javascript/container/gadgets.js
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
> >
> >
> ==============================================================================
> > --- incubator/shindig/trunk/javascript/container/gadgets.js (original)
> > +++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3
> > 18:40:35 2008
> > @@ -362,6 +362,8 @@
> > * "title": the default title to use for the title bar.
> > * "height": height of the gadget
> > * "width": width of the gadget
> > + * "debug": send debug=1 to the gadget server, gets us uncompressed
> > + * javascript
> > */
> > gadgets.Gadget = function(params) {
> > this.userPrefs_ = {};
> > @@ -465,7 +467,7 @@
> >
> > gadgets.IfrGadget.prototype.getTitleBarContent = function(continuation)
> {
> > continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
> > - 'class="' + this.cssClassTitleBar + '"><span id="' +
> > + '" class="' + this.cssClassTitleBar + '"><span id="' +
> > this.getIframeId() + '_title" class="' +
> > this.cssClassTitle + '">' + (this.title ? this.title : 'Title') +
> > '</span> | <span class="' +
> > this.cssClassTitleButtonBar +
> > @@ -519,7 +521,8 @@
> > '&country=' + gadgets.container.country_ +
> > '&lang=' + gadgets.container.language_ +
> > '&view=' + gadgets.container.view_ +
> > - this.getUserPrefsParams() +
> > + (this.debug ? '&debug=1' : '') +
> > + this.getUserPrefsParams() +
> > '#rpctoken=' + this.rpcToken +
> > (this.secureToken ? '&st=' + (this.secureToken || "") : '') +
> > (this.viewParams ?
> >
> >
> >
>
>
> --
> ~Kevin
>
>
--
~Kevin
RE: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Paul Lindner <pl...@hi5.com>.
It appears that the problems began with r632712
http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?r1=632675&r2=632712&diff_format=h
I edited my syndicator.js file and changed parentRelayUrl to be absolute and everything started to work:
"parentRelayUrl" : "http://www.inuus.com:8080/gadgets/files/container/rpc_relay.html"
I'll see if I can come up with a better general solution...
-----Original Message-----
From: Kevin Brown [mailto:etnu@google.com]
Sent: Mon 3/3/2008 6:45 PM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Hey Paul,
One of these recent changes seems to have broken all the sample files --
gadgets.js is no longer providing default values for parent, which is making
rpc calls fail. Can you take a look?
On Mon, Mar 3, 2008 at 6:40 PM, <li...@apache.org> wrote:
> Author: lindner
> Date: Mon Mar 3 18:40:35 2008
> New Revision: 633353
>
> URL: http://svn.apache.org/viewvc?rev=633353&view=rev
> Log:
> add a debug option to get js without compression, fix class/id problem for
> SHINDIG-105
>
> Modified:
> incubator/shindig/trunk/javascript/container/gadgets.js
>
> Modified: incubator/shindig/trunk/javascript/container/gadgets.js
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/javascript/container/gadgets.js (original)
> +++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3
> 18:40:35 2008
> @@ -362,6 +362,8 @@
> * "title": the default title to use for the title bar.
> * "height": height of the gadget
> * "width": width of the gadget
> + * "debug": send debug=1 to the gadget server, gets us uncompressed
> + * javascript
> */
> gadgets.Gadget = function(params) {
> this.userPrefs_ = {};
> @@ -465,7 +467,7 @@
>
> gadgets.IfrGadget.prototype.getTitleBarContent = function(continuation) {
> continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
> - 'class="' + this.cssClassTitleBar + '"><span id="' +
> + '" class="' + this.cssClassTitleBar + '"><span id="' +
> this.getIframeId() + '_title" class="' +
> this.cssClassTitle + '">' + (this.title ? this.title : 'Title') +
> '</span> | <span class="' +
> this.cssClassTitleButtonBar +
> @@ -519,7 +521,8 @@
> '&country=' + gadgets.container.country_ +
> '&lang=' + gadgets.container.language_ +
> '&view=' + gadgets.container.view_ +
> - this.getUserPrefsParams() +
> + (this.debug ? '&debug=1' : '') +
> + this.getUserPrefsParams() +
> '#rpctoken=' + this.rpcToken +
> (this.secureToken ? '&st=' + (this.secureToken || "") : '') +
> (this.viewParams ?
>
>
>
--
~Kevin
RE: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Paul Lindner <pl...@hi5.com>.
My fault for only checking samples with FF3. I'll get right on this.
-----Original Message-----
From: Kevin Brown [mailto:etnu@google.com]
Sent: Mon 3/3/2008 6:45 PM
To: shindig-dev@incubator.apache.org
Subject: Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Hey Paul,
One of these recent changes seems to have broken all the sample files --
gadgets.js is no longer providing default values for parent, which is making
rpc calls fail. Can you take a look?
Re: svn commit: r633353 - /incubator/shindig/trunk/javascript/container/gadgets.js
Posted by Kevin Brown <et...@google.com>.
Hey Paul,
One of these recent changes seems to have broken all the sample files --
gadgets.js is no longer providing default values for parent, which is making
rpc calls fail. Can you take a look?
On Mon, Mar 3, 2008 at 6:40 PM, <li...@apache.org> wrote:
> Author: lindner
> Date: Mon Mar 3 18:40:35 2008
> New Revision: 633353
>
> URL: http://svn.apache.org/viewvc?rev=633353&view=rev
> Log:
> add a debug option to get js without compression, fix class/id problem for
> SHINDIG-105
>
> Modified:
> incubator/shindig/trunk/javascript/container/gadgets.js
>
> Modified: incubator/shindig/trunk/javascript/container/gadgets.js
> URL:
> http://svn.apache.org/viewvc/incubator/shindig/trunk/javascript/container/gadgets.js?rev=633353&r1=633352&r2=633353&view=diff
>
> ==============================================================================
> --- incubator/shindig/trunk/javascript/container/gadgets.js (original)
> +++ incubator/shindig/trunk/javascript/container/gadgets.js Mon Mar 3
> 18:40:35 2008
> @@ -362,6 +362,8 @@
> * "title": the default title to use for the title bar.
> * "height": height of the gadget
> * "width": width of the gadget
> + * "debug": send debug=1 to the gadget server, gets us uncompressed
> + * javascript
> */
> gadgets.Gadget = function(params) {
> this.userPrefs_ = {};
> @@ -465,7 +467,7 @@
>
> gadgets.IfrGadget.prototype.getTitleBarContent = function(continuation) {
> continuation('<div id="' + this.cssClassTitleBar + '-' + this.id +
> - 'class="' + this.cssClassTitleBar + '"><span id="' +
> + '" class="' + this.cssClassTitleBar + '"><span id="' +
> this.getIframeId() + '_title" class="' +
> this.cssClassTitle + '">' + (this.title ? this.title : 'Title') +
> '</span> | <span class="' +
> this.cssClassTitleButtonBar +
> @@ -519,7 +521,8 @@
> '&country=' + gadgets.container.country_ +
> '&lang=' + gadgets.container.language_ +
> '&view=' + gadgets.container.view_ +
> - this.getUserPrefsParams() +
> + (this.debug ? '&debug=1' : '') +
> + this.getUserPrefsParams() +
> '#rpctoken=' + this.rpcToken +
> (this.secureToken ? '&st=' + (this.secureToken || "") : '') +
> (this.viewParams ?
>
>
>
--
~Kevin