You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/11/16 23:30:47 UTC
zeppelin git commit: Fix typo (isNotebokPublic -> isNotebookPublic)
Repository: zeppelin
Updated Branches:
refs/heads/master 717a8c1e7 -> 71a019e8b
Fix typo (isNotebokPublic -> isNotebookPublic)
### What is this PR for?
Fix typo (isNotebokPublic -> isNotebookPublic)
### What type of PR is it?
[Refactoring]
### Todos
### What is the Jira issue?
### How should this be tested?
* By unit tests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.
Author: Keiji Yoshida <kj...@gmail.com>
Closes #2672 from kjmrknsn/feature/fix-typo and squashes the following commits:
c131dd9 [Keiji Yoshida] Fix typo (isNotebokPublic -> isNotebookPublic)
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/71a019e8
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/71a019e8
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/71a019e8
Branch: refs/heads/master
Commit: 71a019e8b5242766bb722a8d429c6955c292fd88
Parents: 717a8c1
Author: Keiji Yoshida <kj...@gmail.com>
Authored: Thu Nov 16 01:30:29 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Thu Nov 16 15:30:43 2017 -0800
----------------------------------------------------------------------
.../java/org/apache/zeppelin/conf/ZeppelinConfiguration.java | 2 +-
.../java/org/apache/zeppelin/notebook/NotebookAuthorization.java | 2 +-
.../java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java | 2 +-
.../src/test/java/org/apache/zeppelin/notebook/NotebookTest.java | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/71a019e8/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
----------------------------------------------------------------------
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
index f45e27b..f234ed4 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
@@ -500,7 +500,7 @@ public class ZeppelinConfiguration extends XMLConfiguration {
return getBoolean(ConfVars.ZEPPELIN_ANONYMOUS_ALLOWED);
}
- public boolean isNotebokPublic() {
+ public boolean isNotebookPublic() {
return getBoolean(ConfVars.ZEPPELIN_NOTEBOOK_PUBLIC);
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/71a019e8/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java
index 5f0f066..5cf8192 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NotebookAuthorization.java
@@ -158,7 +158,7 @@ public class NotebookAuthorization {
}
public boolean isPublic() {
- return conf.isNotebokPublic();
+ return conf.isNotebookPublic();
}
private Set<String> validateUser(Set<String> users) {
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/71a019e8/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java
index 3cc1022..58b5eda 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java
@@ -94,7 +94,7 @@ public class ZeppelinConfigurationTest {
public void isNotebookPublicTest() throws ConfigurationException {
ZeppelinConfiguration conf = new ZeppelinConfiguration(this.getClass().getResource("/zeppelin-site.xml"));
- boolean isIt = conf.isNotebokPublic();
+ boolean isIt = conf.isNotebookPublic();
assertTrue(isIt);
}
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/71a019e8/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
index 77eb4e5..511b4e5 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
@@ -1130,7 +1130,7 @@ public class NotebookTest extends AbstractInterpreterTest implements JobListener
HashSet<String> user2 = Sets.newHashSet("user2");
// case of public note
- assertTrue(conf.isNotebokPublic());
+ assertTrue(conf.isNotebookPublic());
assertTrue(notebookAuthorization.isPublic());
List<Note> notes1 = notebook.getAllNotes(user1);
@@ -1158,7 +1158,7 @@ public class NotebookTest extends AbstractInterpreterTest implements JobListener
// case of private note
System.setProperty(ConfVars.ZEPPELIN_NOTEBOOK_PUBLIC.getVarName(), "false");
ZeppelinConfiguration conf2 = ZeppelinConfiguration.create();
- assertFalse(conf2.isNotebokPublic());
+ assertFalse(conf2.isNotebookPublic());
// notebook authorization reads from conf, so no need to re-initilize
assertFalse(notebookAuthorization.isPublic());