You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by alexott <gi...@git.apache.org> on 2018/06/18 18:23:30 UTC
[GitHub] zeppelin pull request #3029: ZEPPELIN-621 - Bump Java version to Java 8
GitHub user alexott opened a pull request:
https://github.com/apache/zeppelin/pull/3029
ZEPPELIN-621 - Bump Java version to Java 8
### What is this PR for?
This PR switches the project to use Java 8 - we already have dependency on Spark 2.2.0 that is Java 8+ only.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-621
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexott/zeppelin ZEPPELIN-621
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3029.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3029
----
commit 07e80bb219e5a4b1cccce0da66920ef3b05d6c47
Author: Alex Ott <al...@...>
Date: 2018-06-17T14:38:05Z
bump Java to 1.8
commit 764bd341712e926ae326ae69058730b2cac87c5f
Author: Alex Ott <al...@...>
Date: 2018-06-18T18:15:23Z
update Vagrant to 16.04 + Java 8
commit 51b9eccfba69c2c46d7a189cd8ce10a8c487a74d
Author: Alex Ott <al...@...>
Date: 2018-06-18T18:15:35Z
Mention Java 8 as dependency
----
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3029
@alexott Travis fails, could you help check that ?
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by alexott <gi...@git.apache.org>.
Github user alexott commented on the issue:
https://github.com/apache/zeppelin/pull/3029
Ok, it looks like it's working now, but really not sure what was wrong with configuration...
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3029
Wow~~ Now, we can use JDK8's wonderful features!!!! GREAT!!
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3029
We also need to update .travis.yml to use only java 8
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3029
You need to first rebase your PR ( I disable some flaky test recently).
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3029
I have a simple question. Is `Vargrant` related to JDK8 directly?
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by alexott <gi...@git.apache.org>.
Github user alexott commented on the issue:
https://github.com/apache/zeppelin/pull/3029
@jongyoul JDK is configured there as well, so I was going to change it everywhere, so people who develop using Vagrant, won't get problems...
---
[GitHub] zeppelin pull request #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3029
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3029
@alexott The last build in travis fails, could you rerun it ?
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3029
There's still some flaky test that may fails due to networks issue or other issues.
LGTM
---
[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8
Posted by alexott <gi...@git.apache.org>.
Github user alexott commented on the issue:
https://github.com/apache/zeppelin/pull/3029
@zjffdu I forgot to enable CI, and test is now running, although some tests are failed - will investigate over weekend...
---