You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "cdfive (GitHub)" <gi...@apache.org> on 2018/12/27 06:05:01 UTC

[GitHub] [incubator-dubbo] cdfive commented on issue #3076: [Dubbo-3069] Fix NumberFormatException for input string ""

Hi, @zhaixiaoxiang 

``` 
if (type == char.class || type == Character.class) {
    return value.length() > 0 ? value.charAt(0) : '\0';
}
```

Return '\0' may be confusing.

How about put the `if StringUtils.isRealBlank(value)` in the first line of this method?
But be careful if the '\0' is used.




[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3076 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org