[GitHub] [incubator-doris] spaces-X commented on a change in pull request #5347: Fix bug that sql with limit query statistics are wrong

[GitBox <gi...@apache.org>]

spaces-X commented on a change in pull request #5347:
URL: https://github.com/apache/incubator-doris/pull/5347#discussion_r589919508



##########
File path: be/src/runtime/query_statistics.cpp
##########
@@ -33,7 +33,7 @@ void QueryStatisticsRecvr::insert(const PQueryStatistics& statistics, int sender
     } else {
         query_statistics = iter->second;
     }
-    query_statistics->merge_pb(statistics);
+    query_statistics->from_pb(statistics);

Review comment:
       The query statistics such as scan_rows refers to ```RuntimeProfile::Counter _raw_rows_counter``` have been already accumlated in counter and the values in query statistics are not delta.
   The query statistics sent by different senders should be merged in Exchange Nodes. 
   However, the query statistics sent by the same sender why should we merge them here.
   If merged, the query statistics will be enlarged by repeat accumulation when sql with limit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org