You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by bz...@apache.org on 2016/11/09 04:04:30 UTC

zeppelin git commit: Shorten certain error logs in order to keep CI logs clear

Repository: zeppelin
Updated Branches:
  refs/heads/master 865d10f19 -> 0758b7078


Shorten certain error logs in order to keep CI logs clear

### What is this PR for?
This is to shorten certain error logs in order to keep CI clear without polluted logs.

### What type of PR is it?
Improvement

### Todos
* [x] - shorter error log

### What is the Jira issue?
N/A

### How should this be tested?
CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

not to polute logs

Author: Khalid Huseynov <kh...@gmail.com>

Closes #1597 from khalidhuseynov/fix/log-shorten-ci-nonpollution and squashes the following commits:

0ba4cea [Khalid Huseynov] shorten logs on certain errrors


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0758b707
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0758b707
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0758b707

Branch: refs/heads/master
Commit: 0758b707869ff81b70dd845ccdaa017356968e6b
Parents: 865d10f
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Fri Nov 4 20:20:21 2016 +0900
Committer: Alexander Bezzubov <bz...@apache.org>
Committed: Wed Nov 9 13:04:19 2016 +0900

----------------------------------------------------------------------
 .../notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java   | 2 +-
 .../repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java   | 4 ++--
 .../zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0758b707/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java
index c4179b8..b7a87ad 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/ZeppelinhubClient.java
@@ -138,7 +138,7 @@ public class ZeppelinhubClient {
       Session session = future.get();
       zeppelinSession = ZeppelinhubSession.createInstance(session, zeppelinhubToken);
     } catch (IOException | InterruptedException | ExecutionException e) {
-      LOG.info("Couldnt connect to zeppelinhub", e);
+      LOG.info("Couldnt connect to zeppelinhub - {}", e.toString());
       zeppelinSession = ZeppelinhubSession.EMPTY;
     }
     return zeppelinSession;

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0758b707/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java
index facfcab..ac102b5 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinWebsocket.java
@@ -54,7 +54,7 @@ public class ZeppelinWebsocket implements WebSocketListener {
 
   @Override
   public void onWebSocketError(Throwable e) {
-    LOG.warn("Zeppelin socket connection error ", e);
+    LOG.warn("Zeppelin socket connection error: {}", e.toString());
   }
 
   @Override
@@ -67,7 +67,7 @@ public class ZeppelinWebsocket implements WebSocketListener {
         zeppelinClient.handleMsgFromZeppelin(data, noteId);
       }
     } catch (Exception e) {
-      LOG.error("Failed to send message to ZeppelinHub: ", e);
+      LOG.error("Failed to send message to ZeppelinHub: {}", e.toString());
     }
   }
 

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0758b707/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java
index e28054a..216c307 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/zeppelinhub/websocket/listener/ZeppelinhubWebsocket.java
@@ -58,7 +58,7 @@ public class ZeppelinhubWebsocket implements WebSocketListener {
 
   @Override
   public void onWebSocketError(Throwable cause) {
-    LOG.error("Got error", cause);
+    LOG.error("Remote websocket error");
   }
 
   @Override