[GitHub] [ozone] captainzmc commented on a change in pull request #1677: HDDS-4562. Old bucket needs to be accessible after the cluster was upgraded to the Quota version.

[GitBox <gi...@apache.org>]

captainzmc commented on a change in pull request #1677:
URL: https://github.com/apache/ozone/pull/1677#discussion_r543018536



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -291,9 +291,10 @@ public boolean setVolumeOwner(String volumeName, String owner)
   public void setVolumeQuota(String volumeName, long quotaInCounts,
       long quotaInBytes) throws IOException {
     HddsClientUtils.verifyResourceName(volumeName);
-    verifyCountsQuota(quotaInCounts);
-    verifySpaceQuota(quotaInBytes);
-    ozoneManagerClient.setQuota(volumeName, quotaInCounts, quotaInBytes);
+    verifyCountsQuota(getQuotaValue(quotaInCounts));

Review comment:
       This check simply ensures that when we use RpcClient set Quota, the value of quota must be legal (not less than -1). But the getQuotaValue conversion step inside is redundant,  I‘ll  delete this conversion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org