You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 03:28:18 UTC

[GitHub] [pulsar] labuladong opened a new pull request, #17533: remove `This example uses Pulsar x.x.x`

labuladong opened a new pull request, #17533:
URL: https://github.com/apache/pulsar/pull/17533

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   
   
   Fixes [comment in #17499 ](https://github.com/apache/pulsar/pull/17499#issuecomment-1239161837)
   
   
   
   
   ### Modifications
   
   Remove redundant `This example uses Pulsar x.x.x`
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   
   cc @Anonymitaet @tisonkun @momo-jun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17533: remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17533:
URL: https://github.com/apache/pulsar/pull/17533#discussion_r965525735


##########
site2/docs/tiered-storage-aws.md:
##########
@@ -14,7 +14,7 @@ Follow the steps below to install the AWS S3 offloader.
 
 - Pulsar: 2.4.2 or later versions
 
-This example uses Pulsar 2.5.1.
+### Step

Review Comment:
   ```suggestion
   ### Steps
   ```



##########
site2/docs/tiered-storage-azure.md:
##########
@@ -14,7 +14,7 @@ Follow the steps below to install the Azure BlobStore offloader.
 
 - Pulsar: 2.6.2 or later versions
 
-This example uses Pulsar 2.6.2.
+### Step

Review Comment:
   ```suggestion
   ### Steps
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] labuladong commented on pull request #17533: [fix][doc] remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #17533:
URL: https://github.com/apache/pulsar/pull/17533#issuecomment-1240370615

   
   > LGTM. @labuladong can you pls also add [fix][doc] in the PR title to align with the naming conventions?
   
   Done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17533: remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17533:
URL: https://github.com/apache/pulsar/pull/17533#discussion_r965525856


##########
site2/docs/tiered-storage-filesystem.md:
##########
@@ -20,7 +20,7 @@ This section describes how to install the filesystem offloader.
 
 - Pulsar: 2.4.2 or higher versions
 
-This example uses Pulsar 2.5.1.
+### Step

Review Comment:
   ```suggestion
   ### Steps
   ```



##########
site2/docs/tiered-storage-gcs.md:
##########
@@ -14,7 +14,7 @@ Follow the steps below to install the GCS offloader.
 
 - Pulsar: 2.4.2 or later versions
 
-This example uses Pulsar 2.5.1.
+### Step

Review Comment:
   ```suggestion
   ### Steps
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun merged pull request #17533: [fix][doc] remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
momo-jun merged PR #17533:
URL: https://github.com/apache/pulsar/pull/17533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17533: remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17533:
URL: https://github.com/apache/pulsar/pull/17533#discussion_r965525608


##########
site2/docs/tiered-storage-aliyun.md:
##########
@@ -14,7 +14,7 @@ Follow the steps below to install the Aliyun OSS offloader.
 
 - Pulsar: 2.8.0 or later versions
 
-This example uses Pulsar 2.8.0.
+### Step

Review Comment:
   ```suggestion
   ### Steps
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] labuladong commented on pull request #17533: [fix][doc] remove `This example uses Pulsar x.x.x`

Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #17533:
URL: https://github.com/apache/pulsar/pull/17533#issuecomment-1241526512

   All tests passed. Could you help to merge this pr? @Anonymitaet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org