You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/02/23 11:58:58 UTC

Re: Review Request 43859: Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43859/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 10:58 a.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
-------

Fixed summary, added shepherd - as explained in our documentation (docs/submitting-a-patch.md). Also tested this patch and added this to the "Testing Done" section.


Summary (updated)
-----------------

Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.


Bugs: MESOS-4602
    https://issues.apache.org/jira/browse/MESOS-4602


Repository: mesos


Description (updated)
-------

see above.


Diffs
-----

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 5a987ea04ce8f1ebab8e1cc1d796e5243532271d 

Diff: https://reviews.apache.org/r/43859/diff/


Testing (updated)
-------

make check


Thanks,

Yong Tang


Re: Review Request 43859: Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43859/#review120316
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Feb. 23, 2016, 10:58 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43859/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 10:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-4602
>     https://issues.apache.org/jira/browse/MESOS-4602
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see above.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 5a987ea04ce8f1ebab8e1cc1d796e5243532271d 
> 
> Diff: https://reviews.apache.org/r/43859/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Re: Review Request 43859: Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43859/#review120315
-----------------------------------------------------------


Ship it!




- Benjamin Bannier


On Feb. 23, 2016, 11:58 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43859/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-4602
>     https://issues.apache.org/jira/browse/MESOS-4602
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see above.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 5a987ea04ce8f1ebab8e1cc1d796e5243532271d 
> 
> Diff: https://reviews.apache.org/r/43859/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>