You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/01/30 10:28:11 UTC

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19455


Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................

IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled

This fixes a script error of unbound variable when running the mini
cluster on Ozone with ERASURE_CODING=false. In such case,
OZONE_ERASURECODE_POLICY is not set in bin/impala-config.sh. Adds a
default empty string when using it.

Tests:
 - Verified CORE tests can run with TARGET_FILESYSTEM=ozone and
   ERASURE_CODING=false.

Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
---
M testdata/cluster/admin
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/19455/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12262/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 10:47:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 23:11:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................


Patch Set 1: Code-Review+2

Oops, thanks for fixing that!


-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:57:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:59:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8998/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:59:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11873: Fix unbound variable of OZONE ERASURECODE POLICY when EC is diabled

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19455 )

Change subject: IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled
......................................................................

IMPALA-11873: Fix unbound variable of OZONE_ERASURECODE_POLICY when EC is diabled

This fixes a script error of unbound variable when running the mini
cluster on Ozone with ERASURE_CODING=false. In such case,
OZONE_ERASURECODE_POLICY is not set in bin/impala-config.sh. Adds a
default empty string when using it.

Tests:
 - Verified CORE tests can run with TARGET_FILESYSTEM=ozone and
   ERASURE_CODING=false.

Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Reviewed-on: http://gerrit.cloudera.org:8080/19455
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/admin
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4c50653ec7e317c3246055adc50d4dd99272173
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>