[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9460: pylint: accept specific 2 character names by default

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9460: pylint: accept specific 2 character names by default
URL: https://github.com/apache/incubator-superset/pull/9460#discussion_r404873107
 
 

 ##########
 File path: .pylintrc
 ##########
 @@ -115,10 +115,10 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
 [BASIC]
 
 # Good variable names which should always be accepted, separated by a comma
-good-names=i,j,k,ex,Run,_,d,e,v,o,l,x,ts,f
+good-names=_,d,df,e,ex,f,i,id,j,k,l,o,pk,Run,ts,v,x
 
 # Bad variable names which should always be refused, separated by a comma
-bad-names=foo,bar,baz,toto,tutu,tata,d,fd
+bad-names=d,fd,foo,bar,baz,toto,tutu,tata
 
 Review comment:
   How is `d` both a good and bad name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org