You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2021/04/02 00:59:25 UTC

[tinkerpop] branch travis-fix updated (b455683 -> 0ed1ab8)

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


 discard b455683  Added some logging to try to isolate what travis is failing on.
     new 0ed1ab8  Added some logging to try to isolate what travis is failing on.

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (b455683)
            \
             N -- N -- N   refs/heads/travis-fix (0ed1ab8)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

[tinkerpop] 01/01: Added some logging to try to isolate what travis is failing on.

Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit 0ed1ab86e878a984a7cc46c0b8567e70d2e70841
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Thu Apr 1 13:58:49 2021 -0400

    Added some logging to try to isolate what travis is failing on.
---
 .travis.yml                                                 |  4 ++--
 .../gremlin/server/GremlinDriverIntegrateTest.java          | 13 +++++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index ff3a058..671da5f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,7 +60,7 @@ jobs:
       name: "gremlin server"
     - script:
         - "mvn clean install -q -DskipTests -Dci"
-        - "travis_wait 60 mvn verify -pl :gremlin-server -DskipTests -DskipIntegrationTests=false -DincludeNeo4j -DtestUnified=true"
+        - "mvn verify -pl :gremlin-server -DskipTests -DskipIntegrationTests=false -DincludeNeo4j -DtestUnified=true"
       name: "gremlin server - unified"
     - script:
         - "mvn clean install -q -DskipTests -Dci"
@@ -68,7 +68,7 @@ jobs:
       name: "gremlin console"
     - script:
       - "mvn clean install -q -DskipTests -Dci"
-      - "travis_wait 60 mvn verify -pl :spark-gremlin -DskipTests -DskipIntegrationTests=false '-Dit.test=*IntegrateTest,!SparkGryoSerializerGraphComputerProcessIntegrateTest'"
+      - "mvn verify -pl :spark-gremlin -DskipTests -DskipIntegrationTests=false '-Dit.test=*IntegrateTest,!SparkGryoSerializerGraphComputerProcessIntegrateTest'"
       name: "spark - core"
     - script:
       - "mvn clean install -q -DskipTests -Dci"
diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
index 7e09c95..35b336b 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
@@ -113,8 +113,14 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
     private Log4jRecordingAppender recordingAppender = null;
     private Level previousLogLevel;
 
+    static {
+        final org.apache.log4j.Logger testLogger = org.apache.log4j.Logger.getLogger(GremlinDriverIntegrateTest.class);
+        testLogger.setLevel(Level.INFO);
+    }
+
     @Before
     public void setupForEachTest() {
+        logger.info("STARTING: " + name.getMethodName());
         recordingAppender = new Log4jRecordingAppender();
         final org.apache.log4j.Logger rootLogger = org.apache.log4j.Logger.getRootLogger();
 
@@ -146,6 +152,8 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
         }
 
         rootLogger.removeAppender(recordingAppender);
+
+        logger.info("STOPPING: " + name.getMethodName());
     }
 
     /**
@@ -155,6 +163,11 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
     public Settings overrideSettings(final Settings settings) {
         final String nameOfTest = name.getMethodName();
 
+        // need to initialize pool to something bigger than what Travis has for available cores
+        // as we often need at least 3 threads in the pool to let these tests pass. not sure what
+        // the top number is but 8 seems to do the trick
+        settings.gremlinPool = 8;
+
         switch (nameOfTest) {
             case "shouldAliasTraversalSourceVariables":
             case "shouldAliasTraversalSourceVariablesInSession":