[GitHub] [pinot] navina commented on a diff in pull request #11017: Remove support for High level consumers in Apache Pinot

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1273922540


##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -501,6 +494,28 @@ protected void configure() {
 
     LOGGER.info("Starting controller admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs));
     _adminApp.start(_listenerConfigs);
+    List<String> existingHlcTables = new ArrayList<>();
+    _helixResourceManager.getAllRealtimeTables().forEach(rt -> {
+      TableConfig tableConfig = _helixResourceManager.getTableConfig(rt);
+      if (tableConfig != null) {
+        Map<String, String> streamConfigMap = IngestionConfigUtils.getStreamConfigMap(tableConfig);

Review Comment:
   In the past, I have been recommended to use `IngestionConfigUtils.getStreamConfigMap` which searches for configs in 2 places - TableConfig#IngestionConfig and TableConfig#IndexingConfig. Likely due for compatibility reasons. 
   We should fix that separately (if not already) - re-write existing table configs to move stream configs from indexConfig into IngestionConfig. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org