You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by ck...@apache.org on 2018/01/09 12:47:48 UTC
svn commit: r1820657 -
/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Author: ckoell
Date: Tue Jan 9 12:47:47 2018
New Revision: 1820657
URL: http://svn.apache.org/viewvc?rev=1820657&view=rev
Log:
Debug Log on LinkageError
Modified:
jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java?rev=1820657&r1=1820656&r2=1820657&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java Tue Jan 9 12:47:47 2018
@@ -187,6 +187,14 @@ public class LazyTextExtractorField exte
// not being present. This is equivalent to disabling
// selected media types in configuration, so we can simply
// ignore these errors.
+ if (!writeOutContentHandler.isWriteLimitReached(e)) {
+ log.debug("Failed to extract text from a binary property."
+ + " This is a fairly common case, and nothing to"
+ + " worry about. The stack trace is included to"
+ + " help improve the text extraction feature.", e);
+ setExtractedText("TextExtractionError");
+ return;
+ }
} catch (Throwable t) {
// Capture and report any other full text extraction problems.
// The special STOP exception is used for normal termination.
Fwd: svn commit: r1820657 -
/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Posted by Julian Reschke <ju...@gmx.de>.
Claus,
could you please open a JIRA ticket for these improvements and link the
commits to it?
Best regards, Julian
-------- Forwarded Message --------
Subject: svn commit: r1820657 -
/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Date: Tue, 09 Jan 2018 12:47:48 -0000
From: ckoell@apache.org
Reply-To: dev@jackrabbit.apache.org
To: commits@jackrabbit.apache.org
Author: ckoell
Date: Tue Jan 9 12:47:47 2018
New Revision: 1820657
URL: http://svn.apache.org/viewvc?rev=1820657&view=rev
Log:
Debug Log on LinkageError
Modified:
jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Modified:
jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
URL:
http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java?rev=1820657&r1=1820656&r2=1820657&view=diff
==============================================================================
---
jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
(original)
+++
jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/LazyTextExtractorField.java
Tue Jan 9 12:47:47 2018
@@ -187,6 +187,14 @@ public class LazyTextExtractorField exte
// not being present. This is equivalent to disabling
// selected media types in configuration, so we can simply
// ignore these errors.
+ if (!writeOutContentHandler.isWriteLimitReached(e)) {
+ log.debug("Failed to extract text from a binary
property."
+ + " This is a fairly common case, and
nothing to"
+ + " worry about. The stack trace is
included to"
+ + " help improve the text extraction
feature.", e);
+ setExtractedText("TextExtractionError");
+ return;
+ }
} catch (Throwable t) {
// Capture and report any other full text extraction
problems.
// The special STOP exception is used for normal
termination.