You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/04/18 07:22:19 UTC

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1561: MINIFICPP-2103 JNI extension compile fix (libc++)

martinzink opened a new pull request, #1561:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1561

   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1561: MINIFICPP-2103 JNI extension compile fix (libc++)

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez closed pull request #1561: MINIFICPP-2103 JNI extension compile fix (libc++)
URL: https://github.com/apache/nifi-minifi-cpp/pull/1561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1561: MINIFICPP-2103 JNI extension compile fix (libc++)

Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1561:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1561#discussion_r1170994644


##########
extensions/jni/jvm/JniReferenceObjects.h:
##########
@@ -128,8 +128,8 @@ class JniByteInputStream {
     return read;
   }
 
-  int64_t read(uint8_t &arr) {
-    return stream_->read(arr);
+  int64_t read(uint8_t &arr) const {

Review Comment:
   You are absolutely right, changed it in https://github.com/apache/nifi-minifi-cpp/pull/1561/commits/dd896082c79acc2b122a3e74ab36c527f1fee446



##########
extensions/jni/jvm/JniReferenceObjects.h:
##########
@@ -128,8 +128,8 @@ class JniByteInputStream {
     return read;
   }
 
-  int64_t read(uint8_t &arr) {
-    return stream_->read(arr);
+  int64_t read(uint8_t &arr) const {
+    return gsl::narrow<int64_t>(stream_->read(arr));

Review Comment:
   Nice catch, I've added the error check in https://github.com/apache/nifi-minifi-cpp/pull/1561/commits/dd896082c79acc2b122a3e74ab36c527f1fee446



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1561: MINIFICPP-2103 JNI extension compile fix (libc++)

Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1561:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1561#discussion_r1169650365


##########
extensions/jni/jvm/JniReferenceObjects.h:
##########
@@ -128,8 +128,8 @@ class JniByteInputStream {
     return read;
   }
 
-  int64_t read(uint8_t &arr) {
-    return stream_->read(arr);
+  int64_t read(uint8_t &arr) const {

Review Comment:
   also, nitpicking and old code, but it's weird to call a reference-to-byte parameter "arr"



##########
extensions/jni/jvm/JniReferenceObjects.h:
##########
@@ -128,8 +128,8 @@ class JniByteInputStream {
     return read;
   }
 
-  int64_t read(uint8_t &arr) {
-    return stream_->read(arr);
+  int64_t read(uint8_t &arr) const {
+    return gsl::narrow<int64_t>(stream_->read(arr));

Review Comment:
   If `stream_` is a `minifi::io::InputStream`, then `read()` can return `static_cast<size_t>(-1)`, which will cause this to terminate (or return an incorrect value if `size_t` is smaller than 64 bits).  We need to check if the return value `io::isError()`, and return `-1` explicitly in that case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org