You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/14 20:50:56 UTC

[GitHub] [beam] rohdesamuel commented on a change in pull request #17072: [BEAM-14091] Fixing Interactive Beam show/collect for remote runners

rohdesamuel commented on a change in pull request #17072:
URL: https://github.com/apache/beam/pull/17072#discussion_r826366305



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -454,8 +455,12 @@ def record(self, pcolls, max_n, max_duration):
           'options is deprecated since First stable release. References to '
           '<pipeline>.options will not be supported',
           category=DeprecationWarning)
-      pf.PipelineFragment(list(uncomputed_pcolls),

Review comment:
       Can you please add a unit test for asserting that the bug is fixed? It's good practice to add a unit test any time you fix a bug.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org