You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/07/09 02:36:31 UTC
[jira] Created: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
CompositeRecordReader::next is unnecessarily complex
----------------------------------------------------
Key: HADOOP-3721
URL: https://issues.apache.org/jira/browse/HADOOP-3721
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Reporter: Chris Douglas
Fix For: 0.19.0
Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-3721)
CompositeRecordReader::next is unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611859#action_12611859 ]
chris.douglas edited comment on HADOOP-3721 at 7/8/08 5:58 PM:
---------------------------------------------------------------
After discussing it with Runping, it is clear that considerable state may be removed from the JoinCollector without affecting correctness or performance.
was (Author: chris.douglas):
After discussing it with Runping, it is clear that considerable state may be removed from the JoinCollector without affecting correctness or performance.
This patch includes HADOOP-3630.
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Attachment: 3721-0.patch
After discussing it with Runping, it is clear that considerable state may be removed from the JoinCollector without affecting correctness or performance.
This patch includes HADOOP-3630.
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Runping Qi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612686#action_12612686 ]
Runping Qi commented on HADOOP-3721:
------------------------------------
Looks good.
+1.
Runping
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Attachment: (was: 3721-1.patch)
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611974#action_12611974 ]
Hadoop QA commented on HADOOP-3721:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385559/3721-1.patch
against trunk revision 675078.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2828/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2828/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2828/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2828/console
This message is automatically generated.
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas reassigned HADOOP-3721:
-------------------------------------
Assignee: Chris Douglas
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Attachment: 3721-1.patch
Merged with trunk
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Status: Patch Available (was: Open)
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624757#action_12624757 ]
Hudson commented on HADOOP-3721:
--------------------------------
Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3721) CompositeRecordReader::next is
unnecessarily complex
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3721:
----------------------------------
Attachment: 3721-1.patch
> CompositeRecordReader::next is unnecessarily complex
> ----------------------------------------------------
>
> Key: HADOOP-3721
> URL: https://issues.apache.org/jira/browse/HADOOP-3721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 3721-0.patch, 3721-1.patch
>
>
> Much of the join logic can be made more readable and its interfaces cleaned up. In particular, CompositeRecordReader::next would benefit from some refactoring.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.