You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/08 23:10:51 UTC

Review Request 28818: Moved ReservationAllocatorTest.ReservedResources to a unit test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28818/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos-git


Description
-------

This moves ReservationAllocatorTest.ReservedResources into a HierarchicalAllocatorTest.Reservations unit test.

Note that reviewboard cannot display the removal of ReservationAllocatorTest.ReservedResources, because the file was renamed in an earlier review in the chain. See the raw diff.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp PRE-CREATION 
  src/tests/master_allocator_tests.cpp a5eb5286c5555f4445ad43c9bfa454cd8d8d9a7c 

Diff: https://reviews.apache.org/r/28818/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 28818: Moved ReservationAllocatorTest.ReservedResources to a unit test.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28818/#review64598
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28818/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:10 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This moves ReservationAllocatorTest.ReservedResources into a HierarchicalAllocatorTest.Reservations unit test.
> 
> Note that reviewboard cannot display the removal of ReservationAllocatorTest.ReservedResources, because the file was renamed in an earlier review in the chain. See the raw diff.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp PRE-CREATION 
>   src/tests/master_allocator_tests.cpp a5eb5286c5555f4445ad43c9bfa454cd8d8d9a7c 
> 
> Diff: https://reviews.apache.org/r/28818/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>