You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/03 04:00:35 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2062:
fix ZKServer startup error
codecov-io commented on issue #2062: fix ZKServer startup error
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2062#issuecomment-593755701
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=h1) Report
> Merging [#2062](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/34e0a663edbd01995c1e594b3b23a856db7b38a4?src=pr&el=desc) will **increase** coverage by `2.29%`.
> The diff coverage is `62.59%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2062 +/- ##
============================================
+ Coverage 30.84% 33.13% +2.29%
- Complexity 1382 1552 +170
============================================
Files 294 313 +19
Lines 15022 15529 +507
Branches 1810 1886 +76
============================================
+ Hits 4633 5145 +512
+ Misses 9930 9854 -76
- Partials 459 530 +71
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...common/utils/placeholder/TimePlaceholderUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL1RpbWVQbGFjZWhvbGRlclV0aWxzLmphdmE=) | `4.56% <0%> (ø)` | `3 <0> (ø)` | :arrow_down: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `70% <0%> (-7.78%)` | `11 <0> (ø)` | |
| [...er/server/master/runner/MasterSchedulerThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyU2NoZWR1bGVyVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/common/model/DependentItem.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RlcGVuZGVudEl0ZW0uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...lphinscheduler/server/worker/task/TaskManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ler/common/utils/placeholder/PlaceholderUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3BsYWNlaG9sZGVyL1BsYWNlaG9sZGVyVXRpbHMuamF2YQ==) | `66.66% <0%> (ø)` | `3 <0> (ø)` | :arrow_down: |
| [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `57.57% <0%> (ø)` | `13 <0> (ø)` | :arrow_down: |
| [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `31.87% <0%> (ø)` | `16 <0> (ø)` | :arrow_down: |
| ... and [56 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=footer). Last update [34e0a66...d0f0ed4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services