You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/04 17:19:11 UTC
[GitHub] [superset] gbusch opened a new pull request, #21323: fix(dashboard): padding between rows within tabs
gbusch opened a new pull request, #21323:
URL: https://github.com/apache/superset/pull/21323
*Note:* It's the same PR as #20366. However, there were some issues with formatting and the pipelines (mainly because of lacking understanding on my side). So for this few-lines change, I guess it is easier I open a new PR and close the old one, rather than trying to fix the messed up old one...
## SUMMARY
There should be padding between rows in a dashboard. Before, this did not work when the rows where within tabs. This is fixed here.
See this issue: #20303
## BEFORE SCREENSHOT
<img width="1052" alt="173444283-a448a1d8-4217-44ef-998a-64bab1ee42b5" src="https://user-images.githubusercontent.com/16560193/188325508-ac895e15-274a-4656-9435-ec97d6d45457.png">
## AFTER SCREENSHOT
<img width="1052" alt="173444094-e4447879-64d1-494f-bcf3-6ee67ca5ce9a" src="https://user-images.githubusercontent.com/16560193/188325522-752601e9-ed14-484f-82c8-a41ede07c067.png">
## TESTING INSTRUCTIONS
* Insert two charts into a new dashboard
* Add a filter. When hovering over a filter, the selection box shows some space between the plots
* When you move the charts into tabs, there is no space between plots any more (see first screenshot)
* AFTER APPLYING CHANGES FROM PR:
* Now there is also some space when the charts are within tabs (see second screenshot).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #21323: fix(dashboard): padding between rows within tabs
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #21323:
URL: https://github.com/apache/superset/pull/21323#issuecomment-1236386540
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21323: fix(dashboard): padding between rows within tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21323:
URL: https://github.com/apache/superset/pull/21323#issuecomment-1236386603
@stephenLYZ Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21323: fix(dashboard): padding between rows within tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21323:
URL: https://github.com/apache/superset/pull/21323#issuecomment-1236386606
@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21323: fix(dashboard): padding between rows within tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21323:
URL: https://github.com/apache/superset/pull/21323#issuecomment-1236394057
# [Codecov](https://codecov.io/gh/apache/superset/pull/21323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21323](https://codecov.io/gh/apache/superset/pull/21323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4b1b92) into [master](https://codecov.io/gh/apache/superset/commit/79525dfaf29b810af668e3b6c5a56cd866370d92?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79525df) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21323 +/- ##
=======================================
Coverage 66.47% 66.47%
=======================================
Files 1789 1789
Lines 68382 68382
Branches 7276 7276
=======================================
Hits 45455 45455
Misses 21052 21052
Partials 1875 1875
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.50% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #21323: fix(dashboard): padding between rows within tabs
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #21323:
URL: https://github.com/apache/superset/pull/21323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org