You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "hewenting (Code Review)" <ge...@cloudera.org> on 2016/09/01 09:14:24 UTC
[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process
hewenting has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4202
Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process
......................................................................
IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala
process
when starting impala, we have to test num_known_live_backends.
If we set webserver_interface to 127.0.0.1, The webserver can start
well, But cannot get num_known_live_backends due to send request
to http://hostname:25000 .
Here hostname is achieved by calling socket.gethostname(). eg. node1
Fix this by checking whether webserver_interface is set,
if it is set, we will send request to http://webserver_interface:25000,
otherwise send to http://hostname:25000.
Change-Id: Idcc29853b6d5db23b82a7000e0d2b80ac7403f87
---
M be/src/util/webserver-test.cc
M tests/common/impala_cluster.py
M tests/common/impala_service.py
3 files changed, 31 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/4202/1
--
To view, visit http://gerrit.cloudera.org:8080/4202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcc29853b6d5db23b82a7000e0d2b80ac7403f87
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has abandoned this change.
Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process
......................................................................
Abandoned
It looks like this is redundant with https://gerrit.cloudera.org/#/c/4553/. You can restore if that's not the case.
--
To view, visit http://gerrit.cloudera.org:8080/4202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Idcc29853b6d5db23b82a7000e0d2b80ac7403f87
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process
......................................................................
Patch Set 1:
(6 comments)
Sorry for the delay - looks pretty good, just a few small comments.
http://gerrit.cloudera.org:8080/#/c/4202/1/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:
PS1, Line 94: LocalTest
Maybe call this "DefaultInterfaceTest".
http://gerrit.cloudera.org:8080/#/c/4202/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:
Line 207: self.service = ImpaladService(self.hostname, self._get_webserver_interface(default="0.0.0.0"),
long line
Line 234: StateStoredService(self.hostname, self._get_webserver_interface(default="0.0.0.0"),
long line
Line 242: self.service = CatalogdService(self.hostname, self._get_webserver_interface(default="0.0.0.0"),
long line
http://gerrit.cloudera.org:8080/#/c/4202/1/tests/common/impala_service.py
File tests/common/impala_service.py:
Line 47: if self.webserver_interface == "0.0.0.0":
I think this would be more succinct as:
interface = self.webserver_interface if self.webserver_interface != "0.0.0.0" else self.hostname
and then just have one call to urllib.urlopen
Line 214: super(StateStoredService, self).__init__(hostname, webserver_interface, webserver_port)
long line, maybe break after __init__(
--
To view, visit http://gerrit.cloudera.org:8080/4202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcc29853b6d5db23b82a7000e0d2b80ac7403f87
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes