You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/06/20 00:12:41 UTC

[GitHub] [incubator-daffodil] codecov-io commented on issue #240: Add dfdlx:choiceBranchKeyRanges

codecov-io commented on issue #240: Add dfdlx:choiceBranchKeyRanges
URL: https://github.com/apache/incubator-daffodil/pull/240#issuecomment-503791206
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=h1) Report
   > Merging [#240](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-daffodil/commit/113015f72bc675d0f9368f46999afdd24625ea46?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `69.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-daffodil/pull/240/graphs/tree.svg?width=650&token=sXbCnhNQp8&height=150&src=pr)](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #240      +/-   ##
   ==========================================
   + Coverage      80%   80.04%   +0.03%     
   ==========================================
     Files         390      392       +2     
     Lines       23036    23042       +6     
     Branches     2632     2654      +22     
   ==========================================
   + Hits        18431    18444      +13     
   + Misses       4605     4598       -7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...la/org/apache/daffodil/dsom/RestrictionUnion.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2Rzb20vUmVzdHJpY3Rpb25Vbmlvbi5zY2FsYQ==) | `66.03% <ø> (ø)` | :arrow_up: |
   | [...rg/apache/daffodil/processors/TypeCalculator.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL1R5cGVDYWxjdWxhdG9yLnNjYWxh) | `82.25% <ø> (+6.95%)` | :arrow_up: |
   | [...ffodil/processors/parsers/ElementKindParsers.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtcnVudGltZTEvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9kYWZmb2RpbC9wcm9jZXNzb3JzL3BhcnNlcnMvRWxlbWVudEtpbmRQYXJzZXJzLnNjYWxh) | `84.5% <ø> (ø)` | :arrow_up: |
   | [...n/scala/org/apache/daffodil/dsom/SimpleTypes.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2Rzb20vU2ltcGxlVHlwZXMuc2NhbGE=) | `79.37% <100%> (-0.46%)` | :arrow_down: |
   | [...in/scala/org/apache/daffodil/util/RangeBound.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtbGliL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvZGFmZm9kaWwvdXRpbC9SYW5nZUJvdW5kLnNjYWxh) | `59.52% <59.52%> (ø)` | |
   | [...daffodil/grammar/primitives/ChoiceCombinator.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtY29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2RhZmZvZGlsL2dyYW1tYXIvcHJpbWl0aXZlcy9DaG9pY2VDb21iaW5hdG9yLnNjYWxh) | `93.4% <81.81%> (+8.34%)` | :arrow_up: |
   | [...in/scala/org/apache/daffodil/cookers/Cookers.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtbGliL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvZGFmZm9kaWwvY29va2Vycy9Db29rZXJzLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...odil/schema/annotation/props/PropertyScoping.scala](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree#diff-ZGFmZm9kaWwtbGliL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvZGFmZm9kaWwvc2NoZW1hL2Fubm90YXRpb24vcHJvcHMvUHJvcGVydHlTY29waW5nLnNjYWxh) | `87.09% <0%> (-3.23%)` | :arrow_down: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-daffodil/pull/240/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=footer). Last update [113015f...f18b5bf](https://codecov.io/gh/apache/incubator-daffodil/pull/240?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services