You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/01 07:56:58 UTC

[GitHub] [apisix-ingress-controller] Chever-John opened a new issue, #1201: bug: Discuss how to face the docker compose update

Chever-John opened a new issue, #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201

   ### Issue description
   
   When I was preparing to build the development environment on my new host, I was surprised to find a simple ci build problem after running the make-e2e-test-local command.
   
   This is easy to fix, the official command seems to have been updated from `docker-compose` to `docker compose`.
   
   So do we need to have a discussion about this situation?
   
   
   ### Environment
   
   - your apisix-ingress-controller version (output of apisix-ingress-controller version --long):
   - your Kubernetes cluster version (output of kubectl version):
   - if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):
   
   
   ### Minimal test code / Steps to reproduce
   
   1. run the command `make e2e-test-local`;
   
   ### Actual result
   
   ```bash
   ./test/e2e/testdata/wolf-rbac/cmd.sh: line 33: docker-compose: command not found
   ./test/e2e/testdata/wolf-rbac/cmd.sh: line 36: docker-compose: command not found
   curl: (7) Failed connect to 127.0.0.1:12180; Connection refused
   curl: (7) Failed connect to 127.0.0.1:12180; Connection refused
   curl: (7) Failed connect to 127.0.0.1:12180; Connection refused
   make: *** [e2e-wolf-rbac] Error 7
   ```
   
   ### Error log
   
   none
   
   ### Expected result
   
   Success!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on issue #1201: bug: Discuss how to face the docker compose update

Posted by GitBox <gi...@apache.org>.
Chever-John commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1200994585

   @AlinsRan 
   Maybe I didn't express myself clearly. What I meant was that the latest version of docker compose executes the command `docker compose` instead of `docker-compose`. So do we have to improve the makefile to accommodate this change. Or does anyone have a better suggestion?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1201: bug: Discuss how to face the docker compose update

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1202220042

   Here you can simply add a conditional judgment.
   Determine if there is a `docker-compose` command on the machine.
   Or check if any `compose` plugin has been installed.
   
   I think what is needed here is compatibility, not replacement.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #1201: bug: Discuss how to face the docker compose update

Posted by GitBox <gi...@apache.org>.
AlinsRan commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1200923977

   You have not installed docker-compose.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on issue #1201: test: Discuss how to face the docker compose update

Posted by "Chever-John (via GitHub)" <gi...@apache.org>.
Chever-John commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1517887192

   if we can use code as following
   
   ```shell
   if command -v "docker compose" > /dev/null 2>&1; then
       alias docker-compose='docker compose'
   fi
   ```
   
   to check if the `docker componse` exist.
   
   Copyright by openai :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] AlinsRan closed issue #1201: test: Discuss how to face the docker compose update

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan closed issue #1201: test: Discuss how to face the docker compose update
URL: https://github.com/apache/apisix-ingress-controller/issues/1201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] zaunist commented on issue #1201: bug: Discuss how to face the docker compose update

Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1202188720

   > First, I have installed Docker Compose!
   > 
   > @AlinsRan Maybe I didn't express myself clearly. What I meant was that the latest version of docker compose executes the command `docker compose` instead of `docker-compose`. So do we have to improve the makefile to accommodate this change. Or does anyone have a better suggestion?
   
   Hello, @Chever-John. 
   
   I went through the [Docker documentation](https://docs.docker.com/compose/) and noticed the following passage
   
   > Run docker compose up and the [Docker compose command](https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command) starts and runs your entire app. You can alternatively run docker-compose up using Compose standalone(docker-compose binary).
   
   I think the problem here is that the new version of docker integrates the `compose` command and you are trying to use the new way, but docker also supports the old version of `docker-compose`. considering the compatibility with the old version, I think it is better to keep the current approach.
   
   Feel free to point out if I'm wrong in my description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #1201: test: Discuss how to face the docker compose update

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1653344263

   Yeah. My negligence. 
   PR has been merged, I will close this issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on issue #1201: test: Discuss how to face the docker compose update

Posted by GitBox <gi...@apache.org>.
Chever-John commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1202711133

   @zaunist 
   Thanks for your document which is very important.
   
   @tao12345666333 
   Agree!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] leowmjw commented on issue #1201: test: Discuss how to face the docker compose update

Posted by "leowmjw (via GitHub)" <gi...@apache.org>.
leowmjw commented on issue #1201:
URL: https://github.com/apache/apisix-ingress-controller/issues/1201#issuecomment-1653239627

   @AlinsRan Issue to be closed since PRs merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org