You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/05 04:24:24 UTC

[GitHub] [fineract] xurror commented on a change in pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check

xurror commented on a change in pull request #982:
URL: https://github.com/apache/fineract/pull/982#discussion_r435682753



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountNumberPreferencesTest.java
##########
@@ -376,7 +376,7 @@ private void validateAccountNumberLengthAndStartsWithPrefix(final String account
             Assert.assertEquals(accountNumber.length(), prefix.length() + 9);
             Assert.assertTrue(accountNumber.startsWith(prefix));
         } else {
-            Assert.assertEquals(accountNumber.length(), 9);
+            Assert.assertEquals( 9,accountNumber.length());

Review comment:
       Does this stuff also reject space separated commas. It's not a big deal I'd prefer if there is a space after the comma. Makes stuff more readable. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org