You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2010/11/30 21:07:58 UTC
svn commit: r1040749 -
/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java
Author: mgrigorov
Date: Tue Nov 30 20:07:58 2010
New Revision: 1040749
URL: http://svn.apache.org/viewvc?rev=1040749&view=rev
Log:
WICKET-2698 Page Parameters needs to implement equals
Remove a TODO. The new PageParameters class has a better #equals() implementation based on StringValue and the problem in this ticket is not applicable
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java
Modified: wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java?rev=1040749&r1=1040748&r2=1040749&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java (original)
+++ wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java Tue Nov 30 20:07:58 2010
@@ -549,8 +549,6 @@ public class PageParameters implements S
*/
public static boolean equals(PageParameters p1, PageParameters p2)
{
- // @TODO see wicket-2698 and review patch applied to 1.4 if it needs to be applied here as
- // well.
if (Objects.equal(p1, p2))
{
return true;