You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by wkk91193 <gi...@git.apache.org> on 2018/06/19 14:45:06 UTC
[GitHub] fineract pull request #458: Implementing Trial balance job
GitHub user wkk91193 opened a pull request:
https://github.com/apache/fineract/pull/458
Implementing Trial balance job
Creating a consolidated entry in the trial balance table for each day with the aggregation of all journal entries for that given day by grouping by GL account, branch, transaction date and updating the closing balance. As for which the results can be used for any reporting service or MIS requirements of MFIs or for merely reconciliation requirements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wkk91193/incubator-fineract performance-and-scalability-enhancements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/fineract/pull/458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #458
----
commit 8187375df15c147ae1386d7501007a7ec919ead2
Author: unknown <wk...@...>
Date: 2018-06-19T14:41:43Z
Implementing Trial balance job
----
---
[GitHub] fineract issue #458: Implementing Trial balance job
Posted by avikganguly01 <gi...@git.apache.org>.
Github user avikganguly01 commented on the issue:
https://github.com/apache/fineract/pull/458
Include JIRA ticket in PR name. If no ticket exists, create one.
---
[GitHub] fineract issue #458: FINERACT-637: Implementing Trial balance job
Posted by wkk91193 <gi...@git.apache.org>.
Github user wkk91193 commented on the issue:
https://github.com/apache/fineract/pull/458
@avikganguly01
Removing collate,engine details and adding index to transaction_date done!
---
[GitHub] fineract pull request #458: Implementing Trial balance job
Posted by avikganguly01 <gi...@git.apache.org>.
Github user avikganguly01 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/458#discussion_r197643042
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V343__m_trial_balance_table.sql ---
@@ -0,0 +1,34 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+CREATE TABLE `m_trial_balance` (
+ `office_id` BIGINT(20) NOT NULL,
+ `account_id` BIGINT(20) NOT NULL,
+ `amount` DECIMAL(19,6) NOT NULL,
+ `entry_date` DATE NOT NULL,
+ `created_date` DATE NULL,
+ `closing_balance` DECIMAL(19,6) NOT NULL
+)
+COLLATE='latin1_swedish_ci'
+ENGINE=InnoDB;
+
--- End diff --
Remove collate and engine details.
---
[GitHub] fineract pull request #458: Implementing Trial balance job
Posted by avikganguly01 <gi...@git.apache.org>.
Github user avikganguly01 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/458#discussion_r197643049
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V343__m_trial_balance_table.sql ---
@@ -0,0 +1,34 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+CREATE TABLE `m_trial_balance` (
+ `office_id` BIGINT(20) NOT NULL,
+ `account_id` BIGINT(20) NOT NULL,
+ `amount` DECIMAL(19,6) NOT NULL,
+ `entry_date` DATE NOT NULL,
+ `created_date` DATE NULL,
+ `closing_balance` DECIMAL(19,6) NOT NULL
+)
+COLLATE='latin1_swedish_ci'
+ENGINE=InnoDB;
+
+INSERT INTO `job` (`name`, `display_name`, `cron_expression`, `create_time`, `task_priority`, `group_name`, `previous_run_start_time`, `next_run_time`, `job_key`, `initializing_errorlog`, `is_active`, `currently_running`, `updates_allowed`, `scheduler_group`, `is_misfired`) VALUES ('Update Trial Balance Details', 'Update Trial Balance Details', '0 1 0 1/1 * ? *', now(), 5, NULL, NULL, NULL, NULL, NULL, 1, 0, 1, 0, 0);
+
+ALTER TABLE acc_gl_journal_entry ADD transaction_date date;
+
--- End diff --
Also add index on transaction_date column.
---